Re: [U-Boot] [PATCH 06/10][v6] DM: crypto/fsl - Add Freescale rsa DM driver

2015-01-28 Thread Simon Glass
On 26 January 2015 at 06:39, Simon Glass  wrote:
> On 23 January 2015 at 03:31, Ruchika Gupta  
> wrote:
>> Driver added for RSA Modular Exponentiation using Freescale Hardware
>> Accelerator CAAM. The driver uses UCLASS_MOD_EXP
>>
>> Signed-off-by: Ruchika Gupta 
>> CC: Simon Glass 
>> ---
>> Changes in v6:
>> No Changes
>>
>> Changes in v5:
>> Reverted mod_exp not to use output length
>>
>> Changes in v4:
>> Modified for the changes in op function of rsa class mod_exp
>>
>> Changes in v3:
>> Moved to integrate with RSA UCLASS
>>
>>  drivers/crypto/Kconfig|  1 +
>>  drivers/crypto/fsl/Kconfig|  6 +
>>  drivers/crypto/fsl/Makefile   |  1 +
>>  drivers/crypto/fsl/fsl_rsa.c  | 60 
>> +++
>>  drivers/crypto/fsl/jobdesc.c  | 28 
>>  drivers/crypto/fsl/jobdesc.h  |  5 
>>  drivers/crypto/fsl/rsa_caam.h | 28 
>>  7 files changed, 129 insertions(+)
>>  create mode 100644 drivers/crypto/fsl/Kconfig
>>  create mode 100644 drivers/crypto/fsl/fsl_rsa.c
>>  create mode 100644 drivers/crypto/fsl/rsa_caam.h
>
> I don't see what you want inline functions in jobdesc.h, but I suppose
> that is your business.
>
> Acked-by: Simon Glass 

Applied to u-boot-dm, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 06/10][v6] DM: crypto/fsl - Add Freescale rsa DM driver

2015-01-26 Thread Simon Glass
On 23 January 2015 at 03:31, Ruchika Gupta  wrote:
> Driver added for RSA Modular Exponentiation using Freescale Hardware
> Accelerator CAAM. The driver uses UCLASS_MOD_EXP
>
> Signed-off-by: Ruchika Gupta 
> CC: Simon Glass 
> ---
> Changes in v6:
> No Changes
>
> Changes in v5:
> Reverted mod_exp not to use output length
>
> Changes in v4:
> Modified for the changes in op function of rsa class mod_exp
>
> Changes in v3:
> Moved to integrate with RSA UCLASS
>
>  drivers/crypto/Kconfig|  1 +
>  drivers/crypto/fsl/Kconfig|  6 +
>  drivers/crypto/fsl/Makefile   |  1 +
>  drivers/crypto/fsl/fsl_rsa.c  | 60 
> +++
>  drivers/crypto/fsl/jobdesc.c  | 28 
>  drivers/crypto/fsl/jobdesc.h  |  5 
>  drivers/crypto/fsl/rsa_caam.h | 28 
>  7 files changed, 129 insertions(+)
>  create mode 100644 drivers/crypto/fsl/Kconfig
>  create mode 100644 drivers/crypto/fsl/fsl_rsa.c
>  create mode 100644 drivers/crypto/fsl/rsa_caam.h

I don't see what you want inline functions in jobdesc.h, but I suppose
that is your business.

Acked-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 06/10][v6] DM: crypto/fsl - Add Freescale rsa DM driver

2015-01-23 Thread Ruchika Gupta
Driver added for RSA Modular Exponentiation using Freescale Hardware
Accelerator CAAM. The driver uses UCLASS_MOD_EXP

Signed-off-by: Ruchika Gupta 
CC: Simon Glass 
---
Changes in v6:
No Changes

Changes in v5:
Reverted mod_exp not to use output length

Changes in v4:
Modified for the changes in op function of rsa class mod_exp

Changes in v3:
Moved to integrate with RSA UCLASS

 drivers/crypto/Kconfig|  1 +
 drivers/crypto/fsl/Kconfig|  6 +
 drivers/crypto/fsl/Makefile   |  1 +
 drivers/crypto/fsl/fsl_rsa.c  | 60 +++
 drivers/crypto/fsl/jobdesc.c  | 28 
 drivers/crypto/fsl/jobdesc.h  |  5 
 drivers/crypto/fsl/rsa_caam.h | 28 
 7 files changed, 129 insertions(+)
 create mode 100644 drivers/crypto/fsl/Kconfig
 create mode 100644 drivers/crypto/fsl/fsl_rsa.c
 create mode 100644 drivers/crypto/fsl/rsa_caam.h

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e69de29..bd26a2b 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -0,0 +1 @@
+source drivers/crypto/fsl/Kconfig
diff --git a/drivers/crypto/fsl/Kconfig b/drivers/crypto/fsl/Kconfig
new file mode 100644
index 000..86b2f2f
--- /dev/null
+++ b/drivers/crypto/fsl/Kconfig
@@ -0,0 +1,6 @@
+config FSL_CAAM
+   bool "Freescale Crypto Driver Support"
+   help
+ Enables the Freescale's Cryptographic Accelerator and Assurance
+ Module (CAAM), also known as the SEC version 4 (SEC4). The driver uses
+ Job Ring as interface to communicate with CAAM.
diff --git a/drivers/crypto/fsl/Makefile b/drivers/crypto/fsl/Makefile
index cb13d2e..db3c010 100644
--- a/drivers/crypto/fsl/Makefile
+++ b/drivers/crypto/fsl/Makefile
@@ -8,3 +8,4 @@
 
 obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o
 obj-$(CONFIG_CMD_BLOB) += fsl_blob.o
+obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o
diff --git a/drivers/crypto/fsl/fsl_rsa.c b/drivers/crypto/fsl/fsl_rsa.c
new file mode 100644
index 000..cf1c4c1
--- /dev/null
+++ b/drivers/crypto/fsl/fsl_rsa.c
@@ -0,0 +1,60 @@
+/*
+ * (C) Copyright 2014 Freescale Semiconductor, Inc.
+ * Author: Ruchika Gupta 
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "jobdesc.h"
+#include "desc.h"
+#include "jr.h"
+#include "rsa_caam.h"
+#include 
+
+int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len,
+   struct key_prop *prop, uint8_t *out)
+{
+   uint32_t keylen;
+   struct pk_in_params pkin;
+   uint32_t desc[MAX_CAAM_DESCSIZE];
+   int ret;
+
+   /* Length in bytes */
+   keylen = prop->num_bits / 8;
+
+   pkin.a = sig;
+   pkin.a_siz = sig_len;
+   pkin.n = prop->modulus;
+   pkin.n_siz = keylen;
+   pkin.e = prop->public_exponent;
+   pkin.e_siz = prop->exp_len;
+
+   inline_cnstr_jobdesc_pkha_rsaexp(desc, &pkin, out, sig_len);
+
+   ret = run_descriptor_jr(desc);
+   if (ret) {
+   debug("%s: RSA failed to verify: %d\n", __func__, ret);
+   return -EFAULT;
+   }
+
+   return 0;
+}
+
+static const struct mod_exp_ops fsl_mod_exp_ops = {
+   .mod_exp= fsl_mod_exp,
+};
+
+U_BOOT_DRIVER(fsl_rsa_mod_exp) = {
+   .name   = "fsl_rsa_mod_exp",
+   .id = UCLASS_MOD_EXP,
+   .ops= &fsl_mod_exp_ops,
+};
+
+U_BOOT_DEVICE(fsl_rsa) = {
+   .name = "fsl_rsa_mod_exp",
+};
diff --git a/drivers/crypto/fsl/jobdesc.c b/drivers/crypto/fsl/jobdesc.c
index 1386bae..cc0dced 100644
--- a/drivers/crypto/fsl/jobdesc.c
+++ b/drivers/crypto/fsl/jobdesc.c
@@ -11,6 +11,7 @@
 #include 
 #include "desc_constr.h"
 #include "jobdesc.h"
+#include "rsa_caam.h"
 
 #define KEY_BLOB_SIZE  32
 #define MAC_SIZE   16
@@ -123,3 +124,30 @@ void inline_cnstr_jobdesc_rng_instantiation(uint32_t *desc)
append_operation(desc, OP_TYPE_CLASS1_ALG | OP_ALG_ALGSEL_RNG |
 OP_ALG_RNG4_SK);
 }
+
+/* Change key size to bytes form bits in calling function*/
+void inline_cnstr_jobdesc_pkha_rsaexp(uint32_t *desc,
+ struct pk_in_params *pkin, uint8_t *out,
+ uint32_t out_siz)
+{
+   dma_addr_t dma_addr_e, dma_addr_a, dma_addr_n, dma_addr_out;
+
+   dma_addr_e = virt_to_phys((void *)pkin->e);
+   dma_addr_a = virt_to_phys((void *)pkin->a);
+   dma_addr_n = virt_to_phys((void *)pkin->n);
+   dma_addr_out = virt_to_phys((void *)out);
+
+   init_job_desc(desc, 0);
+   append_key(desc, dma_addr_e, pkin->e_siz, KEY_DEST_PKHA_E | CLASS_1);
+
+   append_fifo_load(desc, dma_addr_a,
+pkin->a_siz, LDST_CLASS_1_CCB | FIFOLD_TYPE_PK_A);
+
+   append_fifo_load(desc, dma_addr_n,
+pkin->n_siz, LDST_CLASS_1_CCB | FIFOLD_TYPE_PK_N);
+
+   append_operation(desc, OP_TYPE_PK | OP_ALG_PK | OP_ALG_PKMODE_MOD_