Re: [U-Boot] [PATCH 06/15] kirkwood: kconfig: refactor Kconfig and defconfig

2014-08-05 Thread Luka Perkov
Hi Masahiro,

On Mon, Aug 04, 2014 at 10:19:19PM +0900, Masahiro Yamada wrote:
 Becuase the board select menu in arch/arm/Kconfig is too big,
 move the KirkWood board select menu to kirkwood/Kconfig.
 
 Consolidate also common settings (CONFIG_SYS_CPU=arm926ejs and
 CONFIG_SYS_SOC=kirkwood).
 
 Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
 Cc: Prafulla Wadaskar prafu...@marvell.com
 ---

I have just a few minor style comments below...

 +config TARGET_DREAMPLUG
 + bool Dreamplug Board

This sould be DramPlug Board.

 +config TARGET_GURUPLUG
 + bool Guruplug Board

This sould be GuruPlug Board.

 +config TARGET_SHEEVAPLUG
 + bool Sheevaplug Board

This sould be SheevaPlug Board.

 +config TARGET_IB62X0
 + bool Ib62x0 Board

This sould be ib62x0 Board.

 +config TARGET_GOFLEXHOME
 + bool Goflexhome Board

This sould be GoFlex Home Board.

Luka
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 06/15] kirkwood: kconfig: refactor Kconfig and defconfig

2014-08-05 Thread Masahiro Yamada
Hi Luka,



On Tue, 5 Aug 2014 10:54:56 +0200
Luka Perkov l...@openwrt.org wrote:

 Hi Masahiro,
 
 On Mon, Aug 04, 2014 at 10:19:19PM +0900, Masahiro Yamada wrote:
  Becuase the board select menu in arch/arm/Kconfig is too big,
  move the KirkWood board select menu to kirkwood/Kconfig.
  
  Consolidate also common settings (CONFIG_SYS_CPU=arm926ejs and
  CONFIG_SYS_SOC=kirkwood).
  
  Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
  Cc: Prafulla Wadaskar prafu...@marvell.com
  ---
 
 I have just a few minor style comments below...
 
  +config TARGET_DREAMPLUG
  +   bool Dreamplug Board
 
 This sould be DramPlug Board.

I assume this is a typo.

DreamPlug Board  ?



I will fix in v2.

Thanks for pointing out it.



Best Regards
Masahiro Yamada

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 06/15] kirkwood: kconfig: refactor Kconfig and defconfig

2014-08-05 Thread Luka Perkov
Hi Masahiro,

On Tue, Aug 05, 2014 at 06:08:21PM +0900, Masahiro Yamada wrote:
 On Tue, 5 Aug 2014 10:54:56 +0200
   +config TARGET_DREAMPLUG
   + bool Dreamplug Board
  
  This sould be DramPlug Board.
 
 I assume this is a typo.
 
 DreamPlug Board  ?

Yes, sorry.

 I will fix in v2.

Great, thanks.

Luka
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 06/15] kirkwood: kconfig: refactor Kconfig and defconfig

2014-08-04 Thread Masahiro Yamada
Becuase the board select menu in arch/arm/Kconfig is too big,
move the KirkWood board select menu to kirkwood/Kconfig.

Consolidate also common settings (CONFIG_SYS_CPU=arm926ejs and
CONFIG_SYS_SOC=kirkwood).

Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
Cc: Prafulla Wadaskar prafu...@marvell.com
---

 arch/arm/Kconfig| 75 ++-
 arch/arm/cpu/arm926ejs/kirkwood/Kconfig | 89 +
 board/LaCie/net2big_v2/Kconfig  |  8 ---
 board/LaCie/netspace_v2/Kconfig |  8 ---
 board/LaCie/wireless_space/Kconfig  |  8 ---
 board/Marvell/dreamplug/Kconfig |  8 ---
 board/Marvell/guruplug/Kconfig  |  8 ---
 board/Marvell/mv88f6281gtw_ge/Kconfig   |  8 ---
 board/Marvell/openrd/Kconfig|  8 ---
 board/Marvell/rd6281a/Kconfig   |  8 ---
 board/Marvell/sheevaplug/Kconfig|  8 ---
 board/Seagate/dockstar/Kconfig  |  8 ---
 board/Seagate/goflexhome/Kconfig|  8 ---
 board/buffalo/lsxl/Kconfig  |  8 ---
 board/cloudengines/pogo_e02/Kconfig |  8 ---
 board/d-link/dns325/Kconfig |  8 ---
 board/iomega/iconnect/Kconfig   |  8 ---
 board/karo/tk71/Kconfig |  8 ---
 board/keymile/km_arm/Kconfig|  8 ---
 board/raidsonic/ib62x0/Kconfig  |  8 ---
 configs/d2net_v2_defconfig  |  1 +
 configs/dns325_defconfig|  1 +
 configs/dockstar_defconfig  |  1 +
 configs/dreamplug_defconfig |  1 +
 configs/goflexhome_defconfig|  1 +
 configs/guruplug_defconfig  |  1 +
 configs/ib62x0_defconfig|  1 +
 configs/iconnect_defconfig  |  1 +
 configs/inetspace_v2_defconfig  |  1 +
 configs/km_kirkwood_128m16_defconfig|  1 +
 configs/km_kirkwood_defconfig   |  1 +
 configs/km_kirkwood_pci_defconfig   |  1 +
 configs/kmcoge5un_defconfig |  1 +
 configs/kmnusa_defconfig|  1 +
 configs/kmsugp1_defconfig   |  1 +
 configs/kmsuv31_defconfig   |  1 +
 configs/lschlv2_defconfig   |  1 +
 configs/lsxhl_defconfig |  1 +
 configs/mgcoge3un_defconfig |  1 +
 configs/mv88f6281gtw_ge_defconfig   |  1 +
 configs/net2big_v2_defconfig|  1 +
 configs/netspace_lite_v2_defconfig  |  1 +
 configs/netspace_max_v2_defconfig   |  1 +
 configs/netspace_mini_v2_defconfig  |  1 +
 configs/netspace_v2_defconfig   |  1 +
 configs/openrd_base_defconfig   |  1 +
 configs/openrd_client_defconfig |  1 +
 configs/openrd_ultimate_defconfig   |  1 +
 configs/pogo_e02_defconfig  |  1 +
 configs/portl2_defconfig|  1 +
 configs/rd6281a_defconfig   |  1 +
 configs/sheevaplug_defconfig|  1 +
 configs/tk71_defconfig  |  1 +
 configs/wireless_space_defconfig|  1 +
 include/configs/dns325.h|  1 -
 include/configs/dockstar.h  |  1 -
 include/configs/dreamplug.h |  1 -
 include/configs/goflexhome.h|  1 -
 include/configs/guruplug.h  |  1 -
 include/configs/ib62x0.h|  1 -
 include/configs/iconnect.h  |  1 -
 include/configs/km/km_arm.h |  1 -
 include/configs/lacie_kw.h  |  1 -
 include/configs/lsxl.h  |  1 -
 include/configs/mv88f6281gtw_ge.h   |  1 -
 include/configs/openrd.h|  1 -
 include/configs/pogo_e02.h  |  1 -
 include/configs/rd6281a.h   |  1 -
 include/configs/sheevaplug.h|  1 -
 include/configs/tk71.h  |  1 -
 include/configs/wireless_space.h|  1 -
 71 files changed, 127 insertions(+), 232 deletions(-)
 create mode 100644 arch/arm/cpu/arm926ejs/kirkwood/Kconfig

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 955fce8..43d0ce5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -179,59 +179,8 @@ config TARGET_ENBW_CMC
 config TARGET_CALIMAIN
bool Support calimain
 
-config TARGET_LSXL
-   bool Support lsxl
-
-config TARGET_POGO_E02
-   bool Support pogo_e02
-
-config TARGET_DNS325
-   bool Support dns325
-
-config TARGET_ICONNECT
-   bool Support iconnect
-
-config TARGET_TK71
-   bool Support tk71
-
-config TARGET_KM_KIRKWOOD
-   bool Support km_kirkwood
-
-config TARGET_NET2BIG_V2
-   bool Support net2big_v2
-
-config TARGET_NETSPACE_V2
-   bool Support netspace_v2
-
-config TARGET_WIRELESS_SPACE
-   bool Support wireless_space
-
-config TARGET_DREAMPLUG
-   bool Support dreamplug
-
-config TARGET_GURUPLUG
-   bool Support guruplug
-
-config TARGET_MV88F6281GTW_GE
-   bool Support mv88f6281gtw_ge
-
-config TARGET_OPENRD
-   bool Support openrd
-
-config TARGET_RD6281A
-   bool Support rd6281a
-
-config TARGET_SHEEVAPLUG
-   bool