Re: [U-Boot] [PATCH 073/126] trace: Remove the const from write functions

[Bin Meng]

On Thu, Oct 10, 2019 at 11:20 AM Bin Meng  wrote:
>
> On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
> >
> > The write functions do actually change the contents of memory so it is not
> > correct to use 'const'. Remove it.
> >
> > Signed-off-by: Simon Glass 
> > ---
> >
> >  common/iotrace.c  |  6 +++---
> >  include/iotrace.h | 13 ++---
> >  2 files changed, 9 insertions(+), 10 deletions(-)
> >
>
> Reviewed-by: Bin Meng 

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 073/126] trace: Remove the const from write functions

[Bin Meng]

On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
>
> The write functions do actually change the contents of memory so it is not
> correct to use 'const'. Remove it.
>
> Signed-off-by: Simon Glass 
> ---
>
>  common/iotrace.c  |  6 +++---
>  include/iotrace.h | 13 ++---
>  2 files changed, 9 insertions(+), 10 deletions(-)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 073/126] trace: Remove the const from write functions

[Simon Glass]

The write functions do actually change the contents of memory so it is not
correct to use 'const'. Remove it.

Signed-off-by: Simon Glass 
---

 common/iotrace.c  |  6 +++---
 include/iotrace.h | 13 ++---
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/common/iotrace.c b/common/iotrace.c
index 49bee3c92a0..5b92fabc76e 100644
--- a/common/iotrace.c
+++ b/common/iotrace.c
@@ -86,7 +86,7 @@ u32 iotrace_readl(const void *ptr)
return v;
 }
 
-void iotrace_writel(ulong value, const void *ptr)
+void iotrace_writel(ulong value, void *ptr)
 {
add_record(IOT_32 | IOT_WRITE, ptr, value);
writel(value, ptr);
@@ -102,7 +102,7 @@ u16 iotrace_readw(const void *ptr)
return v;
 }
 
-void iotrace_writew(ulong value, const void *ptr)
+void iotrace_writew(ulong value, void *ptr)
 {
add_record(IOT_16 | IOT_WRITE, ptr, value);
writew(value, ptr);
@@ -118,7 +118,7 @@ u8 iotrace_readb(const void *ptr)
return v;
 }
 
-void iotrace_writeb(ulong value, const void *ptr)
+void iotrace_writeb(ulong value, void *ptr)
 {
add_record(IOT_8 | IOT_WRITE, ptr, value);
writeb(value, ptr);
diff --git a/include/iotrace.h b/include/iotrace.h
index be1d2753e19..380da1fbc2c 100644
--- a/include/iotrace.h
+++ b/include/iotrace.h
@@ -49,30 +49,29 @@ struct iotrace_record {
 #define readl(addr)iotrace_readl((const void *)(addr))
 
 #undef writel
-#define writel(val, addr)  iotrace_writel(val, (const void *)(addr))
+#define writel(val, addr)  iotrace_writel(val, (void *)(addr))
 
 #undef readw
 #define readw(addr)iotrace_readw((const void *)(addr))
 
 #undef writew
-#define writew(val, addr)  iotrace_writew(val, (const void *)(addr))
+#define writew(val, addr)  iotrace_writew(val, (void *)(addr))
 
 #undef readb
 #define readb(addr)iotrace_readb((const void *)(uintptr_t)addr)
 
 #undef writeb
-#define writeb(val, addr) \
-   iotrace_writeb(val, (const void *)(uintptr_t)addr)
+#define writeb(val, addr)  iotrace_writeb(val, (void *)(uintptr_t)addr)
 
 #endif
 
 /* Tracing functions which mirror their io.h counterparts */
 u32 iotrace_readl(const void *ptr);
-void iotrace_writel(ulong value, const void *ptr);
+void iotrace_writel(ulong value, void *ptr);
 u16 iotrace_readw(const void *ptr);
-void iotrace_writew(ulong value, const void *ptr);
+void iotrace_writew(ulong value, void *ptr);
 u8 iotrace_readb(const void *ptr);
-void iotrace_writeb(ulong value, const void *ptr);
+void iotrace_writeb(ulong value, void *ptr);
 
 /**
  * iotrace_reset_checksum() - Reset the iotrace checksum
-- 
2.23.0.444.g18eeb5a265-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot