Re: [U-Boot] [PATCH 1/1] bios_emulator: remove stray break
On Thu, Aug 8, 2019 at 9:31 PM Bin Meng wrote: > > On Fri, Aug 2, 2019 at 1:37 AM Heinrich Schuchardt wrote: > > > > Remove a stray break which suppresses some debug messages. > > > > Indicated by cppcheck. > > > > Signed-off-by: Heinrich Schuchardt > > --- > > @Simon: > > Please, test on an x86 Chromebook. I have no access to a test device. > > --- > > drivers/bios_emulator/atibios.c | 1 - > > 1 file changed, 1 deletion(-) > > > > Acked-by: Bin Meng applied to u-boot-x86, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] bios_emulator: remove stray break
On Fri, Aug 2, 2019 at 1:37 AM Heinrich Schuchardt wrote: > > Remove a stray break which suppresses some debug messages. > > Indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt > --- > @Simon: > Please, test on an x86 Chromebook. I have no access to a test device. > --- > drivers/bios_emulator/atibios.c | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] bios_emulator: remove stray break
On Thu, 1 Aug 2019 at 11:37, Heinrich Schuchardt wrote: > > Remove a stray break which suppresses some debug messages. > > Indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt > --- > @Simon: > Please, test on an x86 Chromebook. I have no access to a test device. > --- > drivers/bios_emulator/atibios.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 1/1] bios_emulator: remove stray break
Remove a stray break which suppresses some debug messages. Indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- @Simon: Please, test on an x86 Chromebook. I have no access to a test device. --- drivers/bios_emulator/atibios.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bios_emulator/atibios.c b/drivers/bios_emulator/atibios.c index 4f362d1453..fb806b53d4 100644 --- a/drivers/bios_emulator/atibios.c +++ b/drivers/bios_emulator/atibios.c @@ -136,7 +136,6 @@ static int atibios_debug_mode(BE_VGAInfo *vga_info, RMREGS *regs, bool linear_ok; int attr; - break; debug("Mode %x: ", mode); memset(buffer, '\0', sizeof(struct vbe_mode_info)); regs->e.eax = VESA_GET_MODE_INFO; -- 2.20.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot