Re: [U-Boot] [PATCH 1/1] efi_selftest: expect boot services data for fdt

[Ilias Apalodimas]

Hi Heinrich,
> In a previous patch the memory type used for the FDT has been changed to
> boot services data. We have to adjust the test.
> 
> Correct an incorrect comment. The tested services are boot services.
> 
> Signed-off-by: Heinrich Schuchardt 
> ---
>  lib/efi_selftest/efi_selftest_memory.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/efi_selftest/efi_selftest_memory.c 
> b/lib/efi_selftest/efi_selftest_memory.c
> index d41227b605..5eeb42a9be 100644
> --- a/lib/efi_selftest/efi_selftest_memory.c
> +++ b/lib/efi_selftest/efi_selftest_memory.c
> @@ -4,7 +4,7 @@
>   *
>   * Copyright (c) 2018 Heinrich Schuchardt 
>   *
> - * This unit test checks the following runtime services:
> + * This unit test checks the following boottime services:
>   * AllocatePages, FreePages, GetMemoryMap
>   *
>   * The memory type used for the device tree is checked.
> @@ -176,9 +176,9 @@ static int execute(void)
>   /* Check memory reservation for the device tree */
>   if (fdt_addr &&
>   find_in_memory_map(map_size, memory_map, desc_size, fdt_addr,
> -EFI_RUNTIME_SERVICES_DATA) != EFI_ST_SUCCESS) {
> +EFI_BOOT_SERVICES_DATA) != EFI_ST_SUCCESS) {
>   efi_st_error
> - ("Device tree not marked as runtime services data\n");
> + ("Device tree not marked as boot services data\n");
>   return EFI_ST_FAILURE;
>   }
>   return EFI_ST_SUCCESS;
> --
> 2.20.1
> 
I probably should have updated that myself. Thanks for catching this

Reviewed-by: Ilias Apalodimas 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/1] efi_selftest: expect boot services data for fdt

[Heinrich Schuchardt]

In a previous patch the memory type used for the FDT has been changed to
boot services data. We have to adjust the test.

Correct an incorrect comment. The tested services are boot services.

Signed-off-by: Heinrich Schuchardt 
---
 lib/efi_selftest/efi_selftest_memory.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/efi_selftest/efi_selftest_memory.c 
b/lib/efi_selftest/efi_selftest_memory.c
index d41227b605..5eeb42a9be 100644
--- a/lib/efi_selftest/efi_selftest_memory.c
+++ b/lib/efi_selftest/efi_selftest_memory.c
@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2018 Heinrich Schuchardt 
  *
- * This unit test checks the following runtime services:
+ * This unit test checks the following boottime services:
  * AllocatePages, FreePages, GetMemoryMap
  *
  * The memory type used for the device tree is checked.
@@ -176,9 +176,9 @@ static int execute(void)
/* Check memory reservation for the device tree */
if (fdt_addr &&
find_in_memory_map(map_size, memory_map, desc_size, fdt_addr,
-  EFI_RUNTIME_SERVICES_DATA) != EFI_ST_SUCCESS) {
+  EFI_BOOT_SERVICES_DATA) != EFI_ST_SUCCESS) {
efi_st_error
-   ("Device tree not marked as runtime services data\n");
+   ("Device tree not marked as boot services data\n");
return EFI_ST_FAILURE;
}
return EFI_ST_SUCCESS;
--
2.20.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot