Re: [U-Boot] [PATCH 1/2] POWER: MAX77686: Modified as per the latest Implementation

2012-12-12 Thread Simon Glass
Hi Rajeshwari,

On Mon, Dec 10, 2012 at 3:55 AM, Rajeshwari Shinde
rajeshwar...@samsung.com wrote:
 Moved the pmic_max77686.c max77686_pmic.h to drivers/power
 and made required changes accordingly

 Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com

Acked-by: Simon Glass s...@chomium.org

See nit below if you end up resending.

You might consider using the -M option to git format-patch which
detects renames. Or you could use patman...


 ---
  drivers/misc/pmic_max77686.c   |   42 --
  drivers/power/pmic/Makefile|1 +
  drivers/power/pmic/pmic_max77686.c |   48 +++
  include/max77686_pmic.h|  158 
 
  include/power/max77686_pmic.h  |  158 
 
  5 files changed, 207 insertions(+), 200 deletions(-)
  delete mode 100644 drivers/misc/pmic_max77686.c
  create mode 100644 drivers/power/pmic/pmic_max77686.c
  delete mode 100644 include/max77686_pmic.h
  create mode 100644 include/power/max77686_pmic.h

 diff --git a/drivers/misc/pmic_max77686.c b/drivers/misc/pmic_max77686.c
 deleted file mode 100644
 index 36f7f4d..000

[snip]
\
 +++ b/drivers/power/pmic/pmic_max77686.c
 @@ -0,0 +1,48 @@
 +/*
 + *  Copyright (C) 2012 Samsung Electronics
 + *  Rajeshwari Shinde rajeshwar...@samsung.com
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#include common.h
 +#include power/pmic.h
 +#include power/max77686_pmic.h
 +#include errno.h

I think this should go above the power/ headers, below common.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/2] POWER: MAX77686: Modified as per the latest Implementation

2012-12-10 Thread Rajeshwari Shinde
Moved the pmic_max77686.c max77686_pmic.h to drivers/power
and made required changes accordingly

Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com
---
 drivers/misc/pmic_max77686.c   |   42 --
 drivers/power/pmic/Makefile|1 +
 drivers/power/pmic/pmic_max77686.c |   48 +++
 include/max77686_pmic.h|  158 
 include/power/max77686_pmic.h  |  158 
 5 files changed, 207 insertions(+), 200 deletions(-)
 delete mode 100644 drivers/misc/pmic_max77686.c
 create mode 100644 drivers/power/pmic/pmic_max77686.c
 delete mode 100644 include/max77686_pmic.h
 create mode 100644 include/power/max77686_pmic.h

diff --git a/drivers/misc/pmic_max77686.c b/drivers/misc/pmic_max77686.c
deleted file mode 100644
index 36f7f4d..000
--- a/drivers/misc/pmic_max77686.c
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- *  Copyright (C) 2012 Samsung Electronics
- *  Rajeshwari Shinde rajeshwar...@samsung.com
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-#include common.h
-#include pmic.h
-#include max77686_pmic.h
-
-int pmic_init(void)
-{
-   struct pmic *p = get_pmic();
-   static const char name[] = MAX77686_PMIC;
-
-   puts(Board PMIC init\n);
-   p-name = name;
-   p-interface = PMIC_I2C;
-   p-number_of_regs = PMIC_NUM_OF_REGS;
-   p-hw.i2c.addr = MAX77686_I2C_ADDR;
-   p-hw.i2c.tx_num = 1;
-   p-bus = I2C_PMIC;
-
-   return 0;
-}
diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
index e19a9a8..14d426f 100644
--- a/drivers/power/pmic/Makefile
+++ b/drivers/power/pmic/Makefile
@@ -28,6 +28,7 @@ LIB   := $(obj)libpmic.o
 COBJS-$(CONFIG_POWER_MAX8998) += pmic_max8998.o
 COBJS-$(CONFIG_POWER_MAX8997) += pmic_max8997.o
 COBJS-$(CONFIG_POWER_MUIC_MAX8997) += muic_max8997.o
+COBJS-$(CONFIG_POWER_MAX77686) += pmic_max77686.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
diff --git a/drivers/power/pmic/pmic_max77686.c 
b/drivers/power/pmic/pmic_max77686.c
new file mode 100644
index 000..fce0183
--- /dev/null
+++ b/drivers/power/pmic/pmic_max77686.c
@@ -0,0 +1,48 @@
+/*
+ *  Copyright (C) 2012 Samsung Electronics
+ *  Rajeshwari Shinde rajeshwar...@samsung.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include power/pmic.h
+#include power/max77686_pmic.h
+#include errno.h
+
+int pmic_init(unsigned char bus)
+{
+   static const char name[] = MAX77686_PMIC;
+   struct pmic *p = pmic_alloc();
+
+   if (!p) {
+   printf(%s: POWER allocation error!\n, __func__);
+   return -ENOMEM;
+   }
+
+   puts(Board PMIC init\n);
+   p-name = name;
+   p-interface = PMIC_I2C;
+   p-number_of_regs = PMIC_NUM_OF_REGS;
+   p-hw.i2c.addr = MAX77686_I2C_ADDR;
+   p-hw.i2c.tx_num = 1;
+   p-bus = bus;
+
+   return 0;
+}
diff --git a/include/max77686_pmic.h b/include/max77686_pmic.h
deleted file mode 100644
index d949ace..000
--- a/include/max77686_pmic.h
+++ /dev/null
@@ -1,158 +0,0 @@
-/*
- *  Copyright (C) 2012 Samsung Electronics
- *  Rajeshwari Shinde rajeshwar...@samsung.com
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- *