Re: [U-Boot] [PATCH 1/2] armv8: ls1088a: Enable sata on ls1088a

[York Sun]

On 10/26/2017 02:46 AM, andy.t...@nxp.com wrote:
> From: Yuantian Tang 
> 
> Enable sata feature on ls1088a platforms
> 
> Signed-off-by: Tang Yuantian 
> ---
>  include/configs/ls1088aqds.h | 12 
>  include/configs/ls1088ardb.h | 13 +
>  2 files changed, 25 insertions(+)
> 
> diff --git a/include/configs/ls1088aqds.h b/include/configs/ls1088aqds.h
> index 71d0e4e7d1..c1087edb38 100644
> --- a/include/configs/ls1088aqds.h
> +++ b/include/configs/ls1088aqds.h
> @@ -293,6 +293,18 @@ unsigned long get_board_ddr_clk(void);
>  #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS3
>  #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS5
>  
> +/* SATA */

How about check CONFIG_SCSI here, and use Kconfig to select SCSI?

> +#define CONFIG_LIBATA
> +#define CONFIG_SCSI
> +#define CONFIG_SCSI_AHCI
> +#define CONFIG_SCSI_AHCI_PLAT
> +
> +#define CONFIG_SYS_SATA1   AHCI_BASE_ADDR1
> +
> +#define CONFIG_SYS_SCSI_MAX_SCSI_ID1
> +#define CONFIG_SYS_SCSI_MAX_LUN1
> +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID 
> * \
> + CONFIG_SYS_SCSI_MAX_LUN)
>  /* QSPI device */
>  #if defined(CONFIG_QSPI_BOOT)
>  #define CONFIG_FSL_QSPI
> diff --git a/include/configs/ls1088ardb.h b/include/configs/ls1088ardb.h
> index 39f1345f97..8587234dcd 100644
> --- a/include/configs/ls1088ardb.h
> +++ b/include/configs/ls1088ardb.h
> @@ -232,6 +232,19 @@
>  #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS3
>  #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS5
>  
> +/* SATA */
> +#define CONFIG_LIBATA
> +#define CONFIG_SCSI
> +#define CONFIG_SCSI_AHCI
> +#define CONFIG_SCSI_AHCI_PLAT
> +
> +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1
> +
> +#define CONFIG_SYS_SCSI_MAX_SCSI_ID  1
> +#define CONFIG_SYS_SCSI_MAX_LUN  1
> +#define CONFIG_SYS_SCSI_MAX_DEVICE   (CONFIG_SYS_SCSI_MAX_SCSI_ID * \
> + CONFIG_SYS_SCSI_MAX_LUN)
> +

Aren't the above two sections are identical? Do they fit well in the
common header file?

York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/2] armv8: ls1088a: Enable sata on ls1088a

[andy.tang]

From: Yuantian Tang 

Enable sata feature on ls1088a platforms

Signed-off-by: Tang Yuantian 
---
 include/configs/ls1088aqds.h | 12 
 include/configs/ls1088ardb.h | 13 +
 2 files changed, 25 insertions(+)

diff --git a/include/configs/ls1088aqds.h b/include/configs/ls1088aqds.h
index 71d0e4e7d1..c1087edb38 100644
--- a/include/configs/ls1088aqds.h
+++ b/include/configs/ls1088aqds.h
@@ -293,6 +293,18 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS  3
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS  5
 
+/* SATA */
+#define CONFIG_LIBATA
+#define CONFIG_SCSI
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT
+
+#define CONFIG_SYS_SATA1   AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID1
+#define CONFIG_SYS_SCSI_MAX_LUN1
+#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+   CONFIG_SYS_SCSI_MAX_LUN)
 /* QSPI device */
 #if defined(CONFIG_QSPI_BOOT)
 #define CONFIG_FSL_QSPI
diff --git a/include/configs/ls1088ardb.h b/include/configs/ls1088ardb.h
index 39f1345f97..8587234dcd 100644
--- a/include/configs/ls1088ardb.h
+++ b/include/configs/ls1088ardb.h
@@ -232,6 +232,19 @@
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS  3
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS  5
 
+/* SATA */
+#define CONFIG_LIBATA
+#define CONFIG_SCSI
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT
+
+#define CONFIG_SYS_SATA1   AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID1
+#define CONFIG_SYS_SCSI_MAX_LUN1
+#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+   CONFIG_SYS_SCSI_MAX_LUN)
+
 /* QSPI device */
 #if defined(CONFIG_QSPI_BOOT)
 #define CONFIG_FSL_QSPI
-- 
2.14.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot