Re: [U-Boot] [PATCH 1/2] cmd: remove Blackfin specific commands

2017-04-16 Thread Masahiro Yamada 
2017-04-17 4:32 GMT+09:00 Simon Glass :
> On 13 April 2017 at 19:54, Masahiro Yamada
>  wrote:
>> These commands have no user since commit ea3310e8aafa ("Blackfin:
>> Remove").
>>
>> Signed-off-by: Masahiro Yamada 
>> ---
>>
>>  cmd/Makefile |   6 --
>>  cmd/bootldr.c| 170 -
>>  cmd/cplbinfo.c   |  60 ---
>>  cmd/ldrinfo.c| 192 --
>>  cmd/otp.c| 228 
>> ---
>>  cmd/softswitch.c |  41 --
>>  cmd/spibootldr.c |  37 -
>>  7 files changed, 734 deletions(-)
>>  delete mode 100644 cmd/bootldr.c
>>  delete mode 100644 cmd/cplbinfo.c
>>  delete mode 100644 cmd/ldrinfo.c
>>  delete mode 100644 cmd/otp.c
>>  delete mode 100644 cmd/softswitch.c
>>  delete mode 100644 cmd/spibootldr.c
>
> Reviewed-by: Simon Glass 


If the subject of 2/2 is fixed-up
(http://patchwork.ozlabs.org/patch/750694/),
please do so for this as well.




-- 
Best Regards
Masahiro Yamada
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] cmd: remove Blackfin specific commands

2017-04-16 Thread Simon Glass 
On 13 April 2017 at 19:54, Masahiro Yamada
 wrote:
> These commands have no user since commit ea3310e8aafa ("Blackfin:
> Remove").
>
> Signed-off-by: Masahiro Yamada 
> ---
>
>  cmd/Makefile |   6 --
>  cmd/bootldr.c| 170 -
>  cmd/cplbinfo.c   |  60 ---
>  cmd/ldrinfo.c| 192 --
>  cmd/otp.c| 228 
> ---
>  cmd/softswitch.c |  41 --
>  cmd/spibootldr.c |  37 -
>  7 files changed, 734 deletions(-)
>  delete mode 100644 cmd/bootldr.c
>  delete mode 100644 cmd/cplbinfo.c
>  delete mode 100644 cmd/ldrinfo.c
>  delete mode 100644 cmd/otp.c
>  delete mode 100644 cmd/softswitch.c
>  delete mode 100644 cmd/spibootldr.c

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/2] cmd: remove Blackfin specific commands

2017-04-13 Thread Masahiro Yamada 
These commands have no user since commit ea3310e8aafa ("Blackfin:
Remove").

Signed-off-by: Masahiro Yamada 
---

 cmd/Makefile |   6 --
 cmd/bootldr.c| 170 -
 cmd/cplbinfo.c   |  60 ---
 cmd/ldrinfo.c| 192 --
 cmd/otp.c| 228 ---
 cmd/softswitch.c |  41 --
 cmd/spibootldr.c |  37 -
 7 files changed, 734 deletions(-)
 delete mode 100644 cmd/bootldr.c
 delete mode 100644 cmd/cplbinfo.c
 delete mode 100644 cmd/ldrinfo.c
 delete mode 100644 cmd/otp.c
 delete mode 100644 cmd/softswitch.c
 delete mode 100644 cmd/spibootldr.c

diff --git a/cmd/Makefile b/cmd/Makefile
index ef1406b..8150b24 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -23,7 +23,6 @@ obj-$(CONFIG_CMD_BLOCK_CACHE) += blkcache.o
 obj-$(CONFIG_CMD_BMP) += bmp.o
 obj-$(CONFIG_CMD_BOOTEFI) += bootefi.o
 obj-$(CONFIG_CMD_BOOTMENU) += bootmenu.o
-obj-$(CONFIG_CMD_BOOTLDR) += bootldr.o
 obj-$(CONFIG_CMD_BOOTSTAGE) += bootstage.o
 obj-$(CONFIG_CMD_BOOTZ) += bootz.o
 obj-$(CONFIG_CMD_BOOTI) += booti.o
@@ -32,7 +31,6 @@ obj-$(CONFIG_CMD_CBFS) += cbfs.o
 obj-$(CONFIG_CMD_CLK) += clk.o
 obj-$(CONFIG_CMD_CONFIG) += config.o
 obj-$(CONFIG_CMD_CONSOLE) += console.o
-obj-$(CONFIG_CMD_CPLBINFO) += cplbinfo.o
 obj-$(CONFIG_CMD_CPU) += cpu.o
 obj-$(CONFIG_DATAFLASH_MMC_SELECT) += dataflash_mmc_mux.o
 obj-$(CONFIG_CMD_DATE) += date.o
@@ -77,7 +75,6 @@ obj-$(CONFIG_CMD_IRQ) += irq.o
 obj-$(CONFIG_CMD_ITEST) += itest.o
 obj-$(CONFIG_CMD_JFFS2) += jffs2.o
 obj-$(CONFIG_CMD_CRAMFS) += cramfs.o
-obj-$(CONFIG_CMD_LDRINFO) += ldrinfo.o
 obj-$(CONFIG_LED_STATUS_CMD) += led.o
 obj-$(CONFIG_CMD_LICENSE) += license.o
 obj-y += load.o
@@ -99,7 +96,6 @@ obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o
 obj-$(CONFIG_CMD_NAND) += nand.o
 obj-$(CONFIG_CMD_NET) += net.o
 obj-$(CONFIG_CMD_ONENAND) += onenand.o
-obj-$(CONFIG_CMD_OTP) += otp.o
 obj-$(CONFIG_CMD_PART) += part.o
 ifdef CONFIG_PCI
 obj-$(CONFIG_CMD_PCI) += pci.o
@@ -118,9 +114,7 @@ obj-$(CONFIG_CMD_SF) += sf.o
 obj-$(CONFIG_SCSI) += scsi.o disk.o
 obj-$(CONFIG_CMD_SHA1SUM) += sha1sum.o
 obj-$(CONFIG_CMD_SETEXPR) += setexpr.o
-obj-$(CONFIG_CMD_SOFTSWITCH) += softswitch.o
 obj-$(CONFIG_CMD_SPI) += spi.o
-obj-$(CONFIG_CMD_SPIBOOTLDR) += spibootldr.o
 obj-$(CONFIG_CMD_STRINGS) += strings.o
 obj-$(CONFIG_CMD_TERMINAL) += terminal.o
 obj-$(CONFIG_CMD_TIME) += time.o
diff --git a/cmd/bootldr.c b/cmd/bootldr.c
deleted file mode 100644
index 38b3b2f..000
--- a/cmd/bootldr.c
+++ /dev/null
@@ -1,170 +0,0 @@
-/*
- * U-Boot - bootldr.c
- *
- * Copyright (c) 2005-2008 Analog Devices Inc.
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * Licensed under the GPL-2 or later.
- */
-
-#include 
-#include 
-#include 
-
-#include 
-#include 
-
-/* Simple sanity check on the specified address to make sure it contains
- * an LDR image of some sort.
- */
-static bool ldr_valid_signature(uint8_t *data)
-{
-#if defined(__ADSPBF561__)
-
-   /* BF56x has a 4 byte global header */
-   if (data[3] == (GFLAG_56X_SIGN_MAGIC << (GFLAG_56X_SIGN_SHIFT - 24)))
-   return true;
-
-#elif defined(__ADSPBF531__) || defined(__ADSPBF532__) || 
defined(__ADSPBF533__) || \
-  defined(__ADSPBF534__) || defined(__ADSPBF536__) || 
defined(__ADSPBF537__) || \
-  defined(__ADSPBF538__) || defined(__ADSPBF539__)
-
-   /* all the BF53x should start at this address mask */
-   uint32_t addr;
-   memmove(, data, sizeof(addr));
-   if ((addr & 0xFF0FFF0F) == 0xFF00)
-   return true;
-#else
-
-   /* everything newer has a magic byte */
-   uint32_t count;
-   memmove(, data + 8, sizeof(count));
-   if (data[3] == 0xAD && count == 0)
-   return true;
-
-#endif
-
-   return false;
-}
-
-/* If the Blackfin is new enough, the Blackfin on-chip ROM supports loading
- * LDRs from random memory addresses.  So whenever possible, use that.  In
- * the older cases (BF53x/BF561), parse the LDR format ourselves.
- */
-static void ldr_load(uint8_t *base_addr)
-{
-#if defined(__ADSPBF531__) || defined(__ADSPBF532__) || defined(__ADSPBF533__) 
|| \
-  /*defined(__ADSPBF534__) || defined(__ADSPBF536__) || defined(__ADSPBF537__) 
||*/\
-defined(__ADSPBF538__) || defined(__ADSPBF539__) || defined(__ADSPBF561__)
-
-   uint32_t addr;
-   uint32_t count;
-   uint16_t flags;
-
-   /* the bf56x has a 4 byte global header ... but it is useless to
-* us when booting an LDR from a memory address, so skip it
-*/
-# ifdef __ADSPBF561__
-   base_addr += 4;
-# endif
-
-   memmove(, base_addr + 8, sizeof(flags));
-   bfin_write_EVT1(flags & BFLAG_53X_RESVECT ? 0xFFA0 : 0xFFA08000);
-
-   do {
-   /* block header may not be aligned */
-   memmove(, base_addr, sizeof(addr));
-