Re: [U-Boot] [PATCH 1/2] powerpc/8xxx: Move fsl_is_spd() into generic 8xxx ddr code

2011-01-13 Thread Kumar Gala

On Jan 9, 2011, at 2:27 PM, Kumar Gala wrote:

 Move the parsing of hwconfig to determine if to use spd into common code
 so we can share it across all boards instead of duplicating it
 everywhere.
 
 Signed-off-by: Kumar Gala ga...@kernel.crashing.org
 ---
 arch/powerpc/cpu/mpc8xxx/ddr/options.c   |   22 +-
 arch/powerpc/include/asm/fsl_ddr_sdram.h |3 ++-
 board/freescale/corenet_ds/ddr.c |   18 ++
 3 files changed, 25 insertions(+), 18 deletions(-)

applied

- k
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/2] powerpc/8xxx: Move fsl_is_spd() into generic 8xxx ddr code

2011-01-09 Thread Kumar Gala
Move the parsing of hwconfig to determine if to use spd into common code
so we can share it across all boards instead of duplicating it
everywhere.

Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
 arch/powerpc/cpu/mpc8xxx/ddr/options.c   |   22 +-
 arch/powerpc/include/asm/fsl_ddr_sdram.h |3 ++-
 board/freescale/corenet_ds/ddr.c |   18 ++
 3 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/options.c 
b/arch/powerpc/cpu/mpc8xxx/ddr/options.c
index 774c0e4..c641e85 100644
--- a/arch/powerpc/cpu/mpc8xxx/ddr/options.c
+++ b/arch/powerpc/cpu/mpc8xxx/ddr/options.c
@@ -1,5 +1,5 @@
 /*
- * Copyright 2008, 2010 Freescale Semiconductor, Inc.
+ * Copyright 2008, 2010-2011 Freescale Semiconductor, Inc.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the Free
@@ -387,3 +387,23 @@ void check_interleaving_options(fsl_ddr_info_t *pinfo)
Memory controller interleaving disabled.\n);
}
 }
+
+int fsl_use_spd(void)
+{
+   int use_spd = 0;
+
+#ifdef CONFIG_DDR_SPD
+   /* if hwconfig is not enabled, or sdram is not defined, use spd */
+   if (hwconfig_sub(fsl_ddr, sdram)) {
+   if (hwconfig_subarg_cmp(fsl_ddr, sdram, spd))
+   use_spd = 1;
+   else if (hwconfig_subarg_cmp(fsl_ddr, sdram, fixed))
+   use_spd = 0;
+   else
+   use_spd = 1;
+   } else
+   use_spd = 1;
+#endif
+
+   return use_spd;
+}
diff --git a/arch/powerpc/include/asm/fsl_ddr_sdram.h 
b/arch/powerpc/include/asm/fsl_ddr_sdram.h
index 17d4b31..c6258db 100644
--- a/arch/powerpc/include/asm/fsl_ddr_sdram.h
+++ b/arch/powerpc/include/asm/fsl_ddr_sdram.h
@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2010 Freescale Semiconductor, Inc.
+ * Copyright 2008-2011 Freescale Semiconductor, Inc.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -213,6 +213,7 @@ typedef struct memctl_options_s {
 } memctl_options_t;
 
 extern phys_size_t fsl_ddr_sdram(void);
+extern int fsl_use_spd(void);
 
 typedef struct fixed_ddr_parm{
int min_freq;
diff --git a/board/freescale/corenet_ds/ddr.c b/board/freescale/corenet_ds/ddr.c
index 2ee0188..85b6c78 100644
--- a/board/freescale/corenet_ds/ddr.c
+++ b/board/freescale/corenet_ds/ddr.c
@@ -1,5 +1,5 @@
 /*
- * Copyright 2009-2010 Freescale Semiconductor, Inc.
+ * Copyright 2009-2011 Freescale Semiconductor, Inc.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -288,24 +288,10 @@ void fsl_ddr_board_options(memctl_options_t *popts,
 phys_size_t initdram(int board_type)
 {
phys_size_t dram_size;
-   int use_spd = 0;
 
puts(Initializing);
 
-#ifdef CONFIG_DDR_SPD
-   /* if hwconfig is not enabled, or sdram is not defined, use spd */
-   if (hwconfig_sub(fsl_ddr, sdram)) {
-   if (hwconfig_subarg_cmp(fsl_ddr, sdram, spd))
-   use_spd = 1;
-   else if (hwconfig_subarg_cmp(fsl_ddr, sdram, fixed))
-   use_spd = 0;
-   else
-   use_spd = 1;
-   } else
-   use_spd = 1;
-#endif
-
-   if (use_spd) {
+   if (fsl_use_spd()) {
puts(using SPD\n);
dram_size = fsl_ddr_sdram();
} else {
-- 
1.7.2.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot