Re: [U-Boot] [PATCH 1/3 v2] ppc4xx: Add AMCC Arches boardsupport(dual 460GT)
Dear Victor Gallardo, In message [EMAIL PROTECTED] you wrote: I reviewed this again. It cannot be part of default config. We need to do it at PREBOOT because eth_register() updates this variable each time at boot. It assigns ethact to the first ethernet port it discovers. In Arches, we need the second Ethernet port set as ethact. Updating it at preboot allows us to update after eth_register has set it. Are you sure? I think there must be something wrong with your configuration, then. Did you set ethprime ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] The more we disagree, the more chance there is that at least one of us is right. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3 v2] ppc4xx: Add AMCC Arches boardsupport(dual 460GT)
Dear Wolfgang, diff --git a/include/configs/canyonlands.h b/include/configs/canyonlands.h index 2f162e1..acad9b3 100644 --- a/include/configs/canyonlands.h +++ b/include/configs/canyonlands.h ... +#define CONFIG_PREBOOT \ + setenv ethact ppc_4xx_eth1; \ This should not be done in the preboot command, but as part of the default config instead. I reviewed this again. It cannot be part of default config. We need to do it at PREBOOT because eth_register() updates this variable each time at boot. It assigns ethact to the first ethernet port it discovers. In Arches, we need the second Ethernet port set as ethact. Updating it at preboot allows us to update after eth_register has set it. Best Regards, Victor Gallardo ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
