Re: [U-Boot] [PATCH 1/4] mvpp2: Fix warning over 32bit vs 64bit targets

[Joe Hershberger]

On Sat, Jan 27, 2018 at 1:48 PM, Tom Rini  wrote:
> When we have a driver that is used on both 32bit and 64bit targets and
> we are talking about address space we cannot use u64 nor u32 and instead
> need to use phys_addr_t.
>
> Fixes: 377883f16d36 ("net: mvpp2x: fix phy connected to wrong mdio issue")
> Cc: Stefan Chulski 
> Cc: Stefan Roese 
> Cc: Joe Hershberger 
> Signed-off-by: Tom Rini 

Reviewed-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/4] mvpp2: Fix warning over 32bit vs 64bit targets

[Stefan Roese]

On 27.01.2018 20:48, Tom Rini wrote:

When we have a driver that is used on both 32bit and 64bit targets and
we are talking about address space we cannot use u64 nor u32 and instead
need to use phys_addr_t.

Fixes: 377883f16d36 ("net: mvpp2x: fix phy connected to wrong mdio issue")
Cc: Stefan Chulski 
Cc: Stefan Roese 
Cc: Joe Hershberger 
Signed-off-by: Tom Rini 
---
  drivers/net/mvpp2.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
index 233c98b66c88..e3d31a560d54 100644
--- a/drivers/net/mvpp2.c
+++ b/drivers/net/mvpp2.c
@@ -4722,7 +4722,7 @@ static int phy_info_parse(struct udevice *dev, struct 
mvpp2_port *port)
u32 id;
u32 phyaddr = 0;
int phy_mode = -1;
-   u64 mdio_addr;
+   phys_addr_t mdio_addr;
  
  	phy_node = fdtdec_lookup_phandle(gd->fdt_blob, port_node, "phy");
  



Reviewed-by: Stefan Roese 

Thanks,
Stefan
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/4] mvpp2: Fix warning over 32bit vs 64bit targets

[Tom Rini]

When we have a driver that is used on both 32bit and 64bit targets and
we are talking about address space we cannot use u64 nor u32 and instead
need to use phys_addr_t.

Fixes: 377883f16d36 ("net: mvpp2x: fix phy connected to wrong mdio issue")
Cc: Stefan Chulski 
Cc: Stefan Roese 
Cc: Joe Hershberger 
Signed-off-by: Tom Rini 
---
 drivers/net/mvpp2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
index 233c98b66c88..e3d31a560d54 100644
--- a/drivers/net/mvpp2.c
+++ b/drivers/net/mvpp2.c
@@ -4722,7 +4722,7 @@ static int phy_info_parse(struct udevice *dev, struct 
mvpp2_port *port)
u32 id;
u32 phyaddr = 0;
int phy_mode = -1;
-   u64 mdio_addr;
+   phys_addr_t mdio_addr;
 
phy_node = fdtdec_lookup_phandle(gd->fdt_blob, port_node, "phy");
 
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot