Re: [U-Boot] [PATCH 1/6] gpt: command: Remove duplicated check for empty partition description

2015-11-18 Thread Tom Rini
On Fri, Nov 13, 2015 at 07:42:07AM +0100, Lukasz Majewski wrote:

> Exactly the same check is performed in set_gpt_info() function executed
> just after this check.
> 
> Signed-off-by: Lukasz Majewski 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/6] gpt: command: Remove duplicated check for empty partition description

2015-11-12 Thread Lukasz Majewski
Exactly the same check is performed in set_gpt_info() function executed
just after this check.

Signed-off-by: Lukasz Majewski 
---
 common/cmd_gpt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/common/cmd_gpt.c b/common/cmd_gpt.c
index c56fe15..4da2de7 100644
--- a/common/cmd_gpt.c
+++ b/common/cmd_gpt.c
@@ -276,9 +276,6 @@ static int gpt_default(block_dev_desc_t *blk_dev_desc, 
const char *str_part)
u8 part_count = 0;
disk_partition_t *partitions = NULL;
 
-   if (!str_part)
-   return -1;
-
/* fill partitions */
ret = set_gpt_info(blk_dev_desc, str_part,
_disk_guid, , _count);
-- 
2.1.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot