Re: [U-Boot] [PATCH 13/16] dts: bcm2838-rpi-4-b: Use the emmc2 interface for sdhci

[Matthias Brugger]

On 16/07/2019 15:38, and...@gherzan.ro wrote:
> From: Andrei Gherzan 
> 
> Signed-off-by: Andrei Gherzan 

Commit message.
You fix a file that you introduced in this series. Any reason why you don't just
send the file already fixed?

> ---
>  arch/arm/dts/bcm2838-rpi-4-b.dts | 16 ++--
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/dts/bcm2838-rpi-4-b.dts 
> b/arch/arm/dts/bcm2838-rpi-4-b.dts
> index 07e9a78e8d..168179c17c 100644
> --- a/arch/arm/dts/bcm2838-rpi-4-b.dts
> +++ b/arch/arm/dts/bcm2838-rpi-4-b.dts
> @@ -30,21 +30,17 @@
>   status = "okay";
>  };
>  
> -/* SDHCI is used to control the SDIO for wireless */
>   {
> - pinctrl-names = "default";
> - pinctrl-0 = <_gpio34>;
> - status = "okay";
> - bus-width = <4>;
> - non-removable;
> + status = "disabled";
>  };
>  
> -/* SDHOST is used to drive the SD card */
>   {
> - pinctrl-names = "default";
> - pinctrl-0 = <_gpio48>;
> + status = "disabled";
> +};
> +
> + {
> + compatible = "brcm,bcm2835-sdhci";
>   status = "okay";
> - bus-width = <4>;
>  };
>  
>   {
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 13/16] dts: bcm2838-rpi-4-b: Use the emmc2 interface for sdhci

[andrei]

From: Andrei Gherzan 

Signed-off-by: Andrei Gherzan 
---
 arch/arm/dts/bcm2838-rpi-4-b.dts | 16 ++--
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/arch/arm/dts/bcm2838-rpi-4-b.dts b/arch/arm/dts/bcm2838-rpi-4-b.dts
index 07e9a78e8d..168179c17c 100644
--- a/arch/arm/dts/bcm2838-rpi-4-b.dts
+++ b/arch/arm/dts/bcm2838-rpi-4-b.dts
@@ -30,21 +30,17 @@
status = "okay";
 };
 
-/* SDHCI is used to control the SDIO for wireless */
  {
-   pinctrl-names = "default";
-   pinctrl-0 = <_gpio34>;
-   status = "okay";
-   bus-width = <4>;
-   non-removable;
+   status = "disabled";
 };
 
-/* SDHOST is used to drive the SD card */
  {
-   pinctrl-names = "default";
-   pinctrl-0 = <_gpio48>;
+   status = "disabled";
+};
+
+ {
+   compatible = "brcm,bcm2835-sdhci";
status = "okay";
-   bus-width = <4>;
 };
 
  {
-- 
2.22.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot