Re: [U-Boot] [PATCH 13/22] ppc: dts: Add device tree for xilix-ppc4xx-generic

[Bin Meng]

Hi Ricardo,

On Tue, Jan 26, 2016 at 6:24 PM, Ricardo Ribalda Delgado
 wrote:
> Add device tree example file for xilinx-ppc440-generic and
> xilinx-ppc405-generic
>
> Signed-off-by: Ricardo Ribalda Delgado 
> ---
>  arch/powerpc/dts/Makefile  |  2 ++
>  arch/powerpc/dts/xilinx-ppc405-generic.dts | 13 +
>  arch/powerpc/dts/xilinx-ppc440-generic.dts | 13 +
>  3 files changed, 28 insertions(+)
>  create mode 100644 arch/powerpc/dts/xilinx-ppc405-generic.dts
>  create mode 100644 arch/powerpc/dts/xilinx-ppc440-generic.dts
>
> diff --git a/arch/powerpc/dts/Makefile b/arch/powerpc/dts/Makefile
> index 5d9f5c2822b2..80b4c0c4e374 100644
> --- a/arch/powerpc/dts/Makefile
> +++ b/arch/powerpc/dts/Makefile
> @@ -3,6 +3,8 @@
>  #
>
>  dtb-$(CONFIG_TARGET_CANYONLANDS) += arches.dtb canyonlands.dtb glacier.dtb
> +dtb-$(CONFIG_TARGET_XILINX_PPC440_GENERIC) += xilinx-ppc440-generic.dtb
> +dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb
>
>  targets += $(dtb-y)
>
> diff --git a/arch/powerpc/dts/xilinx-ppc405-generic.dts 
> b/arch/powerpc/dts/xilinx-ppc405-generic.dts
> new file mode 100644
> index ..23c89335831e
> --- /dev/null
> +++ b/arch/powerpc/dts/xilinx-ppc405-generic.dts
> @@ -0,0 +1,13 @@
> +/dts-v1/;

nits: should have a blank line here

> +/ {
> +   #address-cells = <1>;
> +   #size-cells = <1>;

nits: ditto

> +   aliases {
> +   console = 
> +   } ;

nits: ditto

> +   uart0: serial@8400 {
> +   compatible = "xlnx,xps-uartlite-1.00.a";
> +   interrupts = <0 0>;
> +   reg = <0x8400 0x1>;
> +   };
> +} ;
> diff --git a/arch/powerpc/dts/xilinx-ppc440-generic.dts 
> b/arch/powerpc/dts/xilinx-ppc440-generic.dts
> new file mode 100644
> index ..faae9fffcd0e
> --- /dev/null
> +++ b/arch/powerpc/dts/xilinx-ppc440-generic.dts
> @@ -0,0 +1,13 @@
> +/dts-v1/;
> +/ {
> +   #address-cells = <1>;
> +   #size-cells = <1>;
> +   aliases {
> +   console = 
> +   } ;
> +   uart0: serial@8b00 {
> +   compatible = "xlnx,xps-uartlite-1.00.a";
> +   interrupts = <0 0>;
> +   reg = <0x8b00 0x1>;
> +   };
> +} ;
> --

BTW no /chosen node?

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 13/22] ppc: dts: Add device tree for xilix-ppc4xx-generic

[Stefan Roese]

On 26.01.2016 11:24, Ricardo Ribalda Delgado wrote:

Add device tree example file for xilinx-ppc440-generic and
xilinx-ppc405-generic

Signed-off-by: Ricardo Ribalda Delgado 


Acked-by: Stefan Roese 

Thanks,
Stefan

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 13/22] ppc: dts: Add device tree for xilix-ppc4xx-generic

[Ricardo Ribalda Delgado]

Add device tree example file for xilinx-ppc440-generic and
xilinx-ppc405-generic

Signed-off-by: Ricardo Ribalda Delgado 
---
 arch/powerpc/dts/Makefile  |  2 ++
 arch/powerpc/dts/xilinx-ppc405-generic.dts | 13 +
 arch/powerpc/dts/xilinx-ppc440-generic.dts | 13 +
 3 files changed, 28 insertions(+)
 create mode 100644 arch/powerpc/dts/xilinx-ppc405-generic.dts
 create mode 100644 arch/powerpc/dts/xilinx-ppc440-generic.dts

diff --git a/arch/powerpc/dts/Makefile b/arch/powerpc/dts/Makefile
index 5d9f5c2822b2..80b4c0c4e374 100644
--- a/arch/powerpc/dts/Makefile
+++ b/arch/powerpc/dts/Makefile
@@ -3,6 +3,8 @@
 #
 
 dtb-$(CONFIG_TARGET_CANYONLANDS) += arches.dtb canyonlands.dtb glacier.dtb
+dtb-$(CONFIG_TARGET_XILINX_PPC440_GENERIC) += xilinx-ppc440-generic.dtb
+dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb
 
 targets += $(dtb-y)
 
diff --git a/arch/powerpc/dts/xilinx-ppc405-generic.dts 
b/arch/powerpc/dts/xilinx-ppc405-generic.dts
new file mode 100644
index ..23c89335831e
--- /dev/null
+++ b/arch/powerpc/dts/xilinx-ppc405-generic.dts
@@ -0,0 +1,13 @@
+/dts-v1/;
+/ {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   aliases {
+   console = 
+   } ;
+   uart0: serial@8400 {
+   compatible = "xlnx,xps-uartlite-1.00.a";
+   interrupts = <0 0>;
+   reg = <0x8400 0x1>;
+   };
+} ;
diff --git a/arch/powerpc/dts/xilinx-ppc440-generic.dts 
b/arch/powerpc/dts/xilinx-ppc440-generic.dts
new file mode 100644
index ..faae9fffcd0e
--- /dev/null
+++ b/arch/powerpc/dts/xilinx-ppc440-generic.dts
@@ -0,0 +1,13 @@
+/dts-v1/;
+/ {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   aliases {
+   console = 
+   } ;
+   uart0: serial@8b00 {
+   compatible = "xlnx,xps-uartlite-1.00.a";
+   interrupts = <0 0>;
+   reg = <0x8b00 0x1>;
+   };
+} ;
-- 
2.7.0.rc3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 13/22] ppc: dts: Add device tree for xilix-ppc4xx-generic

[Ricardo Ribalda Delgado]

On Tue, Jan 26, 2016 at 1:21 PM, Bin Meng  wrote:
> Hi Ricardo,
>
> On Tue, Jan 26, 2016 at 6:24 PM, Ricardo Ribalda Delgado
>  wrote:
>> Add device tree example file for xilinx-ppc440-generic and
>> xilinx-ppc405-generic
>>
>> Signed-off-by: Ricardo Ribalda Delgado 
>> ---
>>  arch/powerpc/dts/Makefile  |  2 ++
>>  arch/powerpc/dts/xilinx-ppc405-generic.dts | 13 +
>>  arch/powerpc/dts/xilinx-ppc440-generic.dts | 13 +
>>  3 files changed, 28 insertions(+)
>>  create mode 100644 arch/powerpc/dts/xilinx-ppc405-generic.dts
>>  create mode 100644 arch/powerpc/dts/xilinx-ppc440-generic.dts
>>
>> diff --git a/arch/powerpc/dts/Makefile b/arch/powerpc/dts/Makefile
>> index 5d9f5c2822b2..80b4c0c4e374 100644
>> --- a/arch/powerpc/dts/Makefile
>> +++ b/arch/powerpc/dts/Makefile
>> @@ -3,6 +3,8 @@
>>  #
>>
>>  dtb-$(CONFIG_TARGET_CANYONLANDS) += arches.dtb canyonlands.dtb glacier.dtb
>> +dtb-$(CONFIG_TARGET_XILINX_PPC440_GENERIC) += xilinx-ppc440-generic.dtb
>> +dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb
>>
>>  targets += $(dtb-y)
>>
>> diff --git a/arch/powerpc/dts/xilinx-ppc405-generic.dts 
>> b/arch/powerpc/dts/xilinx-ppc405-generic.dts
>> new file mode 100644
>> index ..23c89335831e
>> --- /dev/null
>> +++ b/arch/powerpc/dts/xilinx-ppc405-generic.dts
>> @@ -0,0 +1,13 @@
>> +/dts-v1/;
>
> nits: should have a blank line here
>
>> +/ {
>> +   #address-cells = <1>;
>> +   #size-cells = <1>;
>
> nits: ditto
>
>> +   aliases {
>> +   console = 
>> +   } ;
>
> nits: ditto
>
>> +   uart0: serial@8400 {
>> +   compatible = "xlnx,xps-uartlite-1.00.a";
>> +   interrupts = <0 0>;
>> +   reg = <0x8400 0x1>;
>> +   };
>> +} ;
>> diff --git a/arch/powerpc/dts/xilinx-ppc440-generic.dts 
>> b/arch/powerpc/dts/xilinx-ppc440-generic.dts
>> new file mode 100644
>> index ..faae9fffcd0e
>> --- /dev/null
>> +++ b/arch/powerpc/dts/xilinx-ppc440-generic.dts
>> @@ -0,0 +1,13 @@
>> +/dts-v1/;
>> +/ {
>> +   #address-cells = <1>;
>> +   #size-cells = <1>;
>> +   aliases {
>> +   console = 
>> +   } ;
>> +   uart0: serial@8b00 {
>> +   compatible = "xlnx,xps-uartlite-1.00.a";
>> +   interrupts = <0 0>;
>> +   reg = <0x8b00 0x1>;
>> +   };
>> +} ;
>> --
>
> BTW no /chosen node?

Apparently it is not needed

>
> Regards,
> Bin



-- 
Ricardo Ribalda
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot