Re: [U-Boot] [PATCH 18/22] ppc: xilinx_ppc440_generic: Remove weak attributes

2016-01-26 Thread Bin Meng 
On Tue, Jan 26, 2016 at 6:24 PM, Ricardo Ribalda Delgado
 wrote:
> Now that the specific boards have been removed there is no need to
> maintain the weak functions.
>
> Fix also CamelCase to make checkpatch happy
>
> Signed-off-by: Ricardo Ribalda Delgado 
> ---
>  board/xilinx/ppc440-generic/xilinx_ppc440_generic.c | 18 +++---
>  1 file changed, 7 insertions(+), 11 deletions(-)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 18/22] ppc: xilinx_ppc440_generic: Remove weak attributes

2016-01-26 Thread Ricardo Ribalda Delgado 
Now that the specific boards have been removed there is no need to
maintain the weak functions.

Fix also CamelCase to make checkpatch happy

Signed-off-by: Ricardo Ribalda Delgado 
---
 board/xilinx/ppc440-generic/xilinx_ppc440_generic.c | 18 +++---
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/board/xilinx/ppc440-generic/xilinx_ppc440_generic.c 
b/board/xilinx/ppc440-generic/xilinx_ppc440_generic.c
index f92a3033e14d..52c63f20583e 100644
--- a/board/xilinx/ppc440-generic/xilinx_ppc440_generic.c
+++ b/board/xilinx/ppc440-generic/xilinx_ppc440_generic.c
@@ -10,35 +10,31 @@
 #include 
 #include 
 
-int __board_pre_init(void)
+int board_pre_init(void)
 {
return 0;
 }
-int board_pre_init(void) __attribute__((weak, alias("__board_pre_init")));
 
-int __checkboard(void)
+int checkboard(void)
 {
puts("Xilinx PPC440 Generic Board\n");
return 0;
 }
-int checkboard(void) __attribute__((weak, alias("__checkboard")));
 
-phys_size_t __initdram(int board_type)
+phys_size_t initdram(int board_type)
 {
return get_ram_size(XPAR_DDR2_SDRAM_MEM_BASEADDR,
CONFIG_SYS_SDRAM_SIZE_MB * 1024 * 1024);
 }
-phys_size_t initdram(int) __attribute__((weak, alias("__initdram")));
 
-void __get_sys_info(sys_info_t *sysInfo)
+void get_sys_info(sys_info_t *sys_info)
 {
-   sysInfo->freqProcessor = XPAR_CORE_CLOCK_FREQ_HZ;
-   sysInfo->freqPLB = XPAR_PLB_CLOCK_FREQ_HZ;
-   sysInfo->freqPCI = 0;
+   sys_info->freqProcessor = XPAR_CORE_CLOCK_FREQ_HZ;
+   sys_info->freqPLB = XPAR_PLB_CLOCK_FREQ_HZ;
+   sys_info->freqPCI = 0;
 
return;
 }
-void get_sys_info(sys_info_t *) __attribute__((weak, alias("__get_sys_info")));
 
 int get_serial_clock(void){
return XPAR_UARTNS550_0_CLOCK_FREQ_HZ;
-- 
2.7.0.rc3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 18/22] ppc: xilinx_ppc440_generic: Remove weak attributes

2016-01-26 Thread Tom Rini 
On Tue, Jan 26, 2016 at 11:24:21AM +0100, Ricardo Ribalda Delgado wrote:

> Now that the specific boards have been removed there is no need to
> maintain the weak functions.
> 
> Fix also CamelCase to make checkpatch happy
> 
> Signed-off-by: Ricardo Ribalda Delgado 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 18/22] ppc: xilinx_ppc440_generic: Remove weak attributes

2016-01-26 Thread Stefan Roese 

On 26.01.2016 11:24, Ricardo Ribalda Delgado wrote:

Now that the specific boards have been removed there is no need to
maintain the weak functions.

Fix also CamelCase to make checkpatch happy

Signed-off-by: Ricardo Ribalda Delgado 


Acked-by: Stefan Roese 

Thanks,
Stefan

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot