Re: [U-Boot] [PATCH 2/2] ARM: sunxi: Enable DM MMC+SATA for the PcDuino3 Nano board

2017-12-21 Thread Maxime Ripard 
On Wed, Dec 20, 2017 at 03:37:13PM +0200, Tuomas Tynkkynen wrote:
> On Wed, 2017-12-20 at 13:26 +0100, Maxime Ripard wrote:
> > On Mon, Dec 18, 2017 at 10:09:42PM +0200, Tuomas Tynkkynen wrote:
> > > After the previous commit which adds support for the cd-inverted
> > > property to the sunxi MMC driver, driver-model MMC works fine on
> > > this
> > > board.
> > > 
> > > Signed-off-by: Tuomas Tynkkynen 
> > > ---
> > >  configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig
> > > b/configs/Linksprite_pcDuino3_Nano_defconfig
> > > index 13538fafd1..44ce8b3ead 100644
> > > --- a/configs/Linksprite_pcDuino3_Nano_defconfig
> > > +++ b/configs/Linksprite_pcDuino3_Nano_defconfig
> > > @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y
> > >  # CONFIG_SPL_ISO_PARTITION is not set
> > >  # CONFIG_SPL_EFI_PARTITION is not set
> > >  CONFIG_SCSI_AHCI=y
> > > +CONFIG_DM_MMC=y
> > >  CONFIG_ETH_DESIGNWARE=y
> > >  CONFIG_RGMII=y
> > >  CONFIG_SUN7I_GMAC=y
> > >  CONFIG_SCSI=y
> > > +CONFIG_DM_SCSI=y
> > 
> > Those should not be in a single defconfig, but enabled for all the
> > Allwinner boards (that have SATA and MMC).
> > 
> > Maxime
> > 
> 
> Makes sense. I don't have any other boards to test with so I just
> imitated Simon's change for the non-Nano pcduino3.
> 
> I will try to see if this could be imply'd in Kconfig.

You can also use a default y if ARCH_SUNXI. That's actually a better
option, since imply still have a few glitches that generate an error
when the situation is valid.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] ARM: sunxi: Enable DM MMC+SATA for the PcDuino3 Nano board

2017-12-20 Thread Tuomas Tynkkynen 
On Wed, 2017-12-20 at 13:26 +0100, Maxime Ripard wrote:
> On Mon, Dec 18, 2017 at 10:09:42PM +0200, Tuomas Tynkkynen wrote:
> > After the previous commit which adds support for the cd-inverted
> > property to the sunxi MMC driver, driver-model MMC works fine on
> > this
> > board.
> > 
> > Signed-off-by: Tuomas Tynkkynen 
> > ---
> >  configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig
> > b/configs/Linksprite_pcDuino3_Nano_defconfig
> > index 13538fafd1..44ce8b3ead 100644
> > --- a/configs/Linksprite_pcDuino3_Nano_defconfig
> > +++ b/configs/Linksprite_pcDuino3_Nano_defconfig
> > @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y
> >  # CONFIG_SPL_ISO_PARTITION is not set
> >  # CONFIG_SPL_EFI_PARTITION is not set
> >  CONFIG_SCSI_AHCI=y
> > +CONFIG_DM_MMC=y
> >  CONFIG_ETH_DESIGNWARE=y
> >  CONFIG_RGMII=y
> >  CONFIG_SUN7I_GMAC=y
> >  CONFIG_SCSI=y
> > +CONFIG_DM_SCSI=y
> 
> Those should not be in a single defconfig, but enabled for all the
> Allwinner boards (that have SATA and MMC).
> 
> Maxime
> 

Makes sense. I don't have any other boards to test with so I just
imitated Simon's change for the non-Nano pcduino3.

I will try to see if this could be imply'd in Kconfig.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] ARM: sunxi: Enable DM MMC+SATA for the PcDuino3 Nano board

2017-12-20 Thread Maxime Ripard 
On Mon, Dec 18, 2017 at 10:09:42PM +0200, Tuomas Tynkkynen wrote:
> After the previous commit which adds support for the cd-inverted
> property to the sunxi MMC driver, driver-model MMC works fine on this
> board.
> 
> Signed-off-by: Tuomas Tynkkynen 
> ---
>  configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig 
> b/configs/Linksprite_pcDuino3_Nano_defconfig
> index 13538fafd1..44ce8b3ead 100644
> --- a/configs/Linksprite_pcDuino3_Nano_defconfig
> +++ b/configs/Linksprite_pcDuino3_Nano_defconfig
> @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y
>  # CONFIG_SPL_ISO_PARTITION is not set
>  # CONFIG_SPL_EFI_PARTITION is not set
>  CONFIG_SCSI_AHCI=y
> +CONFIG_DM_MMC=y
>  CONFIG_ETH_DESIGNWARE=y
>  CONFIG_RGMII=y
>  CONFIG_SUN7I_GMAC=y
>  CONFIG_SCSI=y
> +CONFIG_DM_SCSI=y

Those should not be in a single defconfig, but enabled for all the
Allwinner boards (that have SATA and MMC).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/2] ARM: sunxi: Enable DM MMC+SATA for the PcDuino3 Nano board

2017-12-18 Thread Tuomas Tynkkynen 
After the previous commit which adds support for the cd-inverted
property to the sunxi MMC driver, driver-model MMC works fine on this
board.

Signed-off-by: Tuomas Tynkkynen 
---
 configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig 
b/configs/Linksprite_pcDuino3_Nano_defconfig
index 13538fafd1..44ce8b3ead 100644
--- a/configs/Linksprite_pcDuino3_Nano_defconfig
+++ b/configs/Linksprite_pcDuino3_Nano_defconfig
@@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y
 # CONFIG_SPL_ISO_PARTITION is not set
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SCSI_AHCI=y
+CONFIG_DM_MMC=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_RGMII=y
 CONFIG_SUN7I_GMAC=y
 CONFIG_SCSI=y
+CONFIG_DM_SCSI=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-- 
2.15.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot