Re: [U-Boot] [PATCH 2/2] Remove config_distro_defaults.h

[Tom Rini]

On Fri, Feb 02, 2018 at 02:37:11PM -0600, Adam Ford wrote:

> With the contents of config_distro_defaults.h migrated to Kconfig,
> we can remove this header file completely
> 
> Signed-off-by: Adam Ford 
> ---
>  include/config_distro_defaults.h| 16 

So, I have a problem.  In 1/2, and sadly, oops!, in other cases, we've
not been good about enforcing config_distro_defaults.h -> select X under
DISTRO_DEFAULTS entry in the top-level Kconfig.  Can you please re-do
1/2 so that it adds a select line during migration?  I think in general
there's likely been no functional loss (as I'd have noticed size
differences) but there is an ease of use loss (DISTRO_DEFAULTS should
get X/Y/Z for a new board).  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/2] Remove config_distro_defaults.h

[Adam Ford]

With the contents of config_distro_defaults.h migrated to Kconfig,
we can remove this header file completely

Signed-off-by: Adam Ford 
---
 include/config_distro_defaults.h| 16 
 include/configs/am335x_sl50.h   |  2 +-
 include/configs/clearfog.h  |  2 +-
 include/configs/cm_fx6.h|  2 +-
 include/configs/dh_imx6.h   |  2 +-
 include/configs/dragonboard410c.h   |  2 +-
 include/configs/dragonboard820c.h   |  2 +-
 include/configs/el6x_common.h   |  2 +-
 include/configs/embestmx6boards.h   |  2 +-
 include/configs/exynos-common.h |  2 +-
 include/configs/highbank.h  |  2 +-
 include/configs/hikey.h |  2 +-
 include/configs/imx6_logic.h|  2 +-
 include/configs/kc1.h   |  2 +-
 include/configs/ls1012a_common.h|  2 +-
 include/configs/ls1021atwr.h|  2 +-
 include/configs/ls1043a_common.h|  2 +-
 include/configs/ls1046a_common.h|  2 +-
 include/configs/ls1088aqds.h|  2 +-
 include/configs/ls1088ardb.h|  2 +-
 include/configs/ls2080ardb.h|  2 +-
 include/configs/mccmon6.h   |  2 +-
 include/configs/meson-gxbb-common.h |  2 +-
 include/configs/mvebu_armada-37xx.h |  2 +-
 include/configs/mx6cuboxi.h |  2 +-
 include/configs/novena.h|  2 +-
 include/configs/omap3_evm.h |  2 +-
 include/configs/pcm058.h|  2 +-
 include/configs/pfla02.h|  2 +-
 include/configs/poplar.h|  2 +-
 include/configs/qemu-arm.h  |  2 +-
 include/configs/rockchip-common.h   |  2 +-
 include/configs/rpi.h   |  2 +-
 include/configs/s32v234evb.h|  2 +-
 include/configs/sandbox.h   |  2 +-
 include/configs/sksimx6.h   |  2 +-
 include/configs/sniper.h|  2 +-
 include/configs/socfpga_common.h|  2 +-
 include/configs/stih410-b2260.h |  2 +-
 include/configs/sunxi-common.h  |  2 +-
 include/configs/tegra-common.h  |  2 +-
 include/configs/ti_armv7_common.h   |  2 +-
 include/configs/turris_omnia.h  |  2 +-
 include/configs/udoo_neo.h  |  2 +-
 include/configs/usbarmory.h |  2 +-
 include/configs/vexpress_common.h   |  2 +-
 include/configs/wandboard.h |  2 +-
 include/configs/zynq-common.h   |  2 +-
 48 files changed, 47 insertions(+), 63 deletions(-)

diff --git a/include/config_distro_defaults.h b/include/config_distro_defaults.h
deleted file mode 100644
index 35e704e..000
--- a/include/config_distro_defaults.h
+++ /dev/null
@@ -1,16 +0,0 @@
-/*
- * Copyright 2013-2014 Red Hat, Inc.
- *
- * SPDX-License-Identifier: GPL-2.0+
- */
-
-#ifndef _CONFIG_CMD_DISTRO_DEFAULTS_H
-#define _CONFIG_CMD_DISTRO_DEFAULTS_H
-
-/*
- * List of all commands and options that when defined enables support for
- * features required by distros to support boards in a standardised and
- * consistent manner.
- */
-
-#endif /* _CONFIG_CMD_DISTRO_DEFAULTS_H */
diff --git a/include/configs/am335x_sl50.h b/include/configs/am335x_sl50.h
index b1c7ede..24406c1 100644
--- a/include/configs/am335x_sl50.h
+++ b/include/configs/am335x_sl50.h
@@ -30,7 +30,7 @@
 
 #ifndef CONFIG_SPL_BUILD
 
-#include 
+
 
 #define MEM_LAYOUT_ENV_SETTINGS \
"scriptaddr=0x8000\0" \
diff --git a/include/configs/clearfog.h b/include/configs/clearfog.h
index c2d7548..30168e2 100644
--- a/include/configs/clearfog.h
+++ b/include/configs/clearfog.h
@@ -125,7 +125,7 @@
 
 /* Include the common distro boot environment */
 #ifndef CONFIG_SPL_BUILD
-#include 
+
 
 #ifdef CONFIG_MMC
 #define BOOT_TARGET_DEVICES_MMC(func) func(MMC, mmc, 0)
diff --git a/include/configs/cm_fx6.h b/include/configs/cm_fx6.h
index fb710ec..06eae06 100644
--- a/include/configs/cm_fx6.h
+++ b/include/configs/cm_fx6.h
@@ -14,7 +14,7 @@
 #include "mx6_common.h"
 
 #ifndef CONFIG_SPL_BUILD
-#include 
+
 #endif
 
 /* Machine config */
diff --git a/include/configs/dh_imx6.h b/include/configs/dh_imx6.h
index 9aa3b23..ca095e4 100644
--- a/include/configs/dh_imx6.h
+++ b/include/configs/dh_imx6.h
@@ -11,7 +11,7 @@
 
 #include 
 
-#include 
+
 #include "mx6_common.h"
 
 /*
diff --git a/include/configs/dragonboard410c.h 
b/include/configs/dragonboard410c.h
index 6b5a295..0cabe42 100644
--- a/include/configs/dragonboard410c.h
+++ b/include/configs/dragonboard410c.h
@@ -46,7 +46,7 @@
 /* Partition table support */
 #define HAVE_BLOCK_DEVICE /* Needed for partition commands */
 
-#include 
+
 
 /* BOOTP options */
 #define CONFIG_BOOTP_BOOTFILESIZE
diff --git a/include/configs/dragonboard820c.h 
b/include/configs/dragonboard820c.h
index 4bc36b7..f3929ae 100644
--- a/include/configs/dragonboard820c.h
+++ b/include/configs/dragonboard820c.h
@@ -40,7 +40,7 @@
 #define CONFIG_BOOTP_BOOTFILESIZE
 
 #ifndef CONFIG_SPL_BUILD
-#include 
+
 #include 
 #endif
 
diff --git a/include/configs/el6x_common.h b/include/configs/el6x_common.h
index 17690e1..603dd07 100644
--- a/include/configs/el6x_common.h
+++