Re: [U-Boot] [PATCH 2/3] arm: dts: Add mac node for rk3308 at dtsi level

2019-12-02 Thread David Wu 

Hi Kever,

在 2019/11/27 下午2:23, Kever Yang 写道:

David,


On 2019/11/26 上午9:39, David Wu wrote:

The rk3308 only support RMII mode, and if it is output clock
mode, better to use ref_clk pin with drive strength 12ma.

Signed-off-by: David Wu 


Did you send this to kernel list at the same time?


I will send it later.




Thanks,

- Kever


---
  arch/arm/dts/rk3308.dtsi | 22 ++
  1 file changed, 22 insertions(+)

diff --git a/arch/arm/dts/rk3308.dtsi b/arch/arm/dts/rk3308.dtsi
index 0eeec165d4..a5c0b72ae0 100644
--- a/arch/arm/dts/rk3308.dtsi
+++ b/arch/arm/dts/rk3308.dtsi
@@ -627,6 +627,28 @@
  status = "disabled";
  };
+    mac: ethernet@ff4e {
+    compatible = "rockchip,rk3308-mac";
+    reg = <0x0 0xff4e 0x0 0x1>;
+    rockchip,grf = <>;
+    interrupts = ;
+    interrupt-names = "macirq";
+    clocks = < SCLK_MAC>, < SCLK_MAC_RX_TX>,
+ < SCLK_MAC_RX_TX>, < SCLK_MAC_REF>,
+ < SCLK_MAC>, < ACLK_MAC>,
+ < PCLK_MAC>, < SCLK_MAC_RMII>;
+    clock-names = "stmmaceth", "mac_clk_rx",
+  "mac_clk_tx", "clk_mac_ref",
+  "clk_mac_refout", "aclk_mac",
+  "pclk_mac", "clk_mac_speed";
+    phy-mode = "rmii";
+    pinctrl-names = "default";
+    pinctrl-0 = <_pins _refclk_12ma>;
+    resets = < SRST_MAC_A>;
+    reset-names = "stmmaceth";
+    status = "disabled";
+    };
+
  cru: clock-controller@ff50 {
  compatible = "rockchip,rk3308-cru";
  reg = <0x0 0xff50 0x0 0x1000>;








___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] arm: dts: Add mac node for rk3308 at dtsi level

2019-11-26 Thread Kever Yang 

David,


On 2019/11/26 上午9:39, David Wu wrote:

The rk3308 only support RMII mode, and if it is output clock
mode, better to use ref_clk pin with drive strength 12ma.

Signed-off-by: David Wu 


Did you send this to kernel list at the same time?


Thanks,

- Kever


---
  arch/arm/dts/rk3308.dtsi | 22 ++
  1 file changed, 22 insertions(+)

diff --git a/arch/arm/dts/rk3308.dtsi b/arch/arm/dts/rk3308.dtsi
index 0eeec165d4..a5c0b72ae0 100644
--- a/arch/arm/dts/rk3308.dtsi
+++ b/arch/arm/dts/rk3308.dtsi
@@ -627,6 +627,28 @@
status = "disabled";
};
  
+	mac: ethernet@ff4e {

+   compatible = "rockchip,rk3308-mac";
+   reg = <0x0 0xff4e 0x0 0x1>;
+   rockchip,grf = <>;
+   interrupts = ;
+   interrupt-names = "macirq";
+   clocks = < SCLK_MAC>, < SCLK_MAC_RX_TX>,
+< SCLK_MAC_RX_TX>, < SCLK_MAC_REF>,
+< SCLK_MAC>, < ACLK_MAC>,
+< PCLK_MAC>, < SCLK_MAC_RMII>;
+   clock-names = "stmmaceth", "mac_clk_rx",
+ "mac_clk_tx", "clk_mac_ref",
+ "clk_mac_refout", "aclk_mac",
+ "pclk_mac", "clk_mac_speed";
+   phy-mode = "rmii";
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins _refclk_12ma>;
+   resets = < SRST_MAC_A>;
+   reset-names = "stmmaceth";
+   status = "disabled";
+   };
+
cru: clock-controller@ff50 {
compatible = "rockchip,rk3308-cru";
reg = <0x0 0xff50 0x0 0x1000>;



___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/3] arm: dts: Add mac node for rk3308 at dtsi level

2019-11-25 Thread David Wu 
The rk3308 only support RMII mode, and if it is output clock
mode, better to use ref_clk pin with drive strength 12ma.

Signed-off-by: David Wu 
---
 arch/arm/dts/rk3308.dtsi | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm/dts/rk3308.dtsi b/arch/arm/dts/rk3308.dtsi
index 0eeec165d4..a5c0b72ae0 100644
--- a/arch/arm/dts/rk3308.dtsi
+++ b/arch/arm/dts/rk3308.dtsi
@@ -627,6 +627,28 @@
status = "disabled";
};
 
+   mac: ethernet@ff4e {
+   compatible = "rockchip,rk3308-mac";
+   reg = <0x0 0xff4e 0x0 0x1>;
+   rockchip,grf = <>;
+   interrupts = ;
+   interrupt-names = "macirq";
+   clocks = < SCLK_MAC>, < SCLK_MAC_RX_TX>,
+< SCLK_MAC_RX_TX>, < SCLK_MAC_REF>,
+< SCLK_MAC>, < ACLK_MAC>,
+< PCLK_MAC>, < SCLK_MAC_RMII>;
+   clock-names = "stmmaceth", "mac_clk_rx",
+ "mac_clk_tx", "clk_mac_ref",
+ "clk_mac_refout", "aclk_mac",
+ "pclk_mac", "clk_mac_speed";
+   phy-mode = "rmii";
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins _refclk_12ma>;
+   resets = < SRST_MAC_A>;
+   reset-names = "stmmaceth";
+   status = "disabled";
+   };
+
cru: clock-controller@ff50 {
compatible = "rockchip,rk3308-cru";
reg = <0x0 0xff50 0x0 0x1000>;
-- 
2.19.1



___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot