Re: [U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node
Hi Fabio, Patrick, On 04/10/19 17:52, Fabio Estevam wrote: > Hi Patrick, > > On Fri, Oct 4, 2019 at 12:50 PM Patrick Wildt wrote: > >> yes, that's true. It does make sense to sync the device trees and >> do the name change. Can the diff with the reset controller driver >> (patch 1/3) be merged anyway, and I'll follow up with the DTS change? >> Would be easier for me to handle the number of patches to submit. > > I think so. > > Stefano is the one who will apply your patch if he is happy with it. > I agree with you, too. I merge patches into -next. Regards, Stefano Babic > Regards, > > Fabio Estevam > -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node
Hi Patrick, On Fri, Oct 4, 2019 at 12:50 PM Patrick Wildt wrote: > yes, that's true. It does make sense to sync the device trees and > do the name change. Can the diff with the reset controller driver > (patch 1/3) be merged anyway, and I'll follow up with the DTS change? > Would be easier for me to handle the number of patches to submit. I think so. Stefano is the one who will apply your patch if he is happy with it. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node
On Fri, Oct 04, 2019 at 09:39:29AM -0300, Fabio Estevam wrote:
> Hi Patrick,
>
> On Thu, Oct 3, 2019 at 11:12 AM Patrick Wildt wrote:
> >
> > This patch adds the reset controller node to the i.MX8MQ SoC
> > device tree.
> >
> > Signed-off-by: Patrick Wildt
> > ---
> > arch/arm/dts/fsl-imx8mq.dtsi | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/dts/fsl-imx8mq.dtsi b/arch/arm/dts/fsl-imx8mq.dtsi
> > index c35c23e293..d843b401be 100644
> > --- a/arch/arm/dts/fsl-imx8mq.dtsi
> > +++ b/arch/arm/dts/fsl-imx8mq.dtsi
> > @@ -19,6 +19,7 @@
> > #include
> > #include
> > #include
> > +#include
> > #include
> >
> > / {
> > @@ -269,6 +270,12 @@
> > #clock-cells = <1>;
> > };
> >
> > + src: reset-controller@3039 {
> > + compatible = "fsl,imx8mq-src", "syscon";
> > + reg = <0x0 0x3039 0x0 0x1>;
> > + #reset-cells = <1>;
>
> This reset-controller node is already part of the upstream kernel imx8mq.dtsi.
>
> What about syncing the U-Boot version with the one from kernel 5.3.2?
> Also, please note the dtsi name change.
>
> Thanks
Hi Fabio,
yes, that's true. It does make sense to sync the device trees and
do the name change. Can the diff with the reset controller driver
(patch 1/3) be merged anyway, and I'll follow up with the DTS change?
Would be easier for me to handle the number of patches to submit.
Thank you for the review!
Best regards,
Patrick
>
> > + };
> > +
> > gpc: gpc@303a {
> > compatible = "fsl,imx8mq-gpc", "fsl,imx7d-gpc", "syscon";
> > reg = <0x0 0x303a 0x0 0x1>;
> > --
> > 2.23.0
> >
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node
Hi Patrick,
On Thu, Oct 3, 2019 at 11:12 AM Patrick Wildt wrote:
>
> This patch adds the reset controller node to the i.MX8MQ SoC
> device tree.
>
> Signed-off-by: Patrick Wildt
> ---
> arch/arm/dts/fsl-imx8mq.dtsi | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/fsl-imx8mq.dtsi b/arch/arm/dts/fsl-imx8mq.dtsi
> index c35c23e293..d843b401be 100644
> --- a/arch/arm/dts/fsl-imx8mq.dtsi
> +++ b/arch/arm/dts/fsl-imx8mq.dtsi
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
> #include
>
> / {
> @@ -269,6 +270,12 @@
> #clock-cells = <1>;
> };
>
> + src: reset-controller@3039 {
> + compatible = "fsl,imx8mq-src", "syscon";
> + reg = <0x0 0x3039 0x0 0x1>;
> + #reset-cells = <1>;
This reset-controller node is already part of the upstream kernel imx8mq.dtsi.
What about syncing the U-Boot version with the one from kernel 5.3.2?
Also, please note the dtsi name change.
Thanks
> + };
> +
> gpc: gpc@303a {
> compatible = "fsl,imx8mq-gpc", "fsl,imx7d-gpc", "syscon";
> reg = <0x0 0x303a 0x0 0x1>;
> --
> 2.23.0
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node
This patch adds the reset controller node to the i.MX8MQ SoC
device tree.
Signed-off-by: Patrick Wildt
---
arch/arm/dts/fsl-imx8mq.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/dts/fsl-imx8mq.dtsi b/arch/arm/dts/fsl-imx8mq.dtsi
index c35c23e293..d843b401be 100644
--- a/arch/arm/dts/fsl-imx8mq.dtsi
+++ b/arch/arm/dts/fsl-imx8mq.dtsi
@@ -19,6 +19,7 @@
#include
#include
#include
+#include
#include
/ {
@@ -269,6 +270,12 @@
#clock-cells = <1>;
};
+ src: reset-controller@3039 {
+ compatible = "fsl,imx8mq-src", "syscon";
+ reg = <0x0 0x3039 0x0 0x1>;
+ #reset-cells = <1>;
+ };
+
gpc: gpc@303a {
compatible = "fsl,imx8mq-gpc", "fsl,imx7d-gpc", "syscon";
reg = <0x0 0x303a 0x0 0x1>;
--
2.23.0
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
