Re: [U-Boot] [PATCH 2/3] mx28evk: Propagate the error if cpu_eth_init() fails
On 20/09/2013 21:30, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com If cpu_eth_init() fails we should return the error immediately. Cc: Marek Vasut ma...@denx.de Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Applied to u-boot-imx (fix), thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mx28evk: Propagate the error if cpu_eth_init() fails
Dear Fabio Estevam, From: Fabio Estevam fabio.este...@freescale.com If cpu_eth_init() fails we should return the error immediately. Cc: Marek Vasut ma...@denx.de Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Marek Vasut ma...@denx.de --- board/denx/m28evk/m28evk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c index f4453d6..33d38cf 100644 --- a/board/denx/m28evk/m28evk.c +++ b/board/denx/m28evk/m28evk.c @@ -116,6 +116,8 @@ int board_eth_init(bd_t *bis) int ret; ret = cpu_eth_init(bis); + if (ret) + return ret; clrsetbits_le32(clkctrl_regs-hw_clkctrl_enet, CLKCTRL_ENET_TIME_SEL_MASK | CLKCTRL_ENET_CLK_OUT_EN, Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] mx28evk: Propagate the error if cpu_eth_init() fails
From: Fabio Estevam fabio.este...@freescale.com If cpu_eth_init() fails we should return the error immediately. Cc: Marek Vasut ma...@denx.de Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- board/denx/m28evk/m28evk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c index f4453d6..33d38cf 100644 --- a/board/denx/m28evk/m28evk.c +++ b/board/denx/m28evk/m28evk.c @@ -116,6 +116,8 @@ int board_eth_init(bd_t *bis) int ret; ret = cpu_eth_init(bis); + if (ret) + return ret; clrsetbits_le32(clkctrl_regs-hw_clkctrl_enet, CLKCTRL_ENET_TIME_SEL_MASK | CLKCTRL_ENET_CLK_OUT_EN, -- 1.8.1.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
