Re: [U-Boot] [PATCH 2/3] power: pmic: s2mps11: probe the regulator driver

2018-01-23 Thread Jaehoon Chung 
On 01/24/2018 01:02 AM, Anand Moon wrote:
> Hi JaeHoon Chung,
> 
> On 16 January 2018 at 12:03, Jaehoon Chung  wrote:
>> Add the probe function to support the s2mps11 regulator driver.
>>
>> Signed-off-by: Jaehoon Chung 
>> ---
>>  drivers/power/pmic/s2mps11.c | 28 
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/drivers/power/pmic/s2mps11.c b/drivers/power/pmic/s2mps11.c
>> index 522105e5ff..3f9525b67d 100644
>> --- a/drivers/power/pmic/s2mps11.c
>> +++ b/drivers/power/pmic/s2mps11.c
>> @@ -15,6 +15,12 @@
>>
>>  DECLARE_GLOBAL_DATA_PTR;
>>
>> +static const struct pmic_child_info pmic_children_info[] = {
>> +   { .prefix = S2MPS11_OF_LDO_PREFIX, .driver = S2MPS11_LDO_DRIVER },
>> +   { .prefix = S2MPS11_OF_BUCK_PREFIX, .driver = S2MPS11_BUCK_DRIVER },
>> +   { },
>> +};
>> +
>>  static int s2mps11_reg_count(struct udevice *dev)
>>  {
>> return S2MPS11_REG_COUNT;
>> @@ -43,6 +49,27 @@ static int s2mps11_read(struct udevice *dev, uint reg, 
>> uint8_t *buff, int len)
>> return ret;
>>  }
>>
>> +static int s2mps11_probe(struct udevice *dev)
>> +{
>> +   ofnode regulators_node;
>> +   int children;
>> +
>> +   regulators_node = dev_read_subnode(dev, "voltage-regulators");
>> +   if (!ofnode_valid(regulators_node)) {
>> +   debug("%s: %s regulators subnode not found!", __func__,
>> +dev->name);
>> +   return -ENXIO;
>> +   }
>> +
>> +   debug("%s: '%s' - found regulators subnode\n", __func__, dev->name);
>> +
>> +   children = pmic_bind_children(dev, regulators_node, 
>> pmic_children_info);
>> +   if (!children)
>> +   debug("%s: %s - no child found\n", __func__, dev->name);
>> +
>> +   return 0;
>> +}
>> +
>>  static struct dm_pmic_ops s2mps11_ops = {
>> .reg_count = s2mps11_reg_count,
>> .read = s2mps11_read,
>> @@ -59,4 +86,5 @@ U_BOOT_DRIVER(pmic_s2mps11) = {
>> .id = UCLASS_PMIC,
>> .of_match = s2mps11_ids,
>> .ops = _ops,
>> +   .probe = s2mps11_probe,
>>  };
>> --
>> 2.15.1
>>
> 
> Please add my.
> Tested-by: Anand Moon 


Applied to u-boot-mmc.

Best Regards,
Jaehoon Chung

> 
> Best Regards
> -Anand
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] power: pmic: s2mps11: probe the regulator driver

2018-01-23 Thread Anand Moon 
Hi JaeHoon Chung,

On 16 January 2018 at 12:03, Jaehoon Chung  wrote:
> Add the probe function to support the s2mps11 regulator driver.
>
> Signed-off-by: Jaehoon Chung 
> ---
>  drivers/power/pmic/s2mps11.c | 28 
>  1 file changed, 28 insertions(+)
>
> diff --git a/drivers/power/pmic/s2mps11.c b/drivers/power/pmic/s2mps11.c
> index 522105e5ff..3f9525b67d 100644
> --- a/drivers/power/pmic/s2mps11.c
> +++ b/drivers/power/pmic/s2mps11.c
> @@ -15,6 +15,12 @@
>
>  DECLARE_GLOBAL_DATA_PTR;
>
> +static const struct pmic_child_info pmic_children_info[] = {
> +   { .prefix = S2MPS11_OF_LDO_PREFIX, .driver = S2MPS11_LDO_DRIVER },
> +   { .prefix = S2MPS11_OF_BUCK_PREFIX, .driver = S2MPS11_BUCK_DRIVER },
> +   { },
> +};
> +
>  static int s2mps11_reg_count(struct udevice *dev)
>  {
> return S2MPS11_REG_COUNT;
> @@ -43,6 +49,27 @@ static int s2mps11_read(struct udevice *dev, uint reg, 
> uint8_t *buff, int len)
> return ret;
>  }
>
> +static int s2mps11_probe(struct udevice *dev)
> +{
> +   ofnode regulators_node;
> +   int children;
> +
> +   regulators_node = dev_read_subnode(dev, "voltage-regulators");
> +   if (!ofnode_valid(regulators_node)) {
> +   debug("%s: %s regulators subnode not found!", __func__,
> +dev->name);
> +   return -ENXIO;
> +   }
> +
> +   debug("%s: '%s' - found regulators subnode\n", __func__, dev->name);
> +
> +   children = pmic_bind_children(dev, regulators_node, 
> pmic_children_info);
> +   if (!children)
> +   debug("%s: %s - no child found\n", __func__, dev->name);
> +
> +   return 0;
> +}
> +
>  static struct dm_pmic_ops s2mps11_ops = {
> .reg_count = s2mps11_reg_count,
> .read = s2mps11_read,
> @@ -59,4 +86,5 @@ U_BOOT_DRIVER(pmic_s2mps11) = {
> .id = UCLASS_PMIC,
> .of_match = s2mps11_ids,
> .ops = _ops,
> +   .probe = s2mps11_probe,
>  };
> --
> 2.15.1
>

Please add my.
Tested-by: Anand Moon 

Best Regards
-Anand
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] power: pmic: s2mps11: probe the regulator driver

2018-01-17 Thread Simon Glass 
On 15 January 2018 at 22:33, Jaehoon Chung  wrote:
> Add the probe function to support the s2mps11 regulator driver.
>
> Signed-off-by: Jaehoon Chung 
> ---
>  drivers/power/pmic/s2mps11.c | 28 
>  1 file changed, 28 insertions(+)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/3] power: pmic: s2mps11: probe the regulator driver

2018-01-15 Thread Jaehoon Chung 
Add the probe function to support the s2mps11 regulator driver.

Signed-off-by: Jaehoon Chung 
---
 drivers/power/pmic/s2mps11.c | 28 
 1 file changed, 28 insertions(+)

diff --git a/drivers/power/pmic/s2mps11.c b/drivers/power/pmic/s2mps11.c
index 522105e5ff..3f9525b67d 100644
--- a/drivers/power/pmic/s2mps11.c
+++ b/drivers/power/pmic/s2mps11.c
@@ -15,6 +15,12 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+static const struct pmic_child_info pmic_children_info[] = {
+   { .prefix = S2MPS11_OF_LDO_PREFIX, .driver = S2MPS11_LDO_DRIVER },
+   { .prefix = S2MPS11_OF_BUCK_PREFIX, .driver = S2MPS11_BUCK_DRIVER },
+   { },
+};
+
 static int s2mps11_reg_count(struct udevice *dev)
 {
return S2MPS11_REG_COUNT;
@@ -43,6 +49,27 @@ static int s2mps11_read(struct udevice *dev, uint reg, 
uint8_t *buff, int len)
return ret;
 }
 
+static int s2mps11_probe(struct udevice *dev)
+{
+   ofnode regulators_node;
+   int children;
+
+   regulators_node = dev_read_subnode(dev, "voltage-regulators");
+   if (!ofnode_valid(regulators_node)) {
+   debug("%s: %s regulators subnode not found!", __func__,
+dev->name);
+   return -ENXIO;
+   }
+
+   debug("%s: '%s' - found regulators subnode\n", __func__, dev->name);
+
+   children = pmic_bind_children(dev, regulators_node, pmic_children_info);
+   if (!children)
+   debug("%s: %s - no child found\n", __func__, dev->name);
+
+   return 0;
+}
+
 static struct dm_pmic_ops s2mps11_ops = {
.reg_count = s2mps11_reg_count,
.read = s2mps11_read,
@@ -59,4 +86,5 @@ U_BOOT_DRIVER(pmic_s2mps11) = {
.id = UCLASS_PMIC,
.of_match = s2mps11_ids,
.ops = _ops,
+   .probe = s2mps11_probe,
 };
-- 
2.15.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot