Re: [U-Boot] [PATCH 2/4] arm: relocate_code(): do not set register useless

2010-12-09 Thread Albert ARIBAUD 
Le 01/12/2010 00:58, Andreas Bießmann a écrit :
 In case we are still at relocation target address before relocation we
 do not need to load the registers needed for relocation. We should
 instead skip the whole relocation part and jump over to clear_bss
 immediately.

 Signed-off-by: Andreas Bießmannandreas.de...@googlemail.com

Acked-by: Albert ARIBAUD albert.arib...@free.fr

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/4] arm: relocate_code(): do not set register useless

2010-12-09 Thread Albert ARIBAUD 
Le 01/12/2010 00:58, Andreas Bießmann a écrit :
 In case we are still at relocation target address before relocation we
 do not need to load the registers needed for relocation. We should
 instead skip the whole relocation part and jump over to clear_bss
 immediately.

 Signed-off-by: Andreas Bießmannandreas.de...@googlemail.com

Acked-by: Albert ARIBAUD albert.arib...@free.fr

(note: other patches in the series have a typo in my e-mail address -- 
missing dot between my name and surname. In my case, lack not of beer 
but of coffee.)

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/4] arm: relocate_code(): do not set register useless

2010-12-08 Thread Wolfgang Denk 
Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message 1291161516-21861-3-git-send-email-andreas.de...@googlemail.com you 
wrote:
 In case we are still at relocation target address before relocation we
 do not need to load the registers needed for relocation. We should
 instead skip the whole relocation part and jump over to clear_bss
 immediately.
 
 Signed-off-by: Andreas Bießmann andreas.de...@googlemail.com
 ---
  arch/arm/cpu/arm1136/start.S   |4 ++--
  arch/arm/cpu/arm1176/start.S   |4 ++--
  arch/arm/cpu/arm720t/start.S   |4 ++--
  arch/arm/cpu/arm920t/start.S   |4 ++--
  arch/arm/cpu/arm925t/start.S   |4 ++--
  arch/arm/cpu/arm926ejs/start.S |4 ++--
  arch/arm/cpu/arm946es/start.S  |4 ++--
  arch/arm/cpu/arm_intcm/start.S |4 ++--
  arch/arm/cpu/armv7/start.S |8 
  arch/arm/cpu/ixp/start.S   |4 ++--
  arch/arm/cpu/lh7a40x/start.S   |4 ++--
  arch/arm/cpu/pxa/start.S   |4 ++--
  arch/arm/cpu/s3c44b0/start.S   |4 ++--
  arch/arm/cpu/sa1100/start.S|4 ++--
  14 files changed, 30 insertions(+), 30 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A little knowledge is a dangerous thing.- Doug Gwyn
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/4] arm: relocate_code(): do not set register useless

2010-11-30 Thread Andreas Bießmann 
In case we are still at relocation target address before relocation we
do not need to load the registers needed for relocation. We should
instead skip the whole relocation part and jump over to clear_bss
immediately.

Signed-off-by: Andreas Bießmann andreas.de...@googlemail.com
---
 arch/arm/cpu/arm1136/start.S   |4 ++--
 arch/arm/cpu/arm1176/start.S   |4 ++--
 arch/arm/cpu/arm720t/start.S   |4 ++--
 arch/arm/cpu/arm920t/start.S   |4 ++--
 arch/arm/cpu/arm925t/start.S   |4 ++--
 arch/arm/cpu/arm926ejs/start.S |4 ++--
 arch/arm/cpu/arm946es/start.S  |4 ++--
 arch/arm/cpu/arm_intcm/start.S |4 ++--
 arch/arm/cpu/armv7/start.S |8 
 arch/arm/cpu/ixp/start.S   |4 ++--
 arch/arm/cpu/lh7a40x/start.S   |4 ++--
 arch/arm/cpu/pxa/start.S   |4 ++--
 arch/arm/cpu/s3c44b0/start.S   |4 ++--
 arch/arm/cpu/sa1100/start.S|4 ++--
 14 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 153a881..7ba7245 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -192,12 +192,12 @@ stack_setup:
mov sp, r4
 
adr r0, _start
+   cmp r0, r6
+   beq clear_bss   /* skip relocation */
mov r1, r6  /* r1 - scratch for copy_loop */
ldr r2, _TEXT_BASE
ldr r3, _bss_start_ofs
add r2, r0, r3  /* r2 - source end address */
-   cmp r0, r6
-   beq clear_bss
 
 copy_loop:
ldmia   r0!, {r9-r10}   /* copy from source address [r0]*/
diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S
index 5046765..f9c8671 100644
--- a/arch/arm/cpu/arm1176/start.S
+++ b/arch/arm/cpu/arm1176/start.S
@@ -246,12 +246,12 @@ stack_setup:
mov sp, r4
 
adr r0, _start
+   cmp r0, r6
+   beq clear_bss   /* skip relocation */
mov r1, r6  /* r1 - scratch for copy_loop */
ldr r2, _TEXT_BASE
ldr r3, _bss_start_ofs
add r2, r0, r3  /* r2 - source end address */
-   cmp r0, r6
-   beq clear_bss
 
 copy_loop:
ldmia   r0!, {r9-r10}   /* copy from source address [r0]*/
diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S
index c34ec44..6a6af1b 100644
--- a/arch/arm/cpu/arm720t/start.S
+++ b/arch/arm/cpu/arm720t/start.S
@@ -161,12 +161,12 @@ stack_setup:
mov sp, r4
 
adr r0, _start
+   cmp r0, r6
+   beq clear_bss   /* skip relocation */
mov r1, r6  /* r1 - scratch for copy_loop */
ldr r2, _TEXT_BASE
ldr r3, _bss_start_ofs
add r2, r0, r3  /* r2 - source end address */
-   cmp r0, r6
-   beq clear_bss
 
 copy_loop:
ldmia   r0!, {r9-r10}   /* copy from source address [r0]*/
diff --git a/arch/arm/cpu/arm920t/start.S b/arch/arm/cpu/arm920t/start.S
index cae0e3c..cdf0920 100644
--- a/arch/arm/cpu/arm920t/start.S
+++ b/arch/arm/cpu/arm920t/start.S
@@ -207,12 +207,12 @@ stack_setup:
mov sp, r4
 
adr r0, _start
+   cmp r0, r6
+   beq clear_bss   /* skip relocation */
mov r1, r6  /* r1 - scratch for copy_loop */
ldr r2, _TEXT_BASE
ldr r3, _bss_start_ofs
add r2, r0, r3  /* r2 - source end address */
-   cmp r0, r6
-   beq clear_bss
 
 copy_loop:
ldmia   r0!, {r9-r10}   /* copy from source address [r0]*/
diff --git a/arch/arm/cpu/arm925t/start.S b/arch/arm/cpu/arm925t/start.S
index ebce803..54f2339 100644
--- a/arch/arm/cpu/arm925t/start.S
+++ b/arch/arm/cpu/arm925t/start.S
@@ -198,12 +198,12 @@ stack_setup:
mov sp, r4
 
adr r0, _start
+   cmp r0, r6
+   beq clear_bss   /* skip relocation */
mov r1, r6  /* r1 - scratch for copy_loop */
ldr r2, _TEXT_BASE
ldr r3, _bss_start_ofs
add r2, r0, r3  /* r2 - source end address */
-   cmp r0, r6
-   beq clear_bss
 
 copy_loop:
ldmia   r0!, {r9-r10}   /* copy from source address [r0]*/
diff --git a/arch/arm/cpu/arm926ejs/start.S b/arch/arm/cpu/arm926ejs/start.S
index a099f7d..59db6b5 100644
--- a/arch/arm/cpu/arm926ejs/start.S
+++ b/arch/arm/cpu/arm926ejs/start.S
@@ -197,12 +197,12 @@ stack_setup:
mov sp, r4
 
adr r0, _start
+   cmp r0, r6
+   beq clear_bss   /* skip relocation */
mov r1, r6  /* r1 - scratch for copy loop */
ldr r2, _TEXT_BASE
ldr r3, _bss_start_ofs
add r2, r0, r3