Re: [U-Boot] [PATCH 2/4] common/lcd_console: ask only one-time for bg/fg-color per call

[Nikita Kiryanov]

Hi Hannes,

On 03/11/2015 02:57 PM, Hannes Petermaier wrote:

From: Hannes Petermaier hannes.peterma...@br-automation.com

Don't call the lcd_getfgcolor and lcd_getbgcolor within the draw-loop, this
only wastes time.

Signed-off-by: Hannes Petermaier hannes.peterma...@br-automation.com
Signed-off-by: Hannes Petermaier oe5...@oevsv.at
---

  common/lcd_console.c |7 ++-
  1 file changed, 2 insertions(+), 5 deletions(-)


Acked-by: Nikita Kiryanov nik...@compulab.co.il

--
Regards,
Nikita Kiryanov
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/4] common/lcd_console: ask only one-time for bg/fg-color per call

[Hannes Petermaier]

From: Hannes Petermaier hannes.peterma...@br-automation.com

Don't call the lcd_getfgcolor and lcd_getbgcolor within the draw-loop, this
only wastes time.

Signed-off-by: Hannes Petermaier hannes.peterma...@br-automation.com
Signed-off-by: Hannes Petermaier oe5...@oevsv.at
---

 common/lcd_console.c |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/common/lcd_console.c b/common/lcd_console.c
index 243b7c5..b7dda7a 100644
--- a/common/lcd_console.c
+++ b/common/lcd_console.c
@@ -59,7 +59,8 @@ static void lcd_putc_xy(ushort x, ushort y, char c)
 {
uchar *dest;
ushort row;
-   int fg_color, bg_color;
+   int fg_color = lcd_getfgcolor();
+   int bg_color = lcd_getbgcolor();
int i;
 
dest = (uchar *)(lcd_console_address +
@@ -73,10 +74,6 @@ static void lcd_putc_xy(ushort x, ushort y, char c)
 #else
uchar *d = dest;
 #endif
-
-   fg_color = lcd_getfgcolor();
-   bg_color = lcd_getbgcolor();
-
uchar bits;
bits = video_fontdata[c * VIDEO_FONT_HEIGHT + row];
 
-- 
1.7.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot