Re: [U-Boot] [PATCH 2/6] gpt: command: cosmetic: Replace printf with puts

[Lukasz Majewski]

Hi Tom,

> On Fri, Nov 13, 2015 at 07:42:08AM +0100, Lukasz Majewski wrote:
> 
> > This code is not processing any data to serial console output and
> > hence can be replaced with puts.
> > 
> > Signed-off-by: Lukasz Majewski 
> 
> No, printf is fine, always.  We went over this before and it's not a
> win to change things.

Ok, I see. Then I will drop this patch.

> 

Best regards,
Lukasz Majewski


pgpcUS6C3AqzV.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/6] gpt: command: cosmetic: Replace printf with puts

[Tom Rini]

On Fri, Nov 13, 2015 at 07:42:08AM +0100, Lukasz Majewski wrote:

> This code is not processing any data to serial console output and hence
> can be replaced with puts.
> 
> Signed-off-by: Lukasz Majewski 

No, printf is fine, always.  We went over this before and it's not a win
to change things.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/6] gpt: command: cosmetic: Replace printf with puts

[Lukasz Majewski]

This code is not processing any data to serial console output and hence
can be replaced with puts.

Signed-off-by: Lukasz Majewski 
---
 common/cmd_gpt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/cmd_gpt.c b/common/cmd_gpt.c
index 4da2de7..4c71125 100644
--- a/common/cmd_gpt.c
+++ b/common/cmd_gpt.c
@@ -281,11 +281,11 @@ static int gpt_default(block_dev_desc_t *blk_dev_desc, 
const char *str_part)
_disk_guid, , _count);
if (ret) {
if (ret == -1)
-   printf("No partition list provided\n");
+   puts("No partition list provided\n");
if (ret == -2)
-   printf("Missing disk guid\n");
+   puts("Missing disk guid\n");
if ((ret == -3) || (ret == -4))
-   printf("Partition list incomplete\n");
+   puts("Partition list incomplete\n");
return -1;
}
 
-- 
2.1.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot