Re: [U-Boot] [PATCH 2/6] rockchip: clk: rk3399: fix warnings for unused variables in SPL/non-SPL

[Simon Glass]

On 25 March 2017 at 21:48, Simon Glass  wrote:
> On 24 March 2017 at 12:24, Philipp Tomsich
>  wrote:
>> Due to differences in the code paths for SPL and non-SPL, some static
>> constant structures remain unused in each build variant. This raises
>> warnings with recent GCC versions (we currently use GCC-6.3).
>>
>> The warnings addressed in this commit (by matching #if conditions for
>> the variable definition with their uses) are:
>>
>> * for the SPL build:
>> drivers/clk/rockchip/clk_rk3399.c:53:29: warning: 'cpll_init_cfg' 
>> defined but not used [-Wunused-const-variable=]
>>  static const struct pll_div cpll_init_cfg = PLL_DIVISORS(CPLL_HZ, 1, 2, 
>> 2);
>>  ^
>> drivers/clk/rockchip/clk_rk3399.c:52:29: warning: 'gpll_init_cfg' 
>> defined but not used [-Wunused-const-variable=]
>>  static const struct pll_div gpll_init_cfg = PLL_DIVISORS(GPLL_HZ, 2, 2, 
>> 1);
>>  ^
>> * for the non-SPL build:
>> drivers/clk/rockchip/clk_rk3399.c:54:29: warning: 'ppll_init_cfg' 
>> defined but not used [-Wunused-const-variable=]
>>  static const struct pll_div ppll_init_cfg = PLL_DIVISORS(PPLL_HZ, 2, 2, 
>> 1);
>>  ^
>>
>> Signed-off-by: Philipp Tomsich 
>> ---
>>
>>  drivers/clk/rockchip/clk_rk3399.c | 5 +
>>  1 file changed, 5 insertions(+)
>
> Acked-by: Simon Glass 

Applied to u-boot-rockchip, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/6] rockchip: clk: rk3399: fix warnings for unused variables in SPL/non-SPL

[Simon Glass]

On 24 March 2017 at 12:24, Philipp Tomsich
 wrote:
> Due to differences in the code paths for SPL and non-SPL, some static
> constant structures remain unused in each build variant. This raises
> warnings with recent GCC versions (we currently use GCC-6.3).
>
> The warnings addressed in this commit (by matching #if conditions for
> the variable definition with their uses) are:
>
> * for the SPL build:
> drivers/clk/rockchip/clk_rk3399.c:53:29: warning: 'cpll_init_cfg' defined 
> but not used [-Wunused-const-variable=]
>  static const struct pll_div cpll_init_cfg = PLL_DIVISORS(CPLL_HZ, 1, 2, 
> 2);
>  ^
> drivers/clk/rockchip/clk_rk3399.c:52:29: warning: 'gpll_init_cfg' defined 
> but not used [-Wunused-const-variable=]
>  static const struct pll_div gpll_init_cfg = PLL_DIVISORS(GPLL_HZ, 2, 2, 
> 1);
>  ^
> * for the non-SPL build:
> drivers/clk/rockchip/clk_rk3399.c:54:29: warning: 'ppll_init_cfg' defined 
> but not used [-Wunused-const-variable=]
>  static const struct pll_div ppll_init_cfg = PLL_DIVISORS(PPLL_HZ, 2, 2, 
> 1);
>  ^
>
> Signed-off-by: Philipp Tomsich 
> ---
>
>  drivers/clk/rockchip/clk_rk3399.c | 5 +
>  1 file changed, 5 insertions(+)

Acked-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/6] rockchip: clk: rk3399: fix warnings for unused variables in SPL/non-SPL

[Philipp Tomsich]

Due to differences in the code paths for SPL and non-SPL, some static
constant structures remain unused in each build variant. This raises
warnings with recent GCC versions (we currently use GCC-6.3).

The warnings addressed in this commit (by matching #if conditions for
the variable definition with their uses) are:

* for the SPL build:
drivers/clk/rockchip/clk_rk3399.c:53:29: warning: 'cpll_init_cfg' defined 
but not used [-Wunused-const-variable=]
 static const struct pll_div cpll_init_cfg = PLL_DIVISORS(CPLL_HZ, 1, 2, 2);
 ^
drivers/clk/rockchip/clk_rk3399.c:52:29: warning: 'gpll_init_cfg' defined 
but not used [-Wunused-const-variable=]
 static const struct pll_div gpll_init_cfg = PLL_DIVISORS(GPLL_HZ, 2, 2, 1);
 ^
* for the non-SPL build:
drivers/clk/rockchip/clk_rk3399.c:54:29: warning: 'ppll_init_cfg' defined 
but not used [-Wunused-const-variable=]
 static const struct pll_div ppll_init_cfg = PLL_DIVISORS(PPLL_HZ, 2, 2, 1);
 ^

Signed-off-by: Philipp Tomsich 
---

 drivers/clk/rockchip/clk_rk3399.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/rockchip/clk_rk3399.c 
b/drivers/clk/rockchip/clk_rk3399.c
index 922ce7e..453c6dd 100644
--- a/drivers/clk/rockchip/clk_rk3399.c
+++ b/drivers/clk/rockchip/clk_rk3399.c
@@ -47,9 +47,12 @@ struct pll_div {
.fbdiv = (u32)((u64)hz * _refdiv * _postdiv1 * _postdiv2 / OSC_HZ),\
.postdiv1 = _postdiv1, .postdiv2 = _postdiv2};
 
+#if defined(CONFIG_SPL_BUILD)
 static const struct pll_div gpll_init_cfg = PLL_DIVISORS(GPLL_HZ, 2, 2, 1);
 static const struct pll_div cpll_init_cfg = PLL_DIVISORS(CPLL_HZ, 1, 2, 2);
+#else
 static const struct pll_div ppll_init_cfg = PLL_DIVISORS(PPLL_HZ, 2, 2, 1);
+#endif
 
 static const struct pll_div apll_l_1600_cfg = PLL_DIVISORS(1600*MHz, 3, 1, 1);
 static const struct pll_div apll_l_600_cfg = PLL_DIVISORS(600*MHz, 1, 2, 1);
@@ -1009,7 +1012,9 @@ static void pmuclk_init(struct rk3399_pmucru *pmucru)
 
 static int rk3399_pmuclk_probe(struct udevice *dev)
 {
+#if CONFIG_IS_ENABLED(OF_PLATDATA) || !defined(CONFIG_SPL_BUILD)
struct rk3399_pmuclk_priv *priv = dev_get_priv(dev);
+#endif
 
 #if CONFIG_IS_ENABLED(OF_PLATDATA)
struct rk3399_pmuclk_plat *plat = dev_get_platdata(dev);
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot