Re: [U-Boot] [PATCH 21/22] net: xilinx_ll_temac: Fix string overflow

[Bin Meng]

On Tue, Jan 26, 2016 at 6:24 PM, Ricardo Ribalda Delgado
 wrote:
> Size of this snprintf "lltemac.%lx" is bigger than 16 characters.
> Replacing it with "ll_tem.%lx"
>
> Signed-off-by: Ricardo Ribalda Delgado 
> ---
>  drivers/net/xilinx_ll_temac.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 21/22] net: xilinx_ll_temac: Fix string overflow

[Ricardo Ribalda Delgado]

Size of this snprintf "lltemac.%lx" is bigger than 16 characters.
Replacing it with "ll_tem.%lx"

Signed-off-by: Ricardo Ribalda Delgado 
---
 drivers/net/xilinx_ll_temac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/xilinx_ll_temac.c b/drivers/net/xilinx_ll_temac.c
index 7cc86571e495..ca09546ab59f 100644
--- a/drivers/net/xilinx_ll_temac.c
+++ b/drivers/net/xilinx_ll_temac.c
@@ -303,7 +303,8 @@ int xilinx_ll_temac_initialize(bd_t *bis, struct 
ll_temac_info *devinf)
if (devinf->devname) {
strncpy(dev->name, devinf->devname, sizeof(dev->name));
} else {
-   snprintf(dev->name, sizeof(dev->name), "lltemac.%lx", 
devinf->base_addr);
+   snprintf(dev->name, sizeof(dev->name), "ll_tem.%lx",
+devinf->base_addr);
devinf->devname = dev->name;
}
 
-- 
2.7.0.rc3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 21/22] net: xilinx_ll_temac: Fix string overflow

[Tom Rini]

On Tue, Jan 26, 2016 at 11:24:24AM +0100, Ricardo Ribalda Delgado wrote:

> Size of this snprintf "lltemac.%lx" is bigger than 16 characters.
> Replacing it with "ll_tem.%lx"
> 
> Signed-off-by: Ricardo Ribalda Delgado 

Reviewed-by: Tom Rini 

... and added to my TODO list to check over everyone else too.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot