Re: [U-Boot] [PATCH 3/3] sunxi: add I2C nodes present on Orange Pi >ero

[Maxime Ripard]

On Wed, Jan 24, 2018 at 12:03:26PM +0100, Nuno Gonçalves wrote:
> On Wed, Jan 24, 2018 at 11:58 AM, Maxime Ripard
>  wrote:
> > In particular, you should describe what these i2c buses are used for.
> 
> They are available on the pins exclusively. I could add the pinout for
> this board for sure. But maybe it doesn't make sense in this case to
> activate them, as without external hardware they have no use.

Indeed. It's still good to have that patch for reference though, even
if we won't merge it.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/3] sunxi: add I2C nodes present on Orange Pi >ero

[Nuno Gonçalves]

On Wed, Jan 24, 2018 at 11:58 AM, Maxime Ripard
 wrote:
> In particular, you should describe what these i2c buses are used for.

They are available on the pins exclusively. I could add the pinout for
this board for sure. But maybe it doesn't make sense in this case to
activate them, as without external hardware they have no use.

Thanks,
Nuno
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 3/3] sunxi: add I2C nodes present on Orange Pi >ero

[Nuno Goncalves]

Signed-off-by: Nuno Goncalves 
---
 arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts | 12 
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts 
b/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts
index 20d489cb2a..f028d175f3 100644
--- a/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts
+++ b/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts
@@ -138,6 +138,18 @@
};
 };
 
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_a>;
+   status = "okay";
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_a>;
+   status = "okay";
+};
+
  {
status = "okay";
 };
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/3] sunxi: add I2C nodes present on Orange Pi >ero

[Maxime Ripard]

Hi,

On Wed, Jan 24, 2018 at 11:01:53AM +0100, Nuno Goncalves wrote:
> Signed-off-by: Nuno Goncalves 

Commit log please.

> ---
>  arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts | 12 
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts 
> b/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts
> index 20d489cb2a..f028d175f3 100644
> --- a/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts
> +++ b/arch/arm/dts/sun8i-h2-plus-orangepi-zero.dts
> @@ -138,6 +138,18 @@
>   };
>  };
>  
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_a>;
> + status = "okay";
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_a>;
> + status = "okay";
> +};
> +

In particular, you should describe what these i2c buses are used for.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot