Re: [U-Boot] [PATCH 3/4] arm: fixloop(): do not use r8 for relocation

[Albert ARIBAUD]

Le 01/12/2010 00:58, Andreas Bießmann a écrit :
 r8 is used for global_data and should therefore be left alone!

 For C code the compiler flag --fixed-r8 does the job, but in assembler
 we need to be aware of that fact.

 Signed-off-by: Andreas Bießmannandreas.de...@googlemail.com

Acked-By: Albert ARIBAUD albertarib...@free.fr

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/4] arm: fixloop(): do not use r8 for relocation

[Wolfgang Denk]

Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message 1291161516-21861-4-git-send-email-andreas.de...@googlemail.com you 
wrote:
 r8 is used for global_data and should therefore be left alone!
 
 For C code the compiler flag --fixed-r8 does the job, but in assembler
 we need to be aware of that fact.

 Signed-off-by: Andreas Bießmann andreas.de...@googlemail.com
 ---
  arch/arm/cpu/arm1136/start.S   |6 +++---
  arch/arm/cpu/arm1176/start.S   |6 +++---
  arch/arm/cpu/arm720t/start.S   |6 +++---
  arch/arm/cpu/arm920t/start.S   |6 +++---
  arch/arm/cpu/arm925t/start.S   |6 +++---
  arch/arm/cpu/arm926ejs/start.S |6 +++---
  arch/arm/cpu/arm946es/start.S  |6 +++---
  arch/arm/cpu/arm_intcm/start.S |6 +++---
  arch/arm/cpu/armv7/start.S |6 +++---
  arch/arm/cpu/ixp/start.S   |6 +++---
  arch/arm/cpu/lh7a40x/start.S   |6 +++---
  arch/arm/cpu/pxa/start.S   |6 +++---
  arch/arm/cpu/s3c44b0/start.S   |6 +++---
  arch/arm/cpu/sa1100/start.S|6 +++---
  14 files changed, 42 insertions(+), 42 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The IQ of the group is the lowest IQ of a member of the group divided
by the number of people in the group.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 3/4] arm: fixloop(): do not use r8 for relocation

[Andreas Bießmann]

r8 is used for global_data and should therefore be left alone!

For C code the compiler flag --fixed-r8 does the job, but in assembler
we need to be aware of that fact.

Signed-off-by: Andreas Bießmann andreas.de...@googlemail.com
---
 arch/arm/cpu/arm1136/start.S   |6 +++---
 arch/arm/cpu/arm1176/start.S   |6 +++---
 arch/arm/cpu/arm720t/start.S   |6 +++---
 arch/arm/cpu/arm920t/start.S   |6 +++---
 arch/arm/cpu/arm925t/start.S   |6 +++---
 arch/arm/cpu/arm926ejs/start.S |6 +++---
 arch/arm/cpu/arm946es/start.S  |6 +++---
 arch/arm/cpu/arm_intcm/start.S |6 +++---
 arch/arm/cpu/armv7/start.S |6 +++---
 arch/arm/cpu/ixp/start.S   |6 +++---
 arch/arm/cpu/lh7a40x/start.S   |6 +++---
 arch/arm/cpu/pxa/start.S   |6 +++---
 arch/arm/cpu/s3c44b0/start.S   |6 +++---
 arch/arm/cpu/sa1100/start.S|6 +++---
 14 files changed, 42 insertions(+), 42 deletions(-)

diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 7ba7245..fa56cd0 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -221,10 +221,10 @@ fixloop:
ldr r0, [r2]/* r0 - location to fix up, IN FLASH! 
*/
add r0, r0, r9  /* r0 - location to fix up in RAM */
ldr r1, [r2, #4]
-   and r8, r1, #0xff
-   cmp r8, #23 /* relative fixup? */
+   and r7, r1, #0xff
+   cmp r7, #23 /* relative fixup? */
beq fixrel
-   cmp r8, #2  /* absolute fixup? */
+   cmp r7, #2  /* absolute fixup? */
beq fixabs
/* ignore unknown type of fixup */
b   fixnext
diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S
index f9c8671..278ae50 100644
--- a/arch/arm/cpu/arm1176/start.S
+++ b/arch/arm/cpu/arm1176/start.S
@@ -275,10 +275,10 @@ fixloop:
ldr r0, [r2]/* r0 - location to fix up, IN FLASH! 
*/
add r0, r0, r9  /* r0 - location to fix up in RAM */
ldr r1, [r2, #4]
-   and r8, r1, #0xff
-   cmp r8, #23 /* relative fixup? */
+   and r7, r1, #0xff
+   cmp r7, #23 /* relative fixup? */
beq fixrel
-   cmp r8, #2  /* absolute fixup? */
+   cmp r7, #2  /* absolute fixup? */
beq fixabs
/* ignore unknown type of fixup */
b   fixnext
diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S
index 6a6af1b..9b34e89 100644
--- a/arch/arm/cpu/arm720t/start.S
+++ b/arch/arm/cpu/arm720t/start.S
@@ -190,10 +190,10 @@ fixloop:
ldr r0, [r2]/* r0 - location to fix up, IN FLASH! 
*/
add r0, r0, r9  /* r0 - location to fix up in RAM */
ldr r1, [r2, #4]
-   and r8, r1, #0xff
-   cmp r8, #23 /* relative fixup? */
+   and r7, r1, #0xff
+   cmp r7, #23 /* relative fixup? */
beq fixrel
-   cmp r8, #2  /* absolute fixup? */
+   cmp r7, #2  /* absolute fixup? */
beq fixabs
/* ignore unknown type of fixup */
b   fixnext
diff --git a/arch/arm/cpu/arm920t/start.S b/arch/arm/cpu/arm920t/start.S
index cdf0920..914ab27 100644
--- a/arch/arm/cpu/arm920t/start.S
+++ b/arch/arm/cpu/arm920t/start.S
@@ -236,10 +236,10 @@ fixloop:
ldr r0, [r2]/* r0 - location to fix up, IN FLASH! 
*/
add r0, r0, r9  /* r0 - location to fix up in RAM */
ldr r1, [r2, #4]
-   and r8, r1, #0xff
-   cmp r8, #23 /* relative fixup? */
+   and r7, r1, #0xff
+   cmp r7, #23 /* relative fixup? */
beq fixrel
-   cmp r8, #2  /* absolute fixup? */
+   cmp r7, #2  /* absolute fixup? */
beq fixabs
/* ignore unknown type of fixup */
b   fixnext
diff --git a/arch/arm/cpu/arm925t/start.S b/arch/arm/cpu/arm925t/start.S
index 54f2339..f7a0d0e 100644
--- a/arch/arm/cpu/arm925t/start.S
+++ b/arch/arm/cpu/arm925t/start.S
@@ -227,10 +227,10 @@ fixloop:
ldr r0, [r2]/* r0 - location to fix up, IN FLASH! 
*/
add r0, r0, r9  /* r0 - location to fix up in RAM */
ldr r1, [r2, #4]
-   and r8, r1, #0xff
-   cmp r8, #23 /* relative fixup? */
+   and r7, r1, #0xff
+   cmp r7, #23 /* relative fixup? */
beq fixrel
-   cmp r8, #2  /* absolute fixup? */
+   cmp r7, #2  /* absolute fixup? */
beq fixabs
/* ignore unknown type of fixup */
b   fixnext