Re: [U-Boot] [PATCH 3/7] configs: k2g_evm: make sure config fallbacks take effect

[Tom Rini]

On Fri, Jun 02, 2017 at 05:54:01PM +0530, Sekhar Nori wrote:

> Since config fallbacks contained in include/config_fallbacks.h
> come into k2g_evm.h file through ti_armv7_keystone2.h, it should
> be the last file included.
> 
> Without this, #define of FAT_WRITE when environment is in FAT
> does not happen as the environment location is decided later
> in the file.
> 
> Similar issues can come with other config fallbacks implemented.
> 
> Signed-off-by: Sekhar Nori 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/7] configs: k2g_evm: make sure config fallbacks take effect

[Tom Rini]

On Fri, Jun 02, 2017 at 05:54:01PM +0530, Sekhar Nori wrote:

> Since config fallbacks contained in include/config_fallbacks.h
> come into k2g_evm.h file through ti_armv7_keystone2.h, it should
> be the last file included.
> 
> Without this, #define of FAT_WRITE when environment is in FAT
> does not happen as the environment location is decided later
> in the file.
> 
> Similar issues can come with other config fallbacks implemented.
> 
> Signed-off-by: Sekhar Nori 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 3/7] configs: k2g_evm: make sure config fallbacks take effect

[Sekhar Nori]

Since config fallbacks contained in include/config_fallbacks.h
come into k2g_evm.h file through ti_armv7_keystone2.h, it should
be the last file included.

Without this, #define of FAT_WRITE when environment is in FAT
does not happen as the environment location is decided later
in the file.

Similar issues can come with other config fallbacks implemented.

Signed-off-by: Sekhar Nori 
---
 include/configs/k2g_evm.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/configs/k2g_evm.h b/include/configs/k2g_evm.h
index 9a07eacb8e7a..1cc35769840f 100644
--- a/include/configs/k2g_evm.h
+++ b/include/configs/k2g_evm.h
@@ -48,8 +48,6 @@
"get_pmmc_${boot} run_pmmc get_mon_${boot} run_mon "\
"get_fdt_${boot} get_kern_${boot} run_kern"
 
-#include 
-
 /* SPL SPI Loader Configuration */
 #define CONFIG_SPL_TEXT_BASE   0x0c08
 
@@ -80,4 +78,7 @@
 #endif
 
 #define SPI_MTD_PARTS  KEYSTONE_SPI1_MTD_PARTS
+
+#include 
+
 #endif /* __CONFIG_K2G_EVM_H */
-- 
2.9.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot