Re: [U-Boot] [PATCH 32/48] x86: Add a link script entry for U-Boot as a payload

2015-07-23 Thread Bin Meng
Hi Simon,

On Wed, Jul 22, 2015 at 11:49 PM, Simon Glass s...@chromium.org wrote:
 Allow U-Boot to be packaged into the image as a binary payload.

 Signed-off-by: Simon Glass s...@chromium.org

Reviewed-by: Bin Meng bmeng...@gmail.com

But please check comments below.

 ---

  arch/x86/cpu/efi/elf_ia32_efi.lds | 3 +++
  1 file changed, 3 insertions(+)

 diff --git a/arch/x86/cpu/efi/elf_ia32_efi.lds 
 b/arch/x86/cpu/efi/elf_ia32_efi.lds
 index fca008b..87ddb4d 100644
 --- a/arch/x86/cpu/efi/elf_ia32_efi.lds
 +++ b/arch/x86/cpu/efi/elf_ia32_efi.lds
 @@ -57,6 +57,9 @@ SECTIONS
 KEEP(*(SORT(.u_boot_list*)));
 . = ALIGN(8);
 KEEP(*(.dtb*));
 +   /* Keep U-Boot payload */
 +   . = ALIGN(8);
 +   KEEP(*(.u_boot_bin.*));

I don't see section .u_boot_bin defined so far. Assume it is
introduced in later patches, so please consider the patch order.

 }
 .dynamic  : { *(.dynamic) }
 . = ALIGN(4096);
 --

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 32/48] x86: Add a link script entry for U-Boot as a payload

2015-07-22 Thread Simon Glass
Allow U-Boot to be packaged into the image as a binary payload.

Signed-off-by: Simon Glass s...@chromium.org
---

 arch/x86/cpu/efi/elf_ia32_efi.lds | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/cpu/efi/elf_ia32_efi.lds 
b/arch/x86/cpu/efi/elf_ia32_efi.lds
index fca008b..87ddb4d 100644
--- a/arch/x86/cpu/efi/elf_ia32_efi.lds
+++ b/arch/x86/cpu/efi/elf_ia32_efi.lds
@@ -57,6 +57,9 @@ SECTIONS
KEEP(*(SORT(.u_boot_list*)));
. = ALIGN(8);
KEEP(*(.dtb*));
+   /* Keep U-Boot payload */
+   . = ALIGN(8);
+   KEEP(*(.u_boot_bin.*));
}
.dynamic  : { *(.dynamic) }
. = ALIGN(4096);
-- 
2.4.3.573.g4eafbef

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot