Re: [U-Boot] [PATCH 32/82] x86: ivybridge: Tidy up enable_clock_gating() for 64-bit

[Bin Meng]

On Tue, Oct 11, 2016 at 11:16 AM, Bin Meng  wrote:
> Hi Simon,
>
> On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass  wrote:
>> Fix the hex case and remove unused brackets. Use -0U instead of ~0UL to
>
> Should be: ~0U

Fixed this, and

>
>> allow compilation on 64-bit machines.
>>
>> Signed-off-by: Simon Glass 
>> ---
>>
>>  arch/x86/cpu/ivybridge/lpc.c | 8 
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/cpu/ivybridge/lpc.c b/arch/x86/cpu/ivybridge/lpc.c
>> index c564713..aef1206 100644
>> --- a/arch/x86/cpu/ivybridge/lpc.c
>> +++ b/arch/x86/cpu/ivybridge/lpc.c
>> @@ -357,10 +357,10 @@ static void enable_clock_gating(struct udevice *pch)
>> reg16 |= (1 << 2) | (1 << 11);
>> dm_pci_write_config16(pch, GEN_PMCON_1, reg16);
>>
>> -   pch_iobp_update(pch, 0xEB007F07, ~0UL, (1 << 31));
>> -   pch_iobp_update(pch, 0xEB004000, ~0UL, (1 << 7));
>> -   pch_iobp_update(pch, 0xEC007F07, ~0UL, (1 << 31));
>> -   pch_iobp_update(pch, 0xEC004000, ~0UL, (1 << 7));
>> +   pch_iobp_update(pch, 0xeb007f07, ~0U, 1 << 31);
>> +   pch_iobp_update(pch, 0xeb004000, ~0U, 1 << 7);
>> +   pch_iobp_update(pch, 0xec007f07, ~0U, 1 << 31);
>> +   pch_iobp_update(pch, 0xec004000, ~0U, 1 << 7);
>>
>> reg32 = readl(RCB_REG(CG));
>> reg32 |= (1 << 31);
>> --
>
> Reviewed-by: Bin Meng 

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 32/82] x86: ivybridge: Tidy up enable_clock_gating() for 64-bit

[Bin Meng]

Hi Simon,

On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass  wrote:
> Fix the hex case and remove unused brackets. Use -0U instead of ~0UL to

Should be: ~0U

> allow compilation on 64-bit machines.
>
> Signed-off-by: Simon Glass 
> ---
>
>  arch/x86/cpu/ivybridge/lpc.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/cpu/ivybridge/lpc.c b/arch/x86/cpu/ivybridge/lpc.c
> index c564713..aef1206 100644
> --- a/arch/x86/cpu/ivybridge/lpc.c
> +++ b/arch/x86/cpu/ivybridge/lpc.c
> @@ -357,10 +357,10 @@ static void enable_clock_gating(struct udevice *pch)
> reg16 |= (1 << 2) | (1 << 11);
> dm_pci_write_config16(pch, GEN_PMCON_1, reg16);
>
> -   pch_iobp_update(pch, 0xEB007F07, ~0UL, (1 << 31));
> -   pch_iobp_update(pch, 0xEB004000, ~0UL, (1 << 7));
> -   pch_iobp_update(pch, 0xEC007F07, ~0UL, (1 << 31));
> -   pch_iobp_update(pch, 0xEC004000, ~0UL, (1 << 7));
> +   pch_iobp_update(pch, 0xeb007f07, ~0U, 1 << 31);
> +   pch_iobp_update(pch, 0xeb004000, ~0U, 1 << 7);
> +   pch_iobp_update(pch, 0xec007f07, ~0U, 1 << 31);
> +   pch_iobp_update(pch, 0xec004000, ~0U, 1 << 7);
>
> reg32 = readl(RCB_REG(CG));
> reg32 |= (1 << 31);
> --

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 32/82] x86: ivybridge: Tidy up enable_clock_gating() for 64-bit

[Simon Glass]

Fix the hex case and remove unused brackets. Use -0U instead of ~0UL to
allow compilation on 64-bit machines.

Signed-off-by: Simon Glass 
---

 arch/x86/cpu/ivybridge/lpc.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/cpu/ivybridge/lpc.c b/arch/x86/cpu/ivybridge/lpc.c
index c564713..aef1206 100644
--- a/arch/x86/cpu/ivybridge/lpc.c
+++ b/arch/x86/cpu/ivybridge/lpc.c
@@ -357,10 +357,10 @@ static void enable_clock_gating(struct udevice *pch)
reg16 |= (1 << 2) | (1 << 11);
dm_pci_write_config16(pch, GEN_PMCON_1, reg16);
 
-   pch_iobp_update(pch, 0xEB007F07, ~0UL, (1 << 31));
-   pch_iobp_update(pch, 0xEB004000, ~0UL, (1 << 7));
-   pch_iobp_update(pch, 0xEC007F07, ~0UL, (1 << 31));
-   pch_iobp_update(pch, 0xEC004000, ~0UL, (1 << 7));
+   pch_iobp_update(pch, 0xeb007f07, ~0U, 1 << 31);
+   pch_iobp_update(pch, 0xeb004000, ~0U, 1 << 7);
+   pch_iobp_update(pch, 0xec007f07, ~0U, 1 << 31);
+   pch_iobp_update(pch, 0xec004000, ~0U, 1 << 7);
 
reg32 = readl(RCB_REG(CG));
reg32 |= (1 << 31);
-- 
2.8.0.rc3.226.g39d4020

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot