Re: [U-Boot] [PATCH 33/82] x86: dts: Mark serial as needed before relocation

[Simon Glass]

Hi Bin,

On 10 October 2016 at 21:16, Bin Meng  wrote:
> Hi Simon,
>
> On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass  wrote:
>> We almost always need the serial port before relocation, so mark it as such.
>> This will ensure that it appears in the device tree for SPL, if used.
>>
>> Signed-off-by: Simon Glass 
>> ---
>>
>>  arch/x86/dts/serial.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/dts/serial.dtsi b/arch/x86/dts/serial.dtsi
>> index 54c3faf..22f7b54 100644
>> --- a/arch/x86/dts/serial.dtsi
>> +++ b/arch/x86/dts/serial.dtsi
>> @@ -1,5 +1,6 @@
>>  / {
>> serial: serial {
>> +   u-boot,dm-pre-reloc;
>
> The ns16550 driver already has the pre-relocation flag, why is this
> still needed?

Without this, it will not appear in the SPL device tree (fdtgrep will
drop it). So we need it here.

>
>> compatible = "ns16550";
>> reg = <0x3f8 8>;
>> reg-shift = <0>;
>> --

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 33/82] x86: dts: Mark serial as needed before relocation

[Bin Meng]

Hi Simon,

On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass  wrote:
> We almost always need the serial port before relocation, so mark it as such.
> This will ensure that it appears in the device tree for SPL, if used.
>
> Signed-off-by: Simon Glass 
> ---
>
>  arch/x86/dts/serial.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/dts/serial.dtsi b/arch/x86/dts/serial.dtsi
> index 54c3faf..22f7b54 100644
> --- a/arch/x86/dts/serial.dtsi
> +++ b/arch/x86/dts/serial.dtsi
> @@ -1,5 +1,6 @@
>  / {
> serial: serial {
> +   u-boot,dm-pre-reloc;

The ns16550 driver already has the pre-relocation flag, why is this
still needed?

> compatible = "ns16550";
> reg = <0x3f8 8>;
> reg-shift = <0>;
> --

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 33/82] x86: dts: Mark serial as needed before relocation

[Simon Glass]

We almost always need the serial port before relocation, so mark it as such.
This will ensure that it appears in the device tree for SPL, if used.

Signed-off-by: Simon Glass 
---

 arch/x86/dts/serial.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/dts/serial.dtsi b/arch/x86/dts/serial.dtsi
index 54c3faf..22f7b54 100644
--- a/arch/x86/dts/serial.dtsi
+++ b/arch/x86/dts/serial.dtsi
@@ -1,5 +1,6 @@
 / {
serial: serial {
+   u-boot,dm-pre-reloc;
compatible = "ns16550";
reg = <0x3f8 8>;
reg-shift = <0>;
-- 
2.8.0.rc3.226.g39d4020

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot