Re: [U-Boot] [PATCH 35/41] dm: core: device: enable power domain in probe

[Simon Glass]

Hi Peng,

On 18 July 2018 at 06:56, Peng Fan  wrote:
> Hi Simon
>
>> -Original Message-
>> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
>> Sent: 2018年5月31日 3:19
>> To: Peng Fan 
>> Cc: Stefano Babic ; Fabio Estevam
>> ; U-Boot Mailing List 
>> Subject: Re: [PATCH 35/41] dm: core: device: enable power domain in probe
>>
>> On 28 May 2018 at 06:25, Peng Fan  wrote:
>> > Enable power domain associated with the device when probe.
>> >
>> > Signed-off-by: Peng Fan 
>> > Cc: Simon Glass 
>> > ---
>> >  drivers/core/device.c | 7 +++
>> >  1 file changed, 7 insertions(+)
>> >
>>
>> How is this feature tested at present? Can you add something to the
>> power-domain test?
>
> Sorry for late reply.
> Do you mean add code to test/dm/power-domain.c?
> And the test is run test/run?

Yes and yes - or 'make tests'.

We really should have a 'make check' target.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 35/41] dm: core: device: enable power domain in probe

[Peng Fan]

Hi Simon

> -Original Message-
> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
> Sent: 2018年5月31日 3:19
> To: Peng Fan 
> Cc: Stefano Babic ; Fabio Estevam
> ; U-Boot Mailing List 
> Subject: Re: [PATCH 35/41] dm: core: device: enable power domain in probe
> 
> On 28 May 2018 at 06:25, Peng Fan  wrote:
> > Enable power domain associated with the device when probe.
> >
> > Signed-off-by: Peng Fan 
> > Cc: Simon Glass 
> > ---
> >  drivers/core/device.c | 7 +++
> >  1 file changed, 7 insertions(+)
> >
> 
> How is this feature tested at present? Can you add something to the
> power-domain test?

Sorry for late reply. 
Do you mean add code to test/dm/power-domain.c?
And the test is run test/run?

Thanks,
Peng.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 35/41] dm: core: device: enable power domain in probe

[Simon Glass]

On 28 May 2018 at 06:25, Peng Fan  wrote:
> Enable power domain associated with the device when probe.
>
> Signed-off-by: Peng Fan 
> Cc: Simon Glass 
> ---
>  drivers/core/device.c | 7 +++
>  1 file changed, 7 insertions(+)
>

How is this feature tested at present? Can you add something to the
power-domain test?
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 35/41] dm: core: device: enable power domain in probe

[Peng Fan]

Enable power domain associated with the device when probe.

Signed-off-by: Peng Fan 
Cc: Simon Glass 
---
 drivers/core/device.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/drivers/core/device.c b/drivers/core/device.c
index e048e1a659..b6950d9dbb 100644
--- a/drivers/core/device.c
+++ b/drivers/core/device.c
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -296,6 +297,7 @@ static void *alloc_priv(int size, uint flags)
 
 int device_probe(struct udevice *dev)
 {
+   struct power_domain pd;
const struct driver *drv;
int size = 0;
int ret;
@@ -375,6 +377,11 @@ int device_probe(struct udevice *dev)
if (dev->parent && device_get_uclass_id(dev) != UCLASS_PINCTRL)
pinctrl_select_state(dev, "default");
 
+   if (dev->parent && device_get_uclass_id(dev) != UCLASS_POWER_DOMAIN) {
+   if (!power_domain_get(dev, ))
+   power_domain_on();
+   }
+
ret = uclass_pre_probe_device(dev);
if (ret)
goto fail;
-- 
2.14.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot