Re: [U-Boot] [PATCH 36/41] drivers: regulator: fixed: add off-on-delay-us

2018-05-30 Thread Simon Glass
On 28 May 2018 at 06:25, Peng Fan  wrote:
> Add off-on-delay-us for fixed regulator.
>
> Signed-off-by: Peng Fan 
> Cc: Simon Glass 
> ---
>  drivers/power/regulator/fixed.c | 6 ++
>  1 file changed, 6 insertions(+)

Reviewed-by: Simon Glass 

Can you also please add the DT binding file for this?
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 36/41] drivers: regulator: fixed: add off-on-delay-us

2018-05-28 Thread Peng Fan
Add off-on-delay-us for fixed regulator.

Signed-off-by: Peng Fan 
Cc: Simon Glass 
---
 drivers/power/regulator/fixed.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/power/regulator/fixed.c b/drivers/power/regulator/fixed.c
index 0be5b7bd51..b72ad98cb8 100644
--- a/drivers/power/regulator/fixed.c
+++ b/drivers/power/regulator/fixed.c
@@ -16,6 +16,7 @@
 struct fixed_regulator_platdata {
struct gpio_desc gpio; /* GPIO for regulator enable control */
unsigned int startup_delay_us;
+   unsigned int off_on_delay_us;
 };
 
 static int fixed_regulator_ofdata_to_platdata(struct udevice *dev)
@@ -50,6 +51,8 @@ static int fixed_regulator_ofdata_to_platdata(struct udevice 
*dev)
/* Get optional ramp up delay */
dev_pdata->startup_delay_us = dev_read_u32_default(dev,
"startup-delay-us", 0);
+   dev_pdata->off_on_delay_us = dev_read_u32_default(dev,
+ "off-on-delay-us", 0);
 
return 0;
 }
@@ -123,6 +126,9 @@ static int fixed_regulator_set_enable(struct udevice *dev, 
bool enable)
udelay(dev_pdata->startup_delay_us);
debug("%s: done\n", __func__);
 
+   if (!enable && dev_pdata->off_on_delay_us)
+   udelay(dev_pdata->off_on_delay_us);
+
return 0;
 }
 
-- 
2.14.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot