Re: [U-Boot] [PATCH 4/4] colibri_t20: fix ulpi reset polarity

2016-12-25 Thread Simon Glass 
On 20 December 2016 at 03:38, Marcel Ziswiler  wrote:
> From: Marcel Ziswiler 
>
> Fix ULPI reset polarity which caused a hard hang on Colibri T20 upon
> attempting to start the USB subsystem:
>
> This fixes my late commit d5a24d8b53d350364bd429b7104ec369b817e4b8
> (colibri_t20: fix usb operation and controller order) inadvertently
> having overwritten Stephen's previous commit
> 2f6a7e8ce5df8b99d84bfd486c6f99d92322ce04 (ARM: tegra: fix USB ULPI PHY
> reset signal inversion confusion).
>
> While at it also fix comment about on-module USB port.
>
> Signed-off-by: Marcel Ziswiler 
>
> ---
>
>  arch/arm/dts/tegra20-colibri.dts | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 4/4] colibri_t20: fix ulpi reset polarity

2016-12-19 Thread Marcel Ziswiler 
From: Marcel Ziswiler 

Fix ULPI reset polarity which caused a hard hang on Colibri T20 upon
attempting to start the USB subsystem:

This fixes my late commit d5a24d8b53d350364bd429b7104ec369b817e4b8
(colibri_t20: fix usb operation and controller order) inadvertently
having overwritten Stephen's previous commit
2f6a7e8ce5df8b99d84bfd486c6f99d92322ce04 (ARM: tegra: fix USB ULPI PHY
reset signal inversion confusion).

While at it also fix comment about on-module USB port.

Signed-off-by: Marcel Ziswiler 

---

 arch/arm/dts/tegra20-colibri.dts | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/tegra20-colibri.dts b/arch/arm/dts/tegra20-colibri.dts
index 89adfb6..3c10dd6 100644
--- a/arch/arm/dts/tegra20-colibri.dts
+++ b/arch/arm/dts/tegra20-colibri.dts
@@ -16,7 +16,7 @@
i2c2 = "/i2c@7000c400";
mmc0 = "/sdhci@c8000600";
usb0 = "/usb@c500";
-   usb1 = "/usb@c5004000"; /* on-module only, for ASIX */
+   usb1 = "/usb@c5004000"; /* On-module only, for ASIX */
usb2 = "/usb@c5008000";
};
 
@@ -92,8 +92,10 @@
/* EHCI instance 1: ULPI -> USB3340 -> AX88772B */
usb@c5004000 {
status = "okay";
+   /* ULPI_RESET */
+   nvidia,phy-reset-gpio =
+   < TEGRA_GPIO(V, 1) GPIO_ACTIVE_LOW>;
/* VBUS_LAN */
-   nvidia,phy-reset-gpio = < TEGRA_GPIO(V, 1) 
GPIO_ACTIVE_HIGH>;
nvidia,vbus-gpio = < TEGRA_GPIO(BB, 1) GPIO_ACTIVE_HIGH>;
};
 
-- 
2.9.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot