Re: [U-Boot] [PATCH 4/4] sunxi: sina33: Enable the LCD

2016-11-14 Thread Jaehoon Chung 
On 11/14/2016 03:51 AM, Hans de Goede wrote:
> Hi,
> 
> On 04-11-16 16:18, Maxime Ripard wrote:
>> The SinA33 comes with an optional 7" display. Enable it in the
>> configuration.
>>
>> Signed-off-by: Maxime Ripard 
> 
> LGTM:
> 
> Reviewed-by: Hans de Goede 

Applied on u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

> 
> Regards,
> 
> Hans
> 
> 
> 
>> ---
>>  configs/Sinlinx_SinA33_defconfig | 4 
>>  1 file changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/configs/Sinlinx_SinA33_defconfig 
>> b/configs/Sinlinx_SinA33_defconfig
>> index f4719db2d501..26b119a9b92f 100644
>> --- a/configs/Sinlinx_SinA33_defconfig
>> +++ b/configs/Sinlinx_SinA33_defconfig
>> @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291
>>  CONFIG_MMC0_CD_PIN="PB4"
>>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>>  CONFIG_USB0_ID_DET="PH8"
>> +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0"
>> +CONFIG_VIDEO_LCD_DCLK_PHASE=0
>> +CONFIG_VIDEO_LCD_BL_EN="PH6"
>> +CONFIG_VIDEO_LCD_BL_PWM="PH0"
>>  CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>>  CONFIG_SPL=y
>>
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/4] sunxi: sina33: Enable the LCD

2016-11-14 Thread Jaehoon Chung 
Hi Hans,

On 11/14/2016 03:51 AM, Hans de Goede wrote:
> Hi,
> 
> On 04-11-16 16:18, Maxime Ripard wrote:
>> The SinA33 comes with an optional 7" display. Enable it in the
>> configuration.
>>
>> Signed-off-by: Maxime Ripard 
> 
> LGTM:
> 
> Reviewed-by: Hans de Goede 

This patch is not on MMC side. But i picked with other patches.
If there is other issue, let me know, plz.

Best Regards,
Jaehoon Chung

> 
> Regards,
> 
> Hans
> 
> 
> 
>> ---
>>  configs/Sinlinx_SinA33_defconfig | 4 
>>  1 file changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/configs/Sinlinx_SinA33_defconfig 
>> b/configs/Sinlinx_SinA33_defconfig
>> index f4719db2d501..26b119a9b92f 100644
>> --- a/configs/Sinlinx_SinA33_defconfig
>> +++ b/configs/Sinlinx_SinA33_defconfig
>> @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291
>>  CONFIG_MMC0_CD_PIN="PB4"
>>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>>  CONFIG_USB0_ID_DET="PH8"
>> +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0"
>> +CONFIG_VIDEO_LCD_DCLK_PHASE=0
>> +CONFIG_VIDEO_LCD_BL_EN="PH6"
>> +CONFIG_VIDEO_LCD_BL_PWM="PH0"
>>  CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>>  CONFIG_SPL=y
>>
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/4] sunxi: sina33: Enable the LCD

2016-11-13 Thread Hans de Goede 

Hi,

On 04-11-16 16:18, Maxime Ripard wrote:

The SinA33 comes with an optional 7" display. Enable it in the
configuration.

Signed-off-by: Maxime Ripard 


LGTM:

Reviewed-by: Hans de Goede 

Regards,

Hans




---
 configs/Sinlinx_SinA33_defconfig | 4 
 1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig
index f4719db2d501..26b119a9b92f 100644
--- a/configs/Sinlinx_SinA33_defconfig
+++ b/configs/Sinlinx_SinA33_defconfig
@@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291
 CONFIG_MMC0_CD_PIN="PB4"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_USB0_ID_DET="PH8"
+CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0"
+CONFIG_VIDEO_LCD_DCLK_PHASE=0
+CONFIG_VIDEO_LCD_BL_EN="PH6"
+CONFIG_VIDEO_LCD_BL_PWM="PH0"
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL=y


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/4] sunxi: sina33: Enable the LCD

2016-11-11 Thread Chen-Yu Tsai 
Hi,

On Fri, Nov 4, 2016 at 11:18 PM, Maxime Ripard
 wrote:
> The SinA33 comes with an optional 7" display. Enable it in the
> configuration.
>
> Signed-off-by: Maxime Ripard 
> ---
>  configs/Sinlinx_SinA33_defconfig | 4 
>  1 file changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/configs/Sinlinx_SinA33_defconfig 
> b/configs/Sinlinx_SinA33_defconfig
> index f4719db2d501..26b119a9b92f 100644
> --- a/configs/Sinlinx_SinA33_defconfig
> +++ b/configs/Sinlinx_SinA33_defconfig
> @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291
>  CONFIG_MMC0_CD_PIN="PB4"
>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>  CONFIG_USB0_ID_DET="PH8"
> +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0"
> +CONFIG_VIDEO_LCD_DCLK_PHASE=0
> +CONFIG_VIDEO_LCD_BL_EN="PH6"
> +CONFIG_VIDEO_LCD_BL_PWM="PH0"

I'm using the exact same panel with my SinA31s. The schematics show
that these 2 pins aren't actually hooked up to the panel at all.
Instead of BL_EN, the corresponding pin is pull-ed up to 3.3V by
a resistor just before the LCD connector on the base board.

Please try it without these 2 pins set.

ChenYu

P.S. I've also a VGA converter board for the SinA33 which I've never tried.

>  CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_SPL=y
> --
> git-series 0.8.11
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 4/4] sunxi: sina33: Enable the LCD

2016-11-04 Thread Maxime Ripard 
The SinA33 comes with an optional 7" display. Enable it in the
configuration.

Signed-off-by: Maxime Ripard 
---
 configs/Sinlinx_SinA33_defconfig | 4 
 1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig
index f4719db2d501..26b119a9b92f 100644
--- a/configs/Sinlinx_SinA33_defconfig
+++ b/configs/Sinlinx_SinA33_defconfig
@@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291
 CONFIG_MMC0_CD_PIN="PB4"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_USB0_ID_DET="PH8"
+CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0"
+CONFIG_VIDEO_LCD_DCLK_PHASE=0
+CONFIG_VIDEO_LCD_BL_EN="PH6"
+CONFIG_VIDEO_LCD_BL_PWM="PH0"
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL=y
-- 
git-series 0.8.11
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot