Re: [U-Boot] [PATCH 4/5] env: Add support for UBI environment

2013-02-11 Thread Stefan Roese
On 02/08/2013 09:07 PM, Joe Hershberger wrote:
 UBI is a better place for the environment on NAND devices because it
 handles wear-leveling and bad blocks.
 
 Gluebi is needed in Linux to access the env as an MTD partition.
 
 Signed-off-by: Joe Hershberger joe.hershber...@ni.com

Looks good:

Acked-by: Stefan Roese s...@denx.de

Thanks,
Stefan

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 4/5] env: Add support for UBI environment

2013-02-08 Thread Joe Hershberger
UBI is a better place for the environment on NAND devices because it
handles wear-leveling and bad blocks.

Gluebi is needed in Linux to access the env as an MTD partition.

Signed-off-by: Joe Hershberger joe.hershber...@ni.com
---
 README|  15 
 common/Makefile   |   1 +
 common/cmd_nvedit.c   |   3 +-
 common/env_ubi.c  | 103 ++
 include/environment.h |  15 
 tools/env/fw_env.c|   3 +-
 6 files changed, 138 insertions(+), 2 deletions(-)
 create mode 100644 common/env_ubi.c

diff --git a/README b/README
index 2352e38..c46ca3a 100644
--- a/README
+++ b/README
@@ -3442,6 +3442,21 @@ but it can not erase, write this NOR flash by SRIO or 
PCIE interface.
environment. If redundant environment is used, it will be copied to
CONFIG_NAND_ENV_DST + CONFIG_ENV_SIZE.
 
+- CONFIG_ENV_IS_IN_UBI:
+
+   Define this if you have an UBI volume that you want to use for the
+   environment.  This has the benefit of wear-leveling the environment
+   accesses, which is important on NAND.
+
+   - CONFIG_ENV_UBI_PART:
+
+ Define this to a string that is the mtd partition containing the UBI.
+
+   - CONFIG_ENV_UBI_VOLUME:
+
+ Define this to the name of the volume that you want to store the
+ environment in.
+
 - CONFIG_SYS_SPI_INIT_OFFSET
 
Defines offset to the initial SPI buffer area in DPRAM. The
diff --git a/common/Makefile b/common/Makefile
index 54fcc81..9ff59c5 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -62,6 +62,7 @@ COBJS-$(CONFIG_ENV_IS_IN_NVRAM) += env_nvram.o
 COBJS-$(CONFIG_ENV_IS_IN_ONENAND) += env_onenand.o
 COBJS-$(CONFIG_ENV_IS_IN_SPI_FLASH) += env_sf.o
 COBJS-$(CONFIG_ENV_IS_IN_REMOTE) += env_remote.o
+COBJS-$(CONFIG_ENV_IS_IN_UBI) += env_ubi.o
 COBJS-$(CONFIG_ENV_IS_NOWHERE) += env_nowhere.o
 
 # command
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index c7c6440..960b22c 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -62,9 +62,10 @@ DECLARE_GLOBAL_DATA_PTR;
!defined(CONFIG_ENV_IS_IN_ONENAND)   \
!defined(CONFIG_ENV_IS_IN_SPI_FLASH) \
!defined(CONFIG_ENV_IS_IN_REMOTE)\
+   !defined(CONFIG_ENV_IS_IN_UBI)   \
!defined(CONFIG_ENV_IS_NOWHERE)
 # error Define one of CONFIG_ENV_IS_IN_{EEPROM|FLASH|DATAFLASH|ONENAND|\
-SPI_FLASH|NVRAM|MMC|FAT|REMOTE} or CONFIG_ENV_IS_NOWHERE
+SPI_FLASH|NVRAM|MMC|FAT|REMOTE|UBI} or CONFIG_ENV_IS_NOWHERE
 #endif
 
 /*
diff --git a/common/env_ubi.c b/common/env_ubi.c
new file mode 100644
index 000..9a47fd2
--- /dev/null
+++ b/common/env_ubi.c
@@ -0,0 +1,103 @@
+/*
+ * (c) Copyright 2012 by National Instruments,
+ *Joe Hershberger joe.hershber...@ni.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+
+#include command.h
+#include environment.h
+#include errno.h
+#include malloc.h
+#include search.h
+#include ubi_uboot.h
+#undef crc32
+
+char *env_name_spec = UBI;
+
+env_t *env_ptr;
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int env_init(void)
+{
+   /* use default */
+   gd-env_addr = (ulong)default_environment[0];
+   gd-env_valid = 1;
+
+   return 0;
+}
+
+#ifdef CONFIG_CMD_SAVEENV
+int saveenv(void)
+{
+   ALLOC_CACHE_ALIGN_BUFFER(env_t, env_new, 1);
+   ssize_t len;
+   char *res;
+
+   res = (char *)env_new-data;
+   len = hexport_r(env_htab, '\0', 0, res, ENV_SIZE, 0, NULL);
+   if (len  0) {
+   error(Cannot export environment: errno = %d\n, errno);
+   return 1;
+   }
+
+   if (ubi_part(CONFIG_ENV_UBI_PART, NULL)) {
+   printf(\n** Cannot find mtd partition \%s\\n,
+   CONFIG_ENV_UBI_PART);
+   return 1;
+   }
+
+   env_new-crc = crc32(0, env_new-data, ENV_SIZE);
+
+   if (ubi_volume_write(CONFIG_ENV_UBI_VOLUME, (void *)env_new,
+   CONFIG_ENV_SIZE)) {
+   printf(\n** Unable to write env to %s:%s **\n,
+   CONFIG_ENV_UBI_PART, CONFIG_ENV_UBI_VOLUME);
+   return 1;
+   }
+
+   puts(done\n);
+   return 0;
+}
+#endif /* CONFIG_CMD_SAVEENV */
+
+void