Re: [U-Boot] [PATCH 4/6] Kconfig: tegra: Migrate USB_EHCI_TEGRA
On Mon, 2018-09-17 at 15:51 +0200, Marcel Ziswiler wrote: > On Sun, 2018-09-16 at 18:23 +0100, Peter Robinson wrote: > > Migrate USB_EHCI_TEGRA from headers to Kconfig > > > > Signed-off-by: Peter Robinson > > Cc: Tom Warren > > Cc: Stephen Warren > > Cc: Marek Vasut > > Cc: Marcel Ziswiler > > Cc: peter.ch...@data61.csiro.au > > Cc: Lucas Stach > > Cc: Stefan Agner > > Cc: Alban Bedel > > Cc: Allen Martin > > Looks fine to me. > > Reviewed-by: Marcel Ziswiler > > BTW: I was wondering whether the following handling should not also > better be moved into its Kconfig: > > https://git.denx.de/?p=u-boot.git;a=blob;f=include/configs/tegra-comm > on > -post.h;h=e54428ba43e202acdd8a363874c1bbd4f4feb65b;hb=HEAD#l108 Sorry, of course I meant this one: https://git.denx.de/?p=u-boot.git;a=blob;f=include/configs/tegra-common -post.h;h=e54428ba43e202acdd8a363874c1bbd4f4feb65b;hb=HEAD#l113 > > --- > > configs/apalis-tk1_defconfig | 1 + > > configs/apalis_t30_defconfig | 1 + > > configs/beaver_defconfig | 1 + > > configs/cardhu_defconfig | 1 + > > configs/cei-tk1-som_defconfig | 1 + > > configs/colibri_t20_defconfig | 1 + > > configs/colibri_t30_defconfig | 1 + > > configs/dalmore_defconfig | 1 + > > configs/e2220-1170_defconfig | 1 + > > configs/harmony_defconfig | 1 + > > configs/jetson-tk1_defconfig | 1 + > > configs/medcom-wide_defconfig | 1 + > > configs/nyan-big_defconfig| 1 + > > configs/p2371-_defconfig | 1 + > > configs/p2371-2180_defconfig | 1 + > > configs/p2571_defconfig | 1 + > > configs/paz00_defconfig | 1 + > > configs/plutux_defconfig | 1 + > > configs/seaboard_defconfig| 1 + > > configs/tec-ng_defconfig | 1 + > > configs/tec_defconfig | 1 + > > configs/trimslice_defconfig | 1 + > > configs/venice2_defconfig | 1 + > > configs/ventana_defconfig | 1 + > > drivers/usb/host/Kconfig | 6 ++ > > include/configs/apalis-tk1.h | 3 --- > > include/configs/apalis_t30.h | 3 --- > > include/configs/beaver.h | 3 --- > > include/configs/cardhu.h | 3 --- > > include/configs/cei-tk1-som.h | 3 --- > > include/configs/colibri_t20.h | 4 > > include/configs/colibri_t30.h | 3 --- > > include/configs/dalmore.h | 3 --- > > include/configs/e2220-1170.h | 3 --- > > include/configs/harmony.h | 3 --- > > include/configs/jetson-tk1.h | 3 --- > > include/configs/medcom-wide.h | 3 --- > > include/configs/nyan-big.h| 3 --- > > include/configs/p2371-.h | 3 --- > > include/configs/p2371-2180.h | 3 --- > > include/configs/p2571.h | 3 --- > > include/configs/paz00.h | 3 --- > > include/configs/plutux.h | 3 --- > > include/configs/seaboard.h| 3 --- > > include/configs/tec-ng.h | 3 --- > > include/configs/tec.h | 3 --- > > include/configs/trimslice.h | 3 --- > > include/configs/venice2.h | 3 --- > > include/configs/ventana.h | 3 --- > > scripts/config_whitelist.txt | 1 - > > 50 files changed, 30 insertions(+), 74 deletions(-) > > > > diff --git a/configs/apalis-tk1_defconfig b/configs/apalis- > > tk1_defconfig > > index ca5ded8e946..10eb006ce58 100644 > > --- a/configs/apalis-tk1_defconfig > > +++ b/configs/apalis-tk1_defconfig > > @@ -47,6 +47,7 @@ CONFIG_SYS_NS16550=y > > CONFIG_USB=y > > CONFIG_DM_USB=y > > CONFIG_USB_EHCI_HCD=y > > +CONFIG_USB_EHCI_TEGRA=y > > CONFIG_USB_STORAGE=y > > CONFIG_USB_GADGET=y > > CONFIG_USB_GADGET_MANUFACTURER="Toradex" > > diff --git a/configs/apalis_t30_defconfig > > b/configs/apalis_t30_defconfig > > index 05b1a57ff26..ac2fbc75ce7 100644 > > --- a/configs/apalis_t30_defconfig > > +++ b/configs/apalis_t30_defconfig > > @@ -39,6 +39,7 @@ CONFIG_SYS_NS16550=y > > CONFIG_USB=y > > CONFIG_DM_USB=y > > CONFIG_USB_EHCI_HCD=y > > +CONFIG_USB_EHCI_TEGRA=y > > CONFIG_USB_STORAGE=y > > CONFIG_USB_GADGET=y > > CONFIG_USB_GADGET_MANUFACTURER="Toradex" > > diff --git a/configs/beaver_defconfig b/configs/beaver_defconfig > > index d8513a0b8c8..8bf033ed4a7 100644 > > --- a/configs/beaver_defconfig > > +++ b/configs/beaver_defconfig > > @@ -43,6 +43,7 @@ CONFIG_TEGRA20_SLINK=y > > CONFIG_USB=y > > CONFIG_DM_USB=y > > CONFIG_USB_EHCI_HCD=y > > +CONFIG_USB_EHCI_TEGRA=y > > CONFIG_USB_STORAGE=y > > CONFIG_USB_GADGET=y > > CONFIG_USB_GADGET_MANUFACTURER="NVIDIA" > > diff --git a/configs/cardhu_defconfig b/configs/cardhu_defconfig > > index 545b3ee8db4..ab0c1d886ba 100644 > > --- a/configs/cardhu_defconfig > > +++ b/configs/cardhu_defconfig > > @@ -37,6 +37,7 @@ CONFIG_TEGRA20_SLINK=y > > CONFIG_USB=y > > CONFIG_DM_USB=y > > CONFIG_USB_EHCI_HCD=y > > +CONFIG_USB_EHCI_TEGRA=y > > CONFIG_USB_STORAGE=y > > CONFIG_USB_HOST_ETHER=y > > CONFIG_USB_ETHER_ASIX=y > > diff --git a/configs/cei-tk1-som_defconfig b/configs/cei-tk1- > > som_defconfig > > index 5ea257e778d..cdb8e643480 100644 > > --- a/configs/cei-tk1-som_defconfig > > +++ b/configs/cei-tk1-som_defconfig > > @@ -46,6
Re: [U-Boot] [PATCH 4/6] Kconfig: tegra: Migrate USB_EHCI_TEGRA
On Sun, 2018-09-16 at 18:23 +0100, Peter Robinson wrote: > Migrate USB_EHCI_TEGRA from headers to Kconfig > > Signed-off-by: Peter Robinson > Cc: Tom Warren > Cc: Stephen Warren > Cc: Marek Vasut > Cc: Marcel Ziswiler > Cc: peter.ch...@data61.csiro.au > Cc: Lucas Stach > Cc: Stefan Agner > Cc: Alban Bedel > Cc: Allen Martin Looks fine to me. Reviewed-by: Marcel Ziswiler BTW: I was wondering whether the following handling should not also better be moved into its Kconfig: https://git.denx.de/?p=u-boot.git;a=blob;f=include/configs/tegra-common -post.h;h=e54428ba43e202acdd8a363874c1bbd4f4feb65b;hb=HEAD#l108 > --- > configs/apalis-tk1_defconfig | 1 + > configs/apalis_t30_defconfig | 1 + > configs/beaver_defconfig | 1 + > configs/cardhu_defconfig | 1 + > configs/cei-tk1-som_defconfig | 1 + > configs/colibri_t20_defconfig | 1 + > configs/colibri_t30_defconfig | 1 + > configs/dalmore_defconfig | 1 + > configs/e2220-1170_defconfig | 1 + > configs/harmony_defconfig | 1 + > configs/jetson-tk1_defconfig | 1 + > configs/medcom-wide_defconfig | 1 + > configs/nyan-big_defconfig| 1 + > configs/p2371-_defconfig | 1 + > configs/p2371-2180_defconfig | 1 + > configs/p2571_defconfig | 1 + > configs/paz00_defconfig | 1 + > configs/plutux_defconfig | 1 + > configs/seaboard_defconfig| 1 + > configs/tec-ng_defconfig | 1 + > configs/tec_defconfig | 1 + > configs/trimslice_defconfig | 1 + > configs/venice2_defconfig | 1 + > configs/ventana_defconfig | 1 + > drivers/usb/host/Kconfig | 6 ++ > include/configs/apalis-tk1.h | 3 --- > include/configs/apalis_t30.h | 3 --- > include/configs/beaver.h | 3 --- > include/configs/cardhu.h | 3 --- > include/configs/cei-tk1-som.h | 3 --- > include/configs/colibri_t20.h | 4 > include/configs/colibri_t30.h | 3 --- > include/configs/dalmore.h | 3 --- > include/configs/e2220-1170.h | 3 --- > include/configs/harmony.h | 3 --- > include/configs/jetson-tk1.h | 3 --- > include/configs/medcom-wide.h | 3 --- > include/configs/nyan-big.h| 3 --- > include/configs/p2371-.h | 3 --- > include/configs/p2371-2180.h | 3 --- > include/configs/p2571.h | 3 --- > include/configs/paz00.h | 3 --- > include/configs/plutux.h | 3 --- > include/configs/seaboard.h| 3 --- > include/configs/tec-ng.h | 3 --- > include/configs/tec.h | 3 --- > include/configs/trimslice.h | 3 --- > include/configs/venice2.h | 3 --- > include/configs/ventana.h | 3 --- > scripts/config_whitelist.txt | 1 - > 50 files changed, 30 insertions(+), 74 deletions(-) > > diff --git a/configs/apalis-tk1_defconfig b/configs/apalis- > tk1_defconfig > index ca5ded8e946..10eb006ce58 100644 > --- a/configs/apalis-tk1_defconfig > +++ b/configs/apalis-tk1_defconfig > @@ -47,6 +47,7 @@ CONFIG_SYS_NS16550=y > CONFIG_USB=y > CONFIG_DM_USB=y > CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_EHCI_TEGRA=y > CONFIG_USB_STORAGE=y > CONFIG_USB_GADGET=y > CONFIG_USB_GADGET_MANUFACTURER="Toradex" > diff --git a/configs/apalis_t30_defconfig > b/configs/apalis_t30_defconfig > index 05b1a57ff26..ac2fbc75ce7 100644 > --- a/configs/apalis_t30_defconfig > +++ b/configs/apalis_t30_defconfig > @@ -39,6 +39,7 @@ CONFIG_SYS_NS16550=y > CONFIG_USB=y > CONFIG_DM_USB=y > CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_EHCI_TEGRA=y > CONFIG_USB_STORAGE=y > CONFIG_USB_GADGET=y > CONFIG_USB_GADGET_MANUFACTURER="Toradex" > diff --git a/configs/beaver_defconfig b/configs/beaver_defconfig > index d8513a0b8c8..8bf033ed4a7 100644 > --- a/configs/beaver_defconfig > +++ b/configs/beaver_defconfig > @@ -43,6 +43,7 @@ CONFIG_TEGRA20_SLINK=y > CONFIG_USB=y > CONFIG_DM_USB=y > CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_EHCI_TEGRA=y > CONFIG_USB_STORAGE=y > CONFIG_USB_GADGET=y > CONFIG_USB_GADGET_MANUFACTURER="NVIDIA" > diff --git a/configs/cardhu_defconfig b/configs/cardhu_defconfig > index 545b3ee8db4..ab0c1d886ba 100644 > --- a/configs/cardhu_defconfig > +++ b/configs/cardhu_defconfig > @@ -37,6 +37,7 @@ CONFIG_TEGRA20_SLINK=y > CONFIG_USB=y > CONFIG_DM_USB=y > CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_EHCI_TEGRA=y > CONFIG_USB_STORAGE=y > CONFIG_USB_HOST_ETHER=y > CONFIG_USB_ETHER_ASIX=y > diff --git a/configs/cei-tk1-som_defconfig b/configs/cei-tk1- > som_defconfig > index 5ea257e778d..cdb8e643480 100644 > --- a/configs/cei-tk1-som_defconfig > +++ b/configs/cei-tk1-som_defconfig > @@ -46,6 +46,7 @@ CONFIG_TEGRA114_SPI=y > CONFIG_USB=y > CONFIG_DM_USB=y > CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_EHCI_TEGRA=y > CONFIG_USB_STORAGE=y > CONFIG_USB_GADGET=y > CONFIG_USB_GADGET_MANUFACTURER="NVIDIA" > diff --git a/configs/colibri_t20_defconfig > b/configs/colibri_t20_defconfig > index 496f4be0238..92d426a9927 100644 > --- a/configs/colibri_t20_defconfig > +++ b/configs/colibri_t20_defconfig > @@ -47,6 +47,7 @@ CONFIG_SYS_NS16550=y > CONFIG_USB=y > CONFIG_DM_USB=y >
[U-Boot] [PATCH 4/6] Kconfig: tegra: Migrate USB_EHCI_TEGRA
Migrate USB_EHCI_TEGRA from headers to Kconfig Signed-off-by: Peter Robinson Cc: Tom Warren Cc: Stephen Warren Cc: Marek Vasut Cc: Marcel Ziswiler Cc: peter.ch...@data61.csiro.au Cc: Lucas Stach Cc: Stefan Agner Cc: Alban Bedel Cc: Allen Martin --- configs/apalis-tk1_defconfig | 1 + configs/apalis_t30_defconfig | 1 + configs/beaver_defconfig | 1 + configs/cardhu_defconfig | 1 + configs/cei-tk1-som_defconfig | 1 + configs/colibri_t20_defconfig | 1 + configs/colibri_t30_defconfig | 1 + configs/dalmore_defconfig | 1 + configs/e2220-1170_defconfig | 1 + configs/harmony_defconfig | 1 + configs/jetson-tk1_defconfig | 1 + configs/medcom-wide_defconfig | 1 + configs/nyan-big_defconfig| 1 + configs/p2371-_defconfig | 1 + configs/p2371-2180_defconfig | 1 + configs/p2571_defconfig | 1 + configs/paz00_defconfig | 1 + configs/plutux_defconfig | 1 + configs/seaboard_defconfig| 1 + configs/tec-ng_defconfig | 1 + configs/tec_defconfig | 1 + configs/trimslice_defconfig | 1 + configs/venice2_defconfig | 1 + configs/ventana_defconfig | 1 + drivers/usb/host/Kconfig | 6 ++ include/configs/apalis-tk1.h | 3 --- include/configs/apalis_t30.h | 3 --- include/configs/beaver.h | 3 --- include/configs/cardhu.h | 3 --- include/configs/cei-tk1-som.h | 3 --- include/configs/colibri_t20.h | 4 include/configs/colibri_t30.h | 3 --- include/configs/dalmore.h | 3 --- include/configs/e2220-1170.h | 3 --- include/configs/harmony.h | 3 --- include/configs/jetson-tk1.h | 3 --- include/configs/medcom-wide.h | 3 --- include/configs/nyan-big.h| 3 --- include/configs/p2371-.h | 3 --- include/configs/p2371-2180.h | 3 --- include/configs/p2571.h | 3 --- include/configs/paz00.h | 3 --- include/configs/plutux.h | 3 --- include/configs/seaboard.h| 3 --- include/configs/tec-ng.h | 3 --- include/configs/tec.h | 3 --- include/configs/trimslice.h | 3 --- include/configs/venice2.h | 3 --- include/configs/ventana.h | 3 --- scripts/config_whitelist.txt | 1 - 50 files changed, 30 insertions(+), 74 deletions(-) diff --git a/configs/apalis-tk1_defconfig b/configs/apalis-tk1_defconfig index ca5ded8e946..10eb006ce58 100644 --- a/configs/apalis-tk1_defconfig +++ b/configs/apalis-tk1_defconfig @@ -47,6 +47,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="Toradex" diff --git a/configs/apalis_t30_defconfig b/configs/apalis_t30_defconfig index 05b1a57ff26..ac2fbc75ce7 100644 --- a/configs/apalis_t30_defconfig +++ b/configs/apalis_t30_defconfig @@ -39,6 +39,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="Toradex" diff --git a/configs/beaver_defconfig b/configs/beaver_defconfig index d8513a0b8c8..8bf033ed4a7 100644 --- a/configs/beaver_defconfig +++ b/configs/beaver_defconfig @@ -43,6 +43,7 @@ CONFIG_TEGRA20_SLINK=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="NVIDIA" diff --git a/configs/cardhu_defconfig b/configs/cardhu_defconfig index 545b3ee8db4..ab0c1d886ba 100644 --- a/configs/cardhu_defconfig +++ b/configs/cardhu_defconfig @@ -37,6 +37,7 @@ CONFIG_TEGRA20_SLINK=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y CONFIG_USB_STORAGE=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y diff --git a/configs/cei-tk1-som_defconfig b/configs/cei-tk1-som_defconfig index 5ea257e778d..cdb8e643480 100644 --- a/configs/cei-tk1-som_defconfig +++ b/configs/cei-tk1-som_defconfig @@ -46,6 +46,7 @@ CONFIG_TEGRA114_SPI=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="NVIDIA" diff --git a/configs/colibri_t20_defconfig b/configs/colibri_t20_defconfig index 496f4be0238..92d426a9927 100644 --- a/configs/colibri_t20_defconfig +++ b/configs/colibri_t20_defconfig @@ -47,6 +47,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y CONFIG_USB_ULPI_VIEWPORT=y CONFIG_USB_ULPI=y CONFIG_USB_STORAGE=y diff --git a/configs/colibri_t30_defconfig b/configs/colibri_t30_defconfig index 07f34359d1d..e56157a4ca2 100644 --- a/configs/colibri_t30_defconfig +++ b/configs/colibri_t30_defconfig @@ -33,6 +33,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="Toradex" diff --git a/configs/dalmore_defconfig b/configs/dalmore_defconfig index f07dc020786..43bb6c3f616 100644 --- a/configs/dalmore_defconfig
