Re: [U-Boot] [PATCH 5/8] video/console: Factor out actual character output

2019-04-09 Thread Anatolij Gustschin
On Sat, 23 Mar 2019 01:29:59 +
Andre Przywara andre.przyw...@arm.com wrote:

> In preparation for doing character set translations, factor out the
> actual glyph display functionality into a separate function.
> This will be used in a subsequent patch.
> 
> Signed-off-by: Andre Przywara 
> ---
>  drivers/video/vidconsole-uclass.c | 42 
> +--
>  1 file changed, 27 insertions(+), 15 deletions(-)

Applied to u-boot-video/master, thanks!

--
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 5/8] video/console: Factor out actual character output

2019-03-30 Thread Simon Glass
On Fri, 22 Mar 2019 at 19:32, Andre Przywara  wrote:
>
> In preparation for doing character set translations, factor out the
> actual glyph display functionality into a separate function.
> This will be used in a subsequent patch.
>
> Signed-off-by: Andre Przywara 
> ---
>  drivers/video/vidconsole-uclass.c | 42 
> +--
>  1 file changed, 27 insertions(+), 15 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 5/8] video/console: Factor out actual character output

2019-03-22 Thread Andre Przywara
In preparation for doing character set translations, factor out the
actual glyph display functionality into a separate function.
This will be used in a subsequent patch.

Signed-off-by: Andre Przywara 
---
 drivers/video/vidconsole-uclass.c | 42 +--
 1 file changed, 27 insertions(+), 15 deletions(-)

diff --git a/drivers/video/vidconsole-uclass.c 
b/drivers/video/vidconsole-uclass.c
index 7d914ed5ca..e16567029a 100644
--- a/drivers/video/vidconsole-uclass.c
+++ b/drivers/video/vidconsole-uclass.c
@@ -457,6 +457,32 @@ error:
priv->escape = 0;
 }
 
+/* Put that actual character on the screen (using the CP437 code page). */
+static int vidconsole_output_glyph(struct udevice *dev, char ch)
+{
+   struct vidconsole_priv *priv = dev_get_uclass_priv(dev);
+   int ret;
+
+   /*
+* Failure of this function normally indicates an unsupported
+* colour depth. Check this and return an error to help with
+* diagnosis.
+*/
+   ret = vidconsole_putc_xy(dev, priv->xcur_frac, priv->ycur, ch);
+   if (ret == -EAGAIN) {
+   vidconsole_newline(dev);
+   ret = vidconsole_putc_xy(dev, priv->xcur_frac, priv->ycur, ch);
+   }
+   if (ret < 0)
+   return ret;
+   priv->xcur_frac += ret;
+   priv->last_ch = ch;
+   if (priv->xcur_frac >= priv->xsize_frac)
+   vidconsole_newline(dev);
+
+   return 0;
+}
+
 int vidconsole_put_char(struct udevice *dev, char ch)
 {
struct vidconsole_priv *priv = dev_get_uclass_priv(dev);
@@ -494,23 +520,9 @@ int vidconsole_put_char(struct udevice *dev, char ch)
priv->last_ch = 0;
break;
default:
-   /*
-* Failure of this function normally indicates an unsupported
-* colour depth. Check this and return an error to help with
-* diagnosis.
-*/
-   ret = vidconsole_putc_xy(dev, priv->xcur_frac, priv->ycur, ch);
-   if (ret == -EAGAIN) {
-   vidconsole_newline(dev);
-   ret = vidconsole_putc_xy(dev, priv->xcur_frac,
-priv->ycur, ch);
-   }
+   ret = vidconsole_output_glyph(dev, ch);
if (ret < 0)
return ret;
-   priv->xcur_frac += ret;
-   priv->last_ch = ch;
-   if (priv->xcur_frac >= priv->xsize_frac)
-   vidconsole_newline(dev);
break;
}
 
-- 
2.14.5

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot