Re: [U-Boot] [PATCH 6/8] configs: Add NAND support for NES Classic

[Maxime Ripard]

Hi,

On Wed, Jan 24, 2018 at 01:44:52AM +0100, Miquel Raynal wrote:
> Add NAND parameters to the Nintendo NES Classic configuration file.
> 
> Signed-off-by: Miquel Raynal 
> ---
>  configs/Nintendo_NES_Classic_Edition_defconfig | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/configs/Nintendo_NES_Classic_Edition_defconfig 
> b/configs/Nintendo_NES_Classic_Edition_defconfig
> index d05375d0db..467055279c 100644
> --- a/configs/Nintendo_NES_Classic_Edition_defconfig
> +++ b/configs/Nintendo_NES_Classic_Edition_defconfig
> @@ -9,6 +9,10 @@ CONFIG_AXP_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="sun8i-r16-nintendo-nes-classic-edition"
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_SPL=y
> +CONFIG_SPL_NAND_SUPPORT=y

This could be selected (or implied) by NAND_SUNXI

> +CONFIG_SYS_EXTRA_OPTIONS="SYS_NAND_BLOCK_SIZE=0x2,SYS_NAND_PAGE_SIZE=2048,SYS_NAND_OOBSIZE=64"

Can you move this to Kconfig?

> +CONFIG_NAND=y
> +CONFIG_NAND_SUNXI=y

And we can add a default ARCH_SUNXI on NAND_SUNXI here, which means
that we'd only have the NAND parameters and the CONFIG_NAND in
defconfig, reducing the boilerplate.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 6/8] configs: Add NAND support for NES Classic

[Miquel Raynal]

Add NAND parameters to the Nintendo NES Classic configuration file.

Signed-off-by: Miquel Raynal 
---
 configs/Nintendo_NES_Classic_Edition_defconfig | 4 
 1 file changed, 4 insertions(+)

diff --git a/configs/Nintendo_NES_Classic_Edition_defconfig 
b/configs/Nintendo_NES_Classic_Edition_defconfig
index d05375d0db..467055279c 100644
--- a/configs/Nintendo_NES_Classic_Edition_defconfig
+++ b/configs/Nintendo_NES_Classic_Edition_defconfig
@@ -9,6 +9,10 @@ CONFIG_AXP_GPIO=y
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-r16-nintendo-nes-classic-edition"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL=y
+CONFIG_SPL_NAND_SUPPORT=y
+CONFIG_SYS_EXTRA_OPTIONS="SYS_NAND_BLOCK_SIZE=0x2,SYS_NAND_PAGE_SIZE=2048,SYS_NAND_OOBSIZE=64"
+CONFIG_NAND=y
+CONFIG_NAND_SUNXI=y
 CONFIG_FASTBOOT_FLASH=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot