Re: [U-Boot] [PATCH V7] mcx: support for HTKW mcx board

2012-02-06 Thread Igor Grinberg
Hi Stefano,

Cc'd Govindraj.

On 02/05/12 16:57, Stefano Babic wrote:
 From: Ilya Yanok ya...@emcraft.com
 
 This patch adds support for the HTKW mcx AM3517-based board.
 Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both
 NAND and MMC SPLs are supported.
 
 Signed-off-by: Ilya Yanok ya...@emcraft.com
 Signed-off-by: Stefano Babic sba...@denx.de
 CC: Tom Rini tom.r...@gmail.com
 Cc: Detlev Zundel d...@denx.de

[...]

 diff --git a/board/htkw/mcx/mcx.c b/board/htkw/mcx/mcx.c
 new file mode 100644
 index 000..dcc8707
 --- /dev/null
 +++ b/board/htkw/mcx/mcx.c

[...]

 +#ifdef CONFIG_USB_EHCI
 +static struct omap_usbhs_board_data usbhs_bdata = {
 + .port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
 + .port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
 + .port_mode[2] = OMAP_EHCI_PORT_MODE_PHY,

This looks wrong, as port3 is TLL only, so it cannot have a PHY,
or am I missing something?

 +};
 +
 +int ehci_hcd_init(void)
 +{
 + int ret;
 +
 + ret = omap_ehci_hcd_init(usbhs_bdata);
 + if (ret  0)
 + return ret;
 +
 + return 0;
 +}

return omap_ehci_hcd_init(usbhs_bdata);
?

 +
 +int ehci_hcd_stop(void)
 +{
 + int ret;
 +
 + ret = omap_ehci_hcd_stop();
 + return ret;
 +}

same here:
return omap_ehci_hcd_stop();
?

[...]


-- 
Regards,
Igor.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH V7] mcx: support for HTKW mcx board

2012-02-05 Thread Stefano Babic
From: Ilya Yanok ya...@emcraft.com

This patch adds support for the HTKW mcx AM3517-based board.
Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both
NAND and MMC SPLs are supported.

Signed-off-by: Ilya Yanok ya...@emcraft.com
Signed-off-by: Stefano Babic sba...@denx.de
CC: Tom Rini tom.r...@gmail.com
Cc: Detlev Zundel d...@denx.de
---
Changes from V6:
- rebased on current u-boot-ti
- applied and tested on top of EHCI Gavindraj's patches
- uses ULPI framework

Changes from V5
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/120254

 - added comments on CONFIG_SYS_TEXT_BASE and SPL_{MALLOC,BSS}

Changes from V4
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/120148

 - board_mmc_init return value fixed
 - machine id added locally
 - CONFIG_SYS_NAND_U_BOOT_SIZE removed

Changes from V3
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/118530

 - Comment for misc_init_r function fixed
 - Added check for gpio_request return value.
 - Removed #if defined(CONFIG_GENERIC_MMC) around board_mmc_init
 - CONFIG_USE_IRQ and related stuff removed from config
 - CONFIG_OMAP3_MICRON_DDR removed
 - CONFIG_SYS_MAXRAGS changed 32 - 16
 - Incorrect multiline comments (/*--- ones) fixed
 - CONFIG_SPL_MAX_SIZE rewritten 0xB400 - (45  10)
 - CONFIG_SPL_NAND_WORKSPACE removed

Changes from V2
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/116548

 - None

Changes from V1
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/115026

 - Calls to gpio_set_value after gpio_direction_output removed
 - Minor style problem (tab instead of space) fixed

SPL series:
Changes from V1
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/112892

 - OMAP EHCI support enabled in config
 - MMC SPL support enabled in config

DaVinci EMAC and HTKW mcx support series:
Changes from V3
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/112884

 - NAND SPL support enabled in config

Changes from V2
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/112317

 - removed dead code from board/htkw/mcx/Makefile as Mike suggested
 - removed EMAC reset (now done in generic cpu_eth_init())
 - removed some unsuned defines from configuration header

Changes from V1
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/97

 - various style fixes to make checkpatch (almost) happy
 - FSF address removed from GPL comments
 - CONFIG_SYS_TEXT_BASE moved to configuration header, config.mk droped
 - CONFIG_MACH_TYPE is used instead of setting mach type from board code
 - i2c_init removed from misc_init_r
 - cpu_eth_init removed (added to generic place by another patch)
 - CONTROL_PADCONF defines removed
 - Fixed boolean config options not to have a value
 - CONFIG_MUSB_* and related defines removed


 MAINTAINERS |4 +
 board/htkw/mcx/Makefile |   38 +
 board/htkw/mcx/mcx.c|  122 ++
 board/htkw/mcx/mcx.h|  408 +++
 boards.cfg  |1 +
 include/configs/mcx.h   |  378 +++
 6 files changed, 951 insertions(+), 0 deletions(-)
 create mode 100644 board/htkw/mcx/Makefile
 create mode 100644 board/htkw/mcx/mcx.c
 create mode 100644 board/htkw/mcx/mcx.h
 create mode 100644 include/configs/mcx.h

diff --git a/MAINTAINERS b/MAINTAINERS
index a8e56bb..7e52f50 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -920,6 +920,10 @@ Richard Woodruff r-woodru...@ti.com
 
omap2420h4  ARM1136EJS
 
+Ilya Yanok ya...@emcraft.com
+
+   mcx ARM ARMV7 (AM35x SoC)
+
 Syed Mohammed Khasim sm.kha...@gmail.com
 Sughosh Ganu urwithsugh...@gmail.com
 
diff --git a/board/htkw/mcx/Makefile b/board/htkw/mcx/Makefile
new file mode 100644
index 000..4c8db10
--- /dev/null
+++ b/board/htkw/mcx/Makefile
@@ -0,0 +1,38 @@
+#
+# Copyright (C) 2011 Ilya Yanok, Emcraft Systems
+#
+# Based on ti/evm/Makefile
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc.
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).o
+
+COBJS  := $(BOARD).o
+
+SRCS   := $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+
+$(LIB):$(obj).depend $(OBJS)
+   $(call cmd_link_o_target, $(OBJS))
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
diff --git a/board/htkw/mcx/mcx.c