Re: [U-Boot] [PATCH u-boot 1/2] arm: Add LibreTech CC support based on Meson GXL family

[Neil Armstrong]

Hi Simon,

On 21/11/2017 05:08, Simon Glass wrote:
> Hi Neil,
> 
> On 20 November 2017 at 08:04, Neil Armstrong  wrote:
>> This adds platform code for the Libre Computer CC "Le Potato" board based on 
>> a
>> Meson GXL (S905X) SoC with the Meson GXL configuration.
>>
>> This initial submission supports UART, MMC/SDCard and Ethernet with the
>> Internal RMII PHY.
>>
>> The meson-gxl-s905x-libretech-cc.dts is synchronised from the linux 4.13
>> stable tree as of 4.13.8.
>>
>> Signed-off-by: Neil Armstrong 
>> ---
>>  arch/arm/dts/Makefile |   3 +-
>>  arch/arm/dts/meson-gxl-s905x-libretech-cc.dts | 171 
>> ++
>>  arch/arm/mach-meson/Kconfig   |   9 ++
>>  board/amlogic/libretech-cc/Kconfig|  12 ++
>>  board/amlogic/libretech-cc/MAINTAINERS|   6 +
>>  board/amlogic/libretech-cc/Makefile   |   8 ++
>>  board/amlogic/libretech-cc/README |  96 +++
>>  board/amlogic/libretech-cc/libretech-cc.c |  58 +
>>  configs/libretech-cc_defconfig|  35 ++
>>  include/configs/libretech-cc.h|  24 
>>  10 files changed, 421 insertions(+), 1 deletion(-)
>>  create mode 100644 arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
>>  create mode 100644 board/amlogic/libretech-cc/Kconfig
>>  create mode 100644 board/amlogic/libretech-cc/MAINTAINERS
>>  create mode 100644 board/amlogic/libretech-cc/Makefile
>>  create mode 100644 board/amlogic/libretech-cc/README
>>  create mode 100644 board/amlogic/libretech-cc/libretech-cc.c
>>  create mode 100644 configs/libretech-cc_defconfig
>>  create mode 100644 include/configs/libretech-cc.h
> 
> Reviewed-by: Simon Glass 
> 
> Please see below.
> 
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index cd540e9..1845552 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -55,7 +55,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
>> rv1108-evb.dtb
>>  dtb-$(CONFIG_ARCH_MESON) += \
>> meson-gxbb-odroidc2.dtb \
>> -   meson-gxl-s905x-p212.dtb
>> +   meson-gxl-s905x-p212.dtb \
>> +   meson-gxl-s905x-libretech-cc.dtb
>>  dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
>> tegra20-medcom-wide.dtb \
>> tegra20-paz00.dtb \
>> diff --git a/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts 
>> b/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
>> new file mode 100644
>> index 000..266fbcf
>> --- /dev/null
>> +++ b/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
>> @@ -0,0 +1,171 @@
>> +/*
>> + * Copyright (c) 2017 BayLibre, SAS.
>> + * Author: Neil Armstrong 
>> + * Author: Jerome Brunet 
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include 
>> +
>> +#include "meson-gxl-s905x.dtsi"
>> +
>> +/ {
>> +   compatible = "libretech,cc", "amlogic,s905x", "amlogic,meson-gxl";
>> +   model = "Libre Technology CC";
>> +
>> +   aliases {
>> +   serial0 = _AO;
>> +   };
>> +
>> +   chosen {
>> +   stdout-path = "serial0:115200n8";
>> +   };
>> +
>> +   cvbs-connector {
>> +   compatible = "composite-video-connector";
>> +
>> +   port {
>> +   cvbs_connector_in: endpoint {
>> +   remote-endpoint = <_vdac_out>;
>> +   };
>> +   };
>> +   };
>> +
>> +   emmc_pwrseq: emmc-pwrseq {
>> +   compatible = "mmc-pwrseq-emmc";
>> +   reset-gpios = < BOOT_9 GPIO_ACTIVE_LOW>;
>> +   };
>> +
>> +   hdmi-connector {
>> +   compatible = "hdmi-connector";
>> +   type = "a";
>> +
>> +   port {
>> +   hdmi_connector_in: endpoint {
>> +   remote-endpoint = <_tx_tmds_out>;
>> +   };
>> +   };
>> +   };
>> +
>> +   leds {
>> +   compatible = "gpio-leds";
>> +
>> +   system {
>> +   label = "librecomputer:system-status";
>> +   gpios = < GPIODV_24 GPIO_ACTIVE_HIGH>;
>> +   default-state = "on";
>> +   panic-indicator;
>> +   };
>> +
>> +   blue {
>> +   label = "librecomputer:blue";
>> +   gpios = <_ao GPIOAO_2 GPIO_ACTIVE_HIGH>;
>> +   linux,default-trigger = "heartbeat";
>> +   };
>> +   };
>> +
>> +   memory@0 {
>> +   device_type = "memory";
>> +   reg = <0x0 0x0 0x0 0x8000>;
>> +   };
>> +
>> +   vcc_3v3: regulator-vcc_3v3 {
>> +   compatible = "regulator-fixed";
>> +   regulator-name = "VCC_3V3";
>> +   regulator-min-microvolt = <330>;
>> +   

Re: [U-Boot] [PATCH u-boot 1/2] arm: Add LibreTech CC support based on Meson GXL family

[Simon Glass]

Hi Neil,

On 20 November 2017 at 08:04, Neil Armstrong  wrote:
> This adds platform code for the Libre Computer CC "Le Potato" board based on a
> Meson GXL (S905X) SoC with the Meson GXL configuration.
>
> This initial submission supports UART, MMC/SDCard and Ethernet with the
> Internal RMII PHY.
>
> The meson-gxl-s905x-libretech-cc.dts is synchronised from the linux 4.13
> stable tree as of 4.13.8.
>
> Signed-off-by: Neil Armstrong 
> ---
>  arch/arm/dts/Makefile |   3 +-
>  arch/arm/dts/meson-gxl-s905x-libretech-cc.dts | 171 
> ++
>  arch/arm/mach-meson/Kconfig   |   9 ++
>  board/amlogic/libretech-cc/Kconfig|  12 ++
>  board/amlogic/libretech-cc/MAINTAINERS|   6 +
>  board/amlogic/libretech-cc/Makefile   |   8 ++
>  board/amlogic/libretech-cc/README |  96 +++
>  board/amlogic/libretech-cc/libretech-cc.c |  58 +
>  configs/libretech-cc_defconfig|  35 ++
>  include/configs/libretech-cc.h|  24 
>  10 files changed, 421 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
>  create mode 100644 board/amlogic/libretech-cc/Kconfig
>  create mode 100644 board/amlogic/libretech-cc/MAINTAINERS
>  create mode 100644 board/amlogic/libretech-cc/Makefile
>  create mode 100644 board/amlogic/libretech-cc/README
>  create mode 100644 board/amlogic/libretech-cc/libretech-cc.c
>  create mode 100644 configs/libretech-cc_defconfig
>  create mode 100644 include/configs/libretech-cc.h

Reviewed-by: Simon Glass 

Please see below.

>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index cd540e9..1845552 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -55,7 +55,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
> rv1108-evb.dtb
>  dtb-$(CONFIG_ARCH_MESON) += \
> meson-gxbb-odroidc2.dtb \
> -   meson-gxl-s905x-p212.dtb
> +   meson-gxl-s905x-p212.dtb \
> +   meson-gxl-s905x-libretech-cc.dtb
>  dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
> tegra20-medcom-wide.dtb \
> tegra20-paz00.dtb \
> diff --git a/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts 
> b/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
> new file mode 100644
> index 000..266fbcf
> --- /dev/null
> +++ b/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
> @@ -0,0 +1,171 @@
> +/*
> + * Copyright (c) 2017 BayLibre, SAS.
> + * Author: Neil Armstrong 
> + * Author: Jerome Brunet 
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + */
> +
> +/dts-v1/;
> +
> +#include 
> +
> +#include "meson-gxl-s905x.dtsi"
> +
> +/ {
> +   compatible = "libretech,cc", "amlogic,s905x", "amlogic,meson-gxl";
> +   model = "Libre Technology CC";
> +
> +   aliases {
> +   serial0 = _AO;
> +   };
> +
> +   chosen {
> +   stdout-path = "serial0:115200n8";
> +   };
> +
> +   cvbs-connector {
> +   compatible = "composite-video-connector";
> +
> +   port {
> +   cvbs_connector_in: endpoint {
> +   remote-endpoint = <_vdac_out>;
> +   };
> +   };
> +   };
> +
> +   emmc_pwrseq: emmc-pwrseq {
> +   compatible = "mmc-pwrseq-emmc";
> +   reset-gpios = < BOOT_9 GPIO_ACTIVE_LOW>;
> +   };
> +
> +   hdmi-connector {
> +   compatible = "hdmi-connector";
> +   type = "a";
> +
> +   port {
> +   hdmi_connector_in: endpoint {
> +   remote-endpoint = <_tx_tmds_out>;
> +   };
> +   };
> +   };
> +
> +   leds {
> +   compatible = "gpio-leds";
> +
> +   system {
> +   label = "librecomputer:system-status";
> +   gpios = < GPIODV_24 GPIO_ACTIVE_HIGH>;
> +   default-state = "on";
> +   panic-indicator;
> +   };
> +
> +   blue {
> +   label = "librecomputer:blue";
> +   gpios = <_ao GPIOAO_2 GPIO_ACTIVE_HIGH>;
> +   linux,default-trigger = "heartbeat";
> +   };
> +   };
> +
> +   memory@0 {
> +   device_type = "memory";
> +   reg = <0x0 0x0 0x0 0x8000>;
> +   };
> +
> +   vcc_3v3: regulator-vcc_3v3 {
> +   compatible = "regulator-fixed";
> +   regulator-name = "VCC_3V3";
> +   regulator-min-microvolt = <330>;
> +   regulator-max-microvolt = <330>;
> +   };
> +
> +   vcc_card: regulator-vcc-card {
> +   compatible = "regulator-gpio";
> +
> +   regulator-name = "VCC_CARD";
> +   

[U-Boot] [PATCH u-boot 1/2] arm: Add LibreTech CC support based on Meson GXL family

[Neil Armstrong]

This adds platform code for the Libre Computer CC "Le Potato" board based on a
Meson GXL (S905X) SoC with the Meson GXL configuration.

This initial submission supports UART, MMC/SDCard and Ethernet with the
Internal RMII PHY.

The meson-gxl-s905x-libretech-cc.dts is synchronised from the linux 4.13
stable tree as of 4.13.8.

Signed-off-by: Neil Armstrong 
---
 arch/arm/dts/Makefile |   3 +-
 arch/arm/dts/meson-gxl-s905x-libretech-cc.dts | 171 ++
 arch/arm/mach-meson/Kconfig   |   9 ++
 board/amlogic/libretech-cc/Kconfig|  12 ++
 board/amlogic/libretech-cc/MAINTAINERS|   6 +
 board/amlogic/libretech-cc/Makefile   |   8 ++
 board/amlogic/libretech-cc/README |  96 +++
 board/amlogic/libretech-cc/libretech-cc.c |  58 +
 configs/libretech-cc_defconfig|  35 ++
 include/configs/libretech-cc.h|  24 
 10 files changed, 421 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
 create mode 100644 board/amlogic/libretech-cc/Kconfig
 create mode 100644 board/amlogic/libretech-cc/MAINTAINERS
 create mode 100644 board/amlogic/libretech-cc/Makefile
 create mode 100644 board/amlogic/libretech-cc/README
 create mode 100644 board/amlogic/libretech-cc/libretech-cc.c
 create mode 100644 configs/libretech-cc_defconfig
 create mode 100644 include/configs/libretech-cc.h

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index cd540e9..1845552 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -55,7 +55,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
rv1108-evb.dtb
 dtb-$(CONFIG_ARCH_MESON) += \
meson-gxbb-odroidc2.dtb \
-   meson-gxl-s905x-p212.dtb
+   meson-gxl-s905x-p212.dtb \
+   meson-gxl-s905x-libretech-cc.dtb
 dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
tegra20-medcom-wide.dtb \
tegra20-paz00.dtb \
diff --git a/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts 
b/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
new file mode 100644
index 000..266fbcf
--- /dev/null
+++ b/arch/arm/dts/meson-gxl-s905x-libretech-cc.dts
@@ -0,0 +1,171 @@
+/*
+ * Copyright (c) 2017 BayLibre, SAS.
+ * Author: Neil Armstrong 
+ * Author: Jerome Brunet 
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ */
+
+/dts-v1/;
+
+#include 
+
+#include "meson-gxl-s905x.dtsi"
+
+/ {
+   compatible = "libretech,cc", "amlogic,s905x", "amlogic,meson-gxl";
+   model = "Libre Technology CC";
+
+   aliases {
+   serial0 = _AO;
+   };
+
+   chosen {
+   stdout-path = "serial0:115200n8";
+   };
+
+   cvbs-connector {
+   compatible = "composite-video-connector";
+
+   port {
+   cvbs_connector_in: endpoint {
+   remote-endpoint = <_vdac_out>;
+   };
+   };
+   };
+
+   emmc_pwrseq: emmc-pwrseq {
+   compatible = "mmc-pwrseq-emmc";
+   reset-gpios = < BOOT_9 GPIO_ACTIVE_LOW>;
+   };
+
+   hdmi-connector {
+   compatible = "hdmi-connector";
+   type = "a";
+
+   port {
+   hdmi_connector_in: endpoint {
+   remote-endpoint = <_tx_tmds_out>;
+   };
+   };
+   };
+
+   leds {
+   compatible = "gpio-leds";
+
+   system {
+   label = "librecomputer:system-status";
+   gpios = < GPIODV_24 GPIO_ACTIVE_HIGH>;
+   default-state = "on";
+   panic-indicator;
+   };
+
+   blue {
+   label = "librecomputer:blue";
+   gpios = <_ao GPIOAO_2 GPIO_ACTIVE_HIGH>;
+   linux,default-trigger = "heartbeat";
+   };
+   };
+
+   memory@0 {
+   device_type = "memory";
+   reg = <0x0 0x0 0x0 0x8000>;
+   };
+
+   vcc_3v3: regulator-vcc_3v3 {
+   compatible = "regulator-fixed";
+   regulator-name = "VCC_3V3";
+   regulator-min-microvolt = <330>;
+   regulator-max-microvolt = <330>;
+   };
+
+   vcc_card: regulator-vcc-card {
+   compatible = "regulator-gpio";
+
+   regulator-name = "VCC_CARD";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <330>;
+
+   gpios = <_ao GPIOAO_3 GPIO_ACTIVE_HIGH>;
+   gpios-states = <0>;
+
+   states = <330 0>,
+<180 1>;
+   };
+
+   vddio_boot: regulator-vddio_boot {
+   compatible = "regulator-fixed";
+   regulator-name = "VDDIO_BOOT";
+