Re: [U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board

[Bin Meng]

Hi Andy,

On Tue, Feb 26, 2019 at 7:21 PM Andy Shevchenko
 wrote:
>
> Intel Edison has three UART ports, i.e.
>  port 0 - Bluetooth
>  port 1 - auxiliary, available for general purpose use
>  port 2 - debugging, usually console output is here
>
> Enable all of them for future use.
>
> Signed-off-by: Andy Shevchenko 
> ---
>  arch/x86/dts/edison.dts | 18 ++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
> index b59171cb50..8629f7bcf2 100644
> --- a/arch/x86/dts/edison.dts
> +++ b/arch/x86/dts/edison.dts
> @@ -17,6 +17,8 @@
> compatible = "intel,edison";
>
> aliases {
> +   serial0 = 
> +   serial1 = 
> serial2 = 
> };
>
> @@ -53,6 +55,22 @@
>   0x0100 0x0 0x2000 0x2000 0 0xe000>;
> };
>
> +   serial0: serial@ff010180 {

The reg base is wrong here, should be @ff010080

> +   compatible = "intel,mid-uart";
> +   reg = <0xff010080 0x100>;
> +   reg-shift = <0>;
> +   clock-frequency = <29491200>;
> +   current-speed = <115200>;
> +   };
> +
> +   serial1: serial@ff010180 {

ditto

> +   compatible = "intel,mid-uart";
> +   reg = <0xff010100 0x100>;
> +   reg-shift = <0>;
> +   clock-frequency = <29491200>;
> +   current-speed = <115200>;
> +   };
> +
> serial2: serial@ff010180 {
> compatible = "intel,mid-uart";
> reg = <0xff010180 0x100>;
> --

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board

[Andy Shevchenko]

Intel Edison has three UART ports, i.e.
 port 0 - Bluetooth
 port 1 - auxiliary, available for general purpose use
 port 2 - debugging, usually console output is here

Enable all of them for future use.

Signed-off-by: Andy Shevchenko 
---
 arch/x86/dts/edison.dts | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
index b59171cb50..8629f7bcf2 100644
--- a/arch/x86/dts/edison.dts
+++ b/arch/x86/dts/edison.dts
@@ -17,6 +17,8 @@
compatible = "intel,edison";
 
aliases {
+   serial0 = 
+   serial1 = 
serial2 = 
};
 
@@ -53,6 +55,22 @@
  0x0100 0x0 0x2000 0x2000 0 0xe000>;
};
 
+   serial0: serial@ff010180 {
+   compatible = "intel,mid-uart";
+   reg = <0xff010080 0x100>;
+   reg-shift = <0>;
+   clock-frequency = <29491200>;
+   current-speed = <115200>;
+   };
+
+   serial1: serial@ff010180 {
+   compatible = "intel,mid-uart";
+   reg = <0xff010100 0x100>;
+   reg-shift = <0>;
+   clock-frequency = <29491200>;
+   current-speed = <115200>;
+   };
+
serial2: serial@ff010180 {
compatible = "intel,mid-uart";
reg = <0xff010180 0x100>;
-- 
2.20.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot