Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-10 Thread Kevin Hilman
Hyungwon Hwang human.hw...@samsung.com writes:

 Dear Kevin,

 On Tue, 09 Dec 2014 15:36:00 -0800
 Kevin Hilman khil...@kernel.org wrote:

 Hyungwon Hwang human.hw...@samsung.com writes:
 
  This is v11 of the patchset adding support Odroud XU3 board.
 
 I finally got around to testing this on top of v2015.01-rc3 on my XU3.
 
 As I mentioned earlier, I had to enable the USB and networking options
 so I could dhcp/tftp but after that it works for me.
 
 Feel free to add:
 
 Tested-by: Kevin Hilman khil...@linaro.org

 Thanks for yout review. Sjoerd is waiting for his patch merged
 (title: Exynos: Move down common USB
 configuration). So the features related USB and networking will be
 enabled after this patchset and his patch are merged.

OK, good.

 
 [...]
 
  Note: If you use micro SD card for your test you have to apply the
  below patch additionally. This patch is needed, because micro sd
  card is recognized as MMC1 instead of MMC0. Additional work is
  needed to make it work regardless of device id.
 
 FYI, with or without your MMC ID patch, I wasn't able to save the
 environment to the SD card I'm booting from:
 
 ODROID-XU3 # saveenv
 Saving Environment to MMC...
 dwmci_send_cmd: Timeout.
 MMC init failed
 

 Actually I just tested it again. But it works for me.

 Saving Environment to MMC...
 Writing to MMC(1)... done

 I applied my patchset and MMC ID patch to commit
 38cd8c4253013ccdd4052ee021f6066fe9a52551 in
 http://git.denx.de/u-boot-samsung.git (branch: master).

 I don't know why it does't work for you. Please feel free to need my
 help for this, if you need.

Curious wh you're using u-boot-samsung.git and not mainline.  Can you
test this using mainline u-boot v2015.01-rc3?

Kevin

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-10 Thread Hyungwon Hwang
On Wed, 10 Dec 2014 11:23:08 -0800
Kevin Hilman khil...@kernel.org wrote:

 Hyungwon Hwang human.hw...@samsung.com writes:
 
  Dear Kevin,
 
  On Tue, 09 Dec 2014 15:36:00 -0800
  Kevin Hilman khil...@kernel.org wrote:
 
  Hyungwon Hwang human.hw...@samsung.com writes:
  
   This is v11 of the patchset adding support Odroud XU3 board.
  
  I finally got around to testing this on top of v2015.01-rc3 on my
  XU3.
  
  As I mentioned earlier, I had to enable the USB and networking
  options so I could dhcp/tftp but after that it works for me.
  
  Feel free to add:
  
  Tested-by: Kevin Hilman khil...@linaro.org
 
  Thanks for yout review. Sjoerd is waiting for his patch merged
  (title: Exynos: Move down common USB
  configuration). So the features related USB and networking will be
  enabled after this patchset and his patch are merged.
 
 OK, good.
 
  
  [...]
  
   Note: If you use micro SD card for your test you have to apply
   the below patch additionally. This patch is needed, because
   micro sd card is recognized as MMC1 instead of MMC0. Additional
   work is needed to make it work regardless of device id.
  
  FYI, with or without your MMC ID patch, I wasn't able to save the
  environment to the SD card I'm booting from:
  
  ODROID-XU3 # saveenv
  Saving Environment to MMC...
  dwmci_send_cmd: Timeout.
  MMC init failed
  
 
  Actually I just tested it again. But it works for me.
 
  Saving Environment to MMC...
  Writing to MMC(1)... done
 
  I applied my patchset and MMC ID patch to commit
  38cd8c4253013ccdd4052ee021f6066fe9a52551 in
  http://git.denx.de/u-boot-samsung.git (branch: master).
 
  I don't know why it does't work for you. Please feel free to need my
  help for this, if you need.
 
 Curious wh you're using u-boot-samsung.git and not mainline.  Can you
 test this using mainline u-boot v2015.01-rc3?
 
 Kevin
 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-10 Thread Hyungwon Hwang
Dear Kevin,

On Wed, 10 Dec 2014 11:23:08 -0800
Kevin Hilman khil...@kernel.org wrote:

 Hyungwon Hwang human.hw...@samsung.com writes:
 
  Dear Kevin,
 
  On Tue, 09 Dec 2014 15:36:00 -0800
  Kevin Hilman khil...@kernel.org wrote:
 
  Hyungwon Hwang human.hw...@samsung.com writes:
  
   This is v11 of the patchset adding support Odroud XU3 board.
  
  I finally got around to testing this on top of v2015.01-rc3 on my
  XU3.
  
  As I mentioned earlier, I had to enable the USB and networking
  options so I could dhcp/tftp but after that it works for me.
  
  Feel free to add:
  
  Tested-by: Kevin Hilman khil...@linaro.org
 
  Thanks for yout review. Sjoerd is waiting for his patch merged
  (title: Exynos: Move down common USB
  configuration). So the features related USB and networking will be
  enabled after this patchset and his patch are merged.
 
 OK, good.
 
  
  [...]
  
   Note: If you use micro SD card for your test you have to apply
   the below patch additionally. This patch is needed, because
   micro sd card is recognized as MMC1 instead of MMC0. Additional
   work is needed to make it work regardless of device id.
  
  FYI, with or without your MMC ID patch, I wasn't able to save the
  environment to the SD card I'm booting from:
  
  ODROID-XU3 # saveenv
  Saving Environment to MMC...
  dwmci_send_cmd: Timeout.
  MMC init failed
  
 
  Actually I just tested it again. But it works for me.
 
  Saving Environment to MMC...
  Writing to MMC(1)... done
 
  I applied my patchset and MMC ID patch to commit
  38cd8c4253013ccdd4052ee021f6066fe9a52551 in
  http://git.denx.de/u-boot-samsung.git (branch: master).
 
  I don't know why it does't work for you. Please feel free to need my
  help for this, if you need.
 
 Curious wh you're using u-boot-samsung.git and not mainline.  Can you
 test this using mainline u-boot v2015.01-rc3?

I am sorry for the previous email. It was sent mistakenly by the bug
of pressing ctrl in my multi-screen program. As I know, basically the
merge is done by Minkyu Kang who manages the u-boot-samsung, and he
send pull request to mainline. So I have done this work based on
u-boot-samsung. How about use u-boot-samsung until it is merged to
mainline, even though there is a explicit bug (You can fix it with
https://patchwork.ozlabs.org/patch/415635/)?

Also, I tested saveenv in the
mainline u-boot(http://git.denx.de/u-boot.git). But it works.

Which compiler do you use? I use gcc version 4.8.2 (Ubuntu/Linaro
4.8.2-16ubuntu4). Can you tell me what you use or test it using another
compiler?

 
 Kevin
 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-09 Thread Kevin Hilman
Hyungwon Hwang human.hw...@samsung.com writes:

 This is v11 of the patchset adding support Odroud XU3 board.

I finally got around to testing this on top of v2015.01-rc3 on my XU3.

As I mentioned earlier, I had to enable the USB and networking options
so I could dhcp/tftp but after that it works for me.

Feel free to add:

Tested-by: Kevin Hilman khil...@linaro.org

[...]

 Note: If you use micro SD card for your test you have to apply the below
 patch additionally. This patch is needed, because micro sd card is
 recognized as MMC1 instead of MMC0. Additional work is needed to make it
 work regardless of device id.

FYI, with or without your MMC ID patch, I wasn't able to save the
environment to the SD card I'm booting from:

ODROID-XU3 # saveenv
Saving Environment to MMC...
dwmci_send_cmd: Timeout.
MMC init failed

Kevin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-09 Thread Hyungwon Hwang
Dear Kevin,

On Tue, 09 Dec 2014 15:36:00 -0800
Kevin Hilman khil...@kernel.org wrote:

 Hyungwon Hwang human.hw...@samsung.com writes:
 
  This is v11 of the patchset adding support Odroud XU3 board.
 
 I finally got around to testing this on top of v2015.01-rc3 on my XU3.
 
 As I mentioned earlier, I had to enable the USB and networking options
 so I could dhcp/tftp but after that it works for me.
 
 Feel free to add:
 
 Tested-by: Kevin Hilman khil...@linaro.org

Thanks for yout review. Sjoerd is waiting for his patch merged
(title: Exynos: Move down common USB
configuration). So the features related USB and networking will be
enabled after this patchset and his patch are merged.

 
 [...]
 
  Note: If you use micro SD card for your test you have to apply the
  below patch additionally. This patch is needed, because micro sd
  card is recognized as MMC1 instead of MMC0. Additional work is
  needed to make it work regardless of device id.
 
 FYI, with or without your MMC ID patch, I wasn't able to save the
 environment to the SD card I'm booting from:
 
 ODROID-XU3 # saveenv
 Saving Environment to MMC...
 dwmci_send_cmd: Timeout.
 MMC init failed
 

Actually I just tested it again. But it works for me.

Saving Environment to MMC...
Writing to MMC(1)... done

I applied my patchset and MMC ID patch to commit
38cd8c4253013ccdd4052ee021f6066fe9a52551 in
http://git.denx.de/u-boot-samsung.git (branch: master).

I don't know why it does't work for you. Please feel free to need my
help for this, if you need.

 Kevin

Best regards,
Hyungwon Hwang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-09 Thread Suriyan Ramasami
Hello Hyungwon Hwang,

On Tue, Dec 9, 2014 at 4:58 PM, Hyungwon Hwang human.hw...@samsung.com wrote:
 Dear Kevin,

 On Tue, 09 Dec 2014 15:36:00 -0800
 Kevin Hilman khil...@kernel.org wrote:

 Hyungwon Hwang human.hw...@samsung.com writes:

  This is v11 of the patchset adding support Odroud XU3 board.

 I finally got around to testing this on top of v2015.01-rc3 on my XU3.

 As I mentioned earlier, I had to enable the USB and networking options
 so I could dhcp/tftp but after that it works for me.

 Feel free to add:

 Tested-by: Kevin Hilman khil...@linaro.org

 Thanks for yout review. Sjoerd is waiting for his patch merged
 (title: Exynos: Move down common USB
 configuration). So the features related USB and networking will be
 enabled after this patchset and his patch are merged.


 [...]

  Note: If you use micro SD card for your test you have to apply the
  below patch additionally. This patch is needed, because micro sd
  card is recognized as MMC1 instead of MMC0. Additional work is
  needed to make it work regardless of device id.

 FYI, with or without your MMC ID patch, I wasn't able to save the
 environment to the SD card I'm booting from:

 ODROID-XU3 # saveenv
 Saving Environment to MMC...
 dwmci_send_cmd: Timeout.
 MMC init failed


 Actually I just tested it again. But it works for me.

 Saving Environment to MMC...
 Writing to MMC(1)... done

 I applied my patchset and MMC ID patch to commit
 38cd8c4253013ccdd4052ee021f6066fe9a52551 in
 http://git.denx.de/u-boot-samsung.git (branch: master).

 I don't know why it does't work for you. Please feel free to need my
 help for this, if you need.


Just like Kevin, I have to say that mmc is erratic.
For example, if you let the boot process go all along (and not
interrupt it), and let it fail in the pxe load commands. Then if you
do a, ls mmc 1:1 / it will give a timeout error (Assuming you do have
a valid 1st partition)
But, if you interrupt the boot during the count down, and issue the
same, it will work.
I had mentioned this before, that if you enable *MMC_TRACE, it again
stops working.

Also, I found if you do a couple of mmc 1:1 commands, and do some
other commands (say mmc rescan etc), and retry it will fail.

Regards
- Suriyan


 Kevin

 Best regards,
 Hyungwon Hwang
 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-09 Thread Hyungwon Hwang
Dear Suriyan,

On Tue, 09 Dec 2014 18:29:56 -0800
Suriyan Ramasami suriya...@gmail.com wrote:

 Hello Hyungwon Hwang,
 
 On Tue, Dec 9, 2014 at 4:58 PM, Hyungwon Hwang
 human.hw...@samsung.com wrote:
  Dear Kevin,
 
  On Tue, 09 Dec 2014 15:36:00 -0800
  Kevin Hilman khil...@kernel.org wrote:
 
  Hyungwon Hwang human.hw...@samsung.com writes:
 
   This is v11 of the patchset adding support Odroud XU3 board.
 
  I finally got around to testing this on top of v2015.01-rc3 on my
  XU3.
 
  As I mentioned earlier, I had to enable the USB and networking
  options so I could dhcp/tftp but after that it works for me.
 
  Feel free to add:
 
  Tested-by: Kevin Hilman khil...@linaro.org
 
  Thanks for yout review. Sjoerd is waiting for his patch merged
  (title: Exynos: Move down common USB
  configuration). So the features related USB and networking will be
  enabled after this patchset and his patch are merged.
 
 
  [...]
 
   Note: If you use micro SD card for your test you have to apply
   the below patch additionally. This patch is needed, because
   micro sd card is recognized as MMC1 instead of MMC0. Additional
   work is needed to make it work regardless of device id.
 
  FYI, with or without your MMC ID patch, I wasn't able to save the
  environment to the SD card I'm booting from:
 
  ODROID-XU3 # saveenv
  Saving Environment to MMC...
  dwmci_send_cmd: Timeout.
  MMC init failed
 
 
  Actually I just tested it again. But it works for me.
 
  Saving Environment to MMC...
  Writing to MMC(1)... done
 
  I applied my patchset and MMC ID patch to commit
  38cd8c4253013ccdd4052ee021f6066fe9a52551 in
  http://git.denx.de/u-boot-samsung.git (branch: master).
 
  I don't know why it does't work for you. Please feel free to need my
  help for this, if you need.
 
 
 Just like Kevin, I have to say that mmc is erratic.
 For example, if you let the boot process go all along (and not
 interrupt it), and let it fail in the pxe load commands. Then if you
 do a, ls mmc 1:1 / it will give a timeout error (Assuming you do have
 a valid 1st partition)
 But, if you interrupt the boot during the count down, and issue the
 same, it will work.
 I had mentioned this before, that if you enable *MMC_TRACE, it again
 stops working.
 
 Also, I found if you do a couple of mmc 1:1 commands, and do some
 other commands (say mmc rescan etc), and retry it will fail.

I tested all sinarios that you told me. But in all cases, it works for
me. That's awkward. You are using Micro SD card. Right?

 
 Regards
 - Suriyan
 
 
  Kevin
 
  Best regards,
  Hyungwon Hwang
  ___
  U-Boot mailing list
  U-Boot@lists.denx.de
  http://lists.denx.de/mailman/listinfo/u-boot

Best regards,
Hyungwon Hwang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-09 Thread Suriyan Ramasami
Hello Hyungwon Hwang,

On Tue, Dec 9, 2014 at 7:52 PM, Hyungwon Hwang human.hw...@samsung.com wrote:
 Dear Suriyan,

 On Tue, 09 Dec 2014 18:29:56 -0800
 Suriyan Ramasami suriya...@gmail.com wrote:

 Hello Hyungwon Hwang,

 On Tue, Dec 9, 2014 at 4:58 PM, Hyungwon Hwang
 human.hw...@samsung.com wrote:
  Dear Kevin,
 
  On Tue, 09 Dec 2014 15:36:00 -0800
  Kevin Hilman khil...@kernel.org wrote:
 
  Hyungwon Hwang human.hw...@samsung.com writes:
 
   This is v11 of the patchset adding support Odroud XU3 board.
 
  I finally got around to testing this on top of v2015.01-rc3 on my
  XU3.
 
  As I mentioned earlier, I had to enable the USB and networking
  options so I could dhcp/tftp but after that it works for me.
 
  Feel free to add:
 
  Tested-by: Kevin Hilman khil...@linaro.org
 
  Thanks for yout review. Sjoerd is waiting for his patch merged
  (title: Exynos: Move down common USB
  configuration). So the features related USB and networking will be
  enabled after this patchset and his patch are merged.
 
 
  [...]
 
   Note: If you use micro SD card for your test you have to apply
   the below patch additionally. This patch is needed, because
   micro sd card is recognized as MMC1 instead of MMC0. Additional
   work is needed to make it work regardless of device id.
 
  FYI, with or without your MMC ID patch, I wasn't able to save the
  environment to the SD card I'm booting from:
 
  ODROID-XU3 # saveenv
  Saving Environment to MMC...
  dwmci_send_cmd: Timeout.
  MMC init failed
 
 
  Actually I just tested it again. But it works for me.
 
  Saving Environment to MMC...
  Writing to MMC(1)... done
 
  I applied my patchset and MMC ID patch to commit
  38cd8c4253013ccdd4052ee021f6066fe9a52551 in
  http://git.denx.de/u-boot-samsung.git (branch: master).
 
  I don't know why it does't work for you. Please feel free to need my
  help for this, if you need.
 

 Just like Kevin, I have to say that mmc is erratic.
 For example, if you let the boot process go all along (and not
 interrupt it), and let it fail in the pxe load commands. Then if you
 do a, ls mmc 1:1 / it will give a timeout error (Assuming you do have
 a valid 1st partition)
 But, if you interrupt the boot during the count down, and issue the
 same, it will work.
 I had mentioned this before, that if you enable *MMC_TRACE, it again
 stops working.

 Also, I found if you do a couple of mmc 1:1 commands, and do some
 other commands (say mmc rescan etc), and retry it will fail.

 I tested all sinarios that you told me. But in all cases, it works for
 me. That's awkward. You are using Micro SD card. Right?


Yes, I am using the Micro SD card. I shall use a different cross
compiling tool chain, or, come with a test case which is consistent
(by tomorrow).
Cheers!
- Suriyan


 Regards
 - Suriyan


  Kevin
 
  Best regards,
  Hyungwon Hwang
  ___
  U-Boot mailing list
  U-Boot@lists.denx.de
  http://lists.denx.de/mailman/listinfo/u-boot

 Best regards,
 Hyungwon Hwang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v11 0/3] Adds support for Exynos5422 odroid xu3 board

2014-12-08 Thread Hyungwon Hwang
This is v11 of the patchset adding support Odroud XU3 board.

link to the previous version:
v2: https://www.mail-archive.com/u-boot@lists.denx.de/msg152275.html
v3: https://www.mail-archive.com/u-boot%40lists.denx.de/msg152677.html
v4: https://patchwork.ozlabs.org/patch/407411/
v5: https://patchwork.ozlabs.org/patch/407941/
v6: https://patchwork.ozlabs.org/patch/408647/
v7: https://patchwork.ozlabs.org/patch/410204/
v8: https://patchwork.ozlabs.org/patch/410709/
v9: https://patchwork.ozlabs.org/patch/415514/
v10: https://patchwork.ozlabs.org/patch/416720/

The patchset by Akshay Saraswat is already merged into u-boot-samsung.
Please ignore the instruction about the additional patchset in v8.

How to test this patch:
1. git clone http://git.denx.de/u-boot-samsung.git
2. Apply this patchset
3. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- odroid-xu3_config
4. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- -j8
5. Now you can use u-boot-dtb.bin for your downloading

WARNING: (update in V10)
It was impossible to make the u-boot image smaller than 335872 bytes, and also
I did not want to waste my time to make it fit for that restriction, because
the discussion about this issue is in progress in malining list. I used BL2 by
Suriyan Ramasami suriya...@gmail.com which the restriction is removed for
testing. If you need the BL2 for testing, please contact me or Suriyan.

Note: If you use micro SD card for your test you have to apply the below
patch additionally. This patch is needed, because micro sd card is
recognized as MMC1 instead of MMC0. Additional work is needed to make it
work regardless of device id.

Thanks for Sjoerd Simons. Not only did he comment my patchset, but he also made
real patch for me. I squashed some part of that patchset, and included the
remainings into my patchset.

diff --git a/include/configs/exynos5-common.h b/include/configs/exynos5-common.h
index ba591e7..437eaae 100644
--- a/include/configs/exynos5-common.h
+++ b/include/configs/exynos5-common.h
@@ -109,7 +109,7 @@
 
 #define CONFIG_SYS_MONITOR_BASE0x
 
-#define CONFIG_SYS_MMC_ENV_DEV 0
+#define CONFIG_SYS_MMC_ENV_DEV 1
 
 #define CONFIG_SECURE_BL1_ONLY
 
Changes for v2:
- Add a patch to add new common setup header file for Odroid X2/U3
and Odroid XU3

Changes for v3:
- Remove the patch which adds new common setup header file from v2
- Remove the wrong patch to fix GPIO information of Exynos 5800
- Remove unnecessary node from DT file
- Remove unnecessary features from config file
- Fix some trivial typos in comments

Changes for v4:
- Add MMC FIFO buffer's configuration to DT file
- Make CONFIG_OF_CONTROL be set by the target information
- Add basic document to doc/README.odroid-xu3
- Add CONFIG_CMD_EXT4 to config file
- Add environment size and offset to config file
- Add extra default environment to make bootable without modification
- Remove unnecessary features from config file

Changes for v5:
- Add the specific build instruction
- Update the information of patchset by Akshay Saraswat
- Convert /include/ to #include in DT file

Changes for v6:
- Separate out the documentation to new commit
- Remove unnecessary header file inclusuib from the board-specific setup file
- Make the function board_clock_init be declared, only when
  CONFIG_BOARD_EARLY_INIT_F is defined

Changes for v7:
- Fix several errata in the documentation
- Remove OF_CONTROL dependency from !SPL_BUILD

Changes for v8:
- Remove unnecessary properties in DT mmc node

Changes for v9:
- Remove the first patch which change GPIO entries order. It became useless,
after DT support is added 
- Remove useless variables in the default environment
- Add the new contents to the documentation of Odroid X2/U2, instead of
making new document for Odorid XU3
- Remove the detailed information in the header file, and leave the
reference to the documentation

Changes for v10:
- Move the non common configs in Exynos5420 config file to each board file
- Remove the config unsets which are added to make the result image small
  This is needless now, because the image is not small enough even though these
  unsets are added.
- Remove redundant DT node and properties
- Remove the odroid-xu3 board file and make odroid-xu3 a variant of smdk5420
- Fix some errata in documentation
- Include the patch by Sjoerd Simons as 4th patch

Changes for v11:
- Move the include point of exynos5420-common.h after
  CONFIG_ENV_IS_IN_SPI_FLASH in smdk5420.h
- Remove duplicated CONFIG_CMD_EXT2/EXT4/FAT from odroid_xu3.h
- Fix the typo in the comment, which is found in odroid_xu3.h
- Add a comment to specify not available networking yet
- Remove the patch abou EHCI

Hyungwon Hwang (3):
  config: exynos5420: move non common configs to specific board files
  Odroid-XU3: Add support for Odroid-XU3
  Odroid-XU3: Add documentation for Odroid-XU3

 arch/arm/cpu/armv7/exynos/Kconfig |  4 +++
 arch/arm/dts/Makefile |  3 ++-