Re: [U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
On 11/11/2014 12:04 PM, Simon Glass wrote: From: Allen Martin amar...@nvidia.com Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as nyan in the ChromeOS trees. This is the Acer Chromebook 13 CB5-311-T7NN (13.3-inch HD, NVIDIA Tegra K1, 2GB). Isn't Norrin a development board for that? I believe there are differences between Norrin and the final CB5. If this patch really is for CB5 specifically, shouldn't it be named that way? Ideally, the U-Boot board name should exactly match the DTB filename in the DT tree (i.e. arch/arm/boot/dts in the Linux kernel at present) so that the U-Boot environment doesn't have to override the automatic $dtbfile calculation. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
On 11/11/2014 12:04 PM, Simon Glass wrote: From: Allen Martin amar...@nvidia.com Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as nyan in the ChromeOS trees. This is the Acer Chromebook 13 CB5-311-T7NN (13.3-inch HD, NVIDIA Tegra K1, 2GB). Signed-off-by: Allen Martin amar...@nvidia.com Signed-off-by: Simon Glass s...@chromium.org (rebase, fix pinmux that resets norrin) Did the pinmux come directly from: https://github.com/NVIDIA/tegra-pinmux-scripts If not, we should fix the Norrin data that's there so that it's correct, and generates exactly what you want to check into U-Boot. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
Hi Stephen, On 12 November 2014 11:59, Stephen Warren swar...@wwwdotorg.org wrote: On 11/11/2014 12:04 PM, Simon Glass wrote: From: Allen Martin amar...@nvidia.com Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as nyan in the ChromeOS trees. This is the Acer Chromebook 13 CB5-311-T7NN (13.3-inch HD, NVIDIA Tegra K1, 2GB). Isn't Norrin a development board for that? I believe there are differences between Norrin and the final CB5. If this patch really is for CB5 specifically, shouldn't it be named that way? Ideally, the U-Boot board name should exactly match the DTB filename in the DT tree (i.e. arch/arm/boot/dts in the Linux kernel at present) so that the U-Boot environment doesn't have to override the automatic $dtbfile calculation. My intent was to get this patch merged as it has been sitting around for ages. I don't have a Norrin dev board though. We could perhaps have two device tree files but use a generic config? Perhaps I was mislead by the comment that it is called 'nyan' in the Chrome OS tree. If you like I can change this to nyan? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
Hi Stephen, On 12 November 2014 11:57, Stephen Warren swar...@wwwdotorg.org wrote: On 11/11/2014 12:04 PM, Simon Glass wrote: From: Allen Martin amar...@nvidia.com Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as nyan in the ChromeOS trees. This is the Acer Chromebook 13 CB5-311-T7NN (13.3-inch HD, NVIDIA Tegra K1, 2GB). Signed-off-by: Allen Martin amar...@nvidia.com Signed-off-by: Simon Glass s...@chromium.org (rebase, fix pinmux that resets norrin) Did the pinmux come directly from: https://github.com/NVIDIA/tegra-pinmux-scripts If not, we should fix the Norrin data that's there so that it's correct, and generates exactly what you want to check into U-Boot. Allen posted the original patch - my change was to take out the pinmux which causes the board to reset. Maybe that is a difference between nyan and norrin? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
From: Allen Martin amar...@nvidia.com
Norrin (PM370) is a Tegra124 clamshell board that is very similar to
venice2, but it has a different panel, the sdcard cd and wp sense are
flipped, and it has a different revision of the AS3722 PMIC. This
board is also refered to as nyan in the ChromeOS trees.
This is the Acer Chromebook 13 CB5-311-T7NN (13.3-inch HD, NVIDIA
Tegra K1, 2GB).
Signed-off-by: Allen Martin amar...@nvidia.com
Signed-off-by: Simon Glass s...@chromium.org
(rebase, fix pinmux that resets norrin)
---
Changes in v2:
- Rebase and adjust for Kconfig
- Fix up pinmux that reset norrin
- Add note as to the Chromebook's retail name, since it is now released
arch/arm/cpu/armv7/tegra124/Kconfig| 11 ++
arch/arm/dts/Makefile | 1 +
arch/arm/dts/tegra124-norrin.dts | 92 +
board/nvidia/norrin/Kconfig| 24 +++
board/nvidia/norrin/MAINTAINERS| 6 +
board/nvidia/norrin/Makefile | 9 +
board/nvidia/norrin/norrin.c | 29 +++
board/nvidia/norrin/pinmux-config-norrin.h | 290 +
board/nvidia/venice2/as3722_init.h | 2 +-
configs/norrin_defconfig | 5 +
include/configs/norrin.h | 76
11 files changed, 544 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/dts/tegra124-norrin.dts
create mode 100644 board/nvidia/norrin/Kconfig
create mode 100644 board/nvidia/norrin/MAINTAINERS
create mode 100644 board/nvidia/norrin/Makefile
create mode 100644 board/nvidia/norrin/norrin.c
create mode 100644 board/nvidia/norrin/pinmux-config-norrin.h
create mode 100644 configs/norrin_defconfig
create mode 100644 include/configs/norrin.h
diff --git a/arch/arm/cpu/armv7/tegra124/Kconfig
b/arch/arm/cpu/armv7/tegra124/Kconfig
index 6a1c83a..db17819 100644
--- a/arch/arm/cpu/armv7/tegra124/Kconfig
+++ b/arch/arm/cpu/armv7/tegra124/Kconfig
@@ -6,6 +6,16 @@ choice
config TARGET_JETSON_TK1
bool NVIDIA Tegra124 Jetson TK1 board
+config TARGET_NORRIN
+ bool NVIDIA Tegra124 Norrin
+ help
+ Norrin (PM370) is a Tegra124 clamshell board that is very similar
+ to venice2, but it has a different panel, the sdcard CD and WP
+ sense are flipped, and it has a different revision of the AS3722
+ PMIC. This board is also refered to as nyan in the Chrome OS
+ trees. The retail name is the Acer Chromebook 13 CB5-311-T7NN
+ (13.3-inch HD, NVIDIA Tegra K1, 2GB).
+
config TARGET_VENICE2
bool NVIDIA Tegra124 Venice2
@@ -15,6 +25,7 @@ config SYS_SOC
default tegra124
source board/nvidia/jetson-tk1/Kconfig
+source board/nvidia/norrin/Kconfig
source board/nvidia/venice2/Kconfig
endif
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 52f8926..aa1e81a 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -30,6 +30,7 @@ dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
tegra30-tec-ng.dtb \
tegra114-dalmore.dtb \
tegra124-jetson-tk1.dtb \
+ tegra124-norrin.dtb \
tegra124-venice2.dtb
dtb-$(CONFIG_ZYNQ) += zynq-zc702.dtb \
zynq-zc706.dtb \
diff --git a/arch/arm/dts/tegra124-norrin.dts b/arch/arm/dts/tegra124-norrin.dts
new file mode 100644
index 000..b07630c
--- /dev/null
+++ b/arch/arm/dts/tegra124-norrin.dts
@@ -0,0 +1,92 @@
+/dts-v1/;
+
+#include tegra124.dtsi
+
+/ {
+ model = NVIDIA Norrin;
+ compatible = nvidia,norrin, nvidia,tegra124;
+
+ aliases {
+ console = uarta;
+ i2c0 = /i2c@7000d000;
+ i2c1 = /i2c@7000c000;
+ i2c2 = /i2c@7000c400;
+ i2c3 = /i2c@7000c500;
+ i2c4 = /i2c@7000c700;
+ i2c5 = /i2c@7000d100;
+ sdhci0 = /sdhci@700b0600;
+ sdhci1 = /sdhci@700b0400;
+ spi0 = /spi@7000d400;
+ spi1 = /spi@7000da00;
+ usb0 = /usb@7d00;
+ usb1 = /usb@7d008000;
+ };
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x8000;
+ };
+
+ i2c@7000c000 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000c400 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000c500 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000c700 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000d000 {
+ status = okay;
+ clock-frequency = 40;
+ };
+
+ i2c@7000d100 {
+ status = okay;
+ clock-frequency = 40;
+ };
+
+ spi@7000d400 {
+ status = okay;
+ spi-max-frequency = 2500;
+ };
+
+ spi@7000da00 {
+ status =
Re: [U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
On Thu, Jul 31, 2014 at 04:21:43PM -0700, Stephen Warren wrote: On 07/31/2014 05:14 PM, Allen Martin wrote: Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as nyan in the ChromeOS trees. At a *very* quick glance, this looks OK. But, you'll need to do a bit of work to rebase it onto the latest u-boot/master. Kconfig has been introduced now, so you'll need to do at least: * Don't touch boards.cfg (it's been removed) * Add configs/norrin_defconfig * Add board/nvidia/norrin/MAINTAINERS I think that's it. I based the patch on u-boot-tegra/master, is there a tegra branch that has already been rebased? Or has the upstream workflow changed, so we're not collecting patches on u-boot-tegra for next merge window? -Allen nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
On 08/04/2014 12:38 PM, Allen Martin wrote: On Thu, Jul 31, 2014 at 04:21:43PM -0700, Stephen Warren wrote: On 07/31/2014 05:14 PM, Allen Martin wrote: Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as nyan in the ChromeOS trees. At a *very* quick glance, this looks OK. But, you'll need to do a bit of work to rebase it onto the latest u-boot/master. Kconfig has been introduced now, so you'll need to do at least: * Don't touch boards.cfg (it's been removed) * Add configs/norrin_defconfig * Add board/nvidia/norrin/MAINTAINERS I think that's it. I based the patch on u-boot-tegra/master, is there a tegra branch that has already been rebased? Or has the upstream workflow changed, so we're not collecting patches on u-boot-tegra for next merge window? Anything that gets applied will eventually have to merge with what's upstream from u-boot-tegra/master, so it's best to base patches on the main U-Boot repo rather than the Tegra repo, perhaps with the addition of any relevant patches from other trees that will get into the main U-Boot repo before your patches. The only exception would be small changes/fixes that you know are going into u-boot-tegra/master very quickly, during a time period when Tom is actively applying patches for a current pull request. When Tom isn't actively applying patches to u-boot-tegra/master, that branch will sit still, containing the content of the previous pull request. It might stay in that state for a while, as u-boot/master etc. all advance. When Tom starts applying patches for a new pull request, he'll then update u-boot-tegra/master to start at some upstream point (which will pull in all the new upstream work) and then apply your patches. If your patches aren't based on that new upstream already, they won't apply correctly, and you or Tom will have to rebase them at that time. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
Norrin (PM370) is a Tegra124 clamshell board that is very similar to
venice2, but it has a different panel, the sdcard cd and wp sense are
flipped, and it has a different revision of the AS3722 PMIC. This
board is also refered to as nyan in the ChromeOS trees.
Signed-off-by: Allen Martin amar...@nvidia.com
---
Changes from v1:
-Generated pinmux with tegra-pinmux-scripts directly from pinmux
spreadsheet.
-Don't try to reuse venice2 board files
---
arch/arm/dts/Makefile | 1 +
arch/arm/dts/tegra124-norrin.dts | 91 +
board/nvidia/norrin/Makefile | 9 +
board/nvidia/norrin/norrin.c | 29 +++
board/nvidia/norrin/pinmux-config-norrin.h | 287 +
board/nvidia/venice2/as3722_init.h | 2 +-
boards.cfg | 1 +
include/configs/norrin.h | 81
8 files changed, 500 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/dts/tegra124-norrin.dts
create mode 100644 board/nvidia/norrin/Makefile
create mode 100644 board/nvidia/norrin/norrin.c
create mode 100644 board/nvidia/norrin/pinmux-config-norrin.h
create mode 100644 include/configs/norrin.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 55546152b94b..73a1f141cf04 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -23,6 +23,7 @@ dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
tegra30-tec-ng.dtb \
tegra114-dalmore.dtb \
tegra124-jetson-tk1.dtb \
+ tegra124-norrin.dtb \
tegra124-venice2.dtb
dtb-$(CONFIG_ZYNQ) += zynq-zc702.dtb \
zynq-zc706.dtb \
diff --git a/arch/arm/dts/tegra124-norrin.dts b/arch/arm/dts/tegra124-norrin.dts
new file mode 100644
index ..fdf000cf75ec
--- /dev/null
+++ b/arch/arm/dts/tegra124-norrin.dts
@@ -0,0 +1,91 @@
+/dts-v1/;
+
+#include tegra124.dtsi
+
+/ {
+ model = NVIDIA Norrin;
+ compatible = nvidia,norrin, nvidia,tegra124;
+
+ aliases {
+ i2c0 = /i2c@7000d000;
+ i2c1 = /i2c@7000c000;
+ i2c2 = /i2c@7000c400;
+ i2c3 = /i2c@7000c500;
+ i2c4 = /i2c@7000c700;
+ i2c5 = /i2c@7000d100;
+ sdhci0 = /sdhci@700b0600;
+ sdhci1 = /sdhci@700b0400;
+ spi0 = /spi@7000d400;
+ spi1 = /spi@7000da00;
+ usb0 = /usb@7d00;
+ usb1 = /usb@7d008000;
+ };
+
+ memory {
+ device_type = memory;
+ reg = 0x8000 0x8000;
+ };
+
+ i2c@7000c000 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000c400 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000c500 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000c700 {
+ status = okay;
+ clock-frequency = 10;
+ };
+
+ i2c@7000d000 {
+ status = okay;
+ clock-frequency = 40;
+ };
+
+ i2c@7000d100 {
+ status = okay;
+ clock-frequency = 40;
+ };
+
+ spi@7000d400 {
+ status = okay;
+ spi-max-frequency = 2500;
+ };
+
+ spi@7000da00 {
+ status = okay;
+ spi-max-frequency = 2500;
+ };
+
+ sdhci@700b0400 {
+ status = okay;
+ cd-gpios = gpio 170 1; /* gpio PV2 */
+ power-gpios = gpio 136 0; /* gpio PR0 */
+ bus-width = 4;
+ };
+
+ sdhci@700b0600 {
+ status = okay;
+ bus-width = 8;
+ };
+
+ usb@7d00 {
+ status = okay;
+ dr_mode = otg;
+ nvidia,vbus-gpio = gpio 108 0; /* gpio PN4, USB_VBUS_EN0 */
+ };
+
+ usb@7d008000 {
+ status = okay;
+ nvidia,vbus-gpio = gpio 109 0; /* gpio PN5, USB_VBUS_EN1 */
+ };
+};
diff --git a/board/nvidia/norrin/Makefile b/board/nvidia/norrin/Makefile
new file mode 100644
index ..5e490bb38f30
--- /dev/null
+++ b/board/nvidia/norrin/Makefile
@@ -0,0 +1,9 @@
+#
+# (C) Copyright 2014
+# NVIDIA Corporation www.nvidia.com
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y += ../venice2/as3722_init.o
+obj-y += norrin.o
diff --git a/board/nvidia/norrin/norrin.c b/board/nvidia/norrin/norrin.c
new file mode 100644
index ..6f0050c4cd2f
--- /dev/null
+++ b/board/nvidia/norrin/norrin.c
@@ -0,0 +1,29 @@
+/*
+ * (C) Copyright 2014
+ * NVIDIA Corporation www.nvidia.com
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include common.h
+#include asm/arch/gpio.h
+#include asm/arch/pinmux.h
+#include pinmux-config-norrin.h
+
+/*
+ * Routine: pinmux_init
+ * Description: Do individual peripheral pinmux
Re: [U-Boot] [PATCH v2] ARM: tegra: Add support for norrin board
On 07/31/2014 05:14 PM, Allen Martin wrote: Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as nyan in the ChromeOS trees. At a *very* quick glance, this looks OK. But, you'll need to do a bit of work to rebase it onto the latest u-boot/master. Kconfig has been introduced now, so you'll need to do at least: * Don't touch boards.cfg (it's been removed) * Add configs/norrin_defconfig * Add board/nvidia/norrin/MAINTAINERS I think that's it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
