Re: [U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
Dear Mike Frysinger, In message 201012182350.22451.vap...@gentoo.org you wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1090,6 +1090,10 @@ Peter Meerwald de...@bct-electronic.com bct-brettl2 BF536 +M.Hasewinkel (MHA) i...@ssv-embedded.de + + dnp5370 BF537 Please keep list sorted. the list is already not sorted, nor is it really feasible to do so. it's grouped by maintainer which may have multiply named boards. If you don't want to help to clean up (which I can live with), then please at least do not add to the mess. +#define CONFIG_IPADDR 10.100.100.21 +#define CONFIG_NETMASK 255.255.0.0 +#define CONFIG_GATEWAYIP 10.100.100.1 +#define CONFIG_SERVERIP10.100.100.12 NAK. We do not allow this. i dont see why. these are *default* settings. there is nothing here that prevents people in their own board from overriding at runtime and saving the result into their environment. where as having default settings often makes new builds/tests a lot smoother. It's still NAK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Hello! I'm from outer space, and I've made myself look like a signa- ture. While you are reading this, I'm having sex with your eyes. I know it feels good to you, because you're smiling. I'm very horny, so send me to someone else when you've had enough. Thanks! Sincerely, A Stranger in a Strange Land ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
On Sunday, December 19, 2010 07:27:05 Wolfgang Denk wrote: Mike Frysinger wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1090,6 +1090,10 @@ Peter Meerwald de...@bct-electronic.com bct-brettl2 BF536 +M.Hasewinkel (MHA) i...@ssv-embedded.de + + dnp5370 BF537 Please keep list sorted. the list is already not sorted, nor is it really feasible to do so. it's grouped by maintainer which may have multiply named boards. If you don't want to help to clean up (which I can live with), then please at least do not add to the mess. i'm saying that if the list cant be sorted, then there isnt a mess and there isnt anything to clean up +#define CONFIG_IPADDR 10.100.100.21 +#define CONFIG_NETMASK 255.255.0.0 +#define CONFIG_GATEWAYIP 10.100.100.1 +#define CONFIG_SERVERIP10.100.100.12 NAK. We do not allow this. i dont see why. these are *default* settings. there is nothing here that prevents people in their own board from overriding at runtime and saving the result into their environment. where as having default settings often makes new builds/tests a lot smoother. It's still NAK. so the logic here is because i said so -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
Dear Mike Frysinger, In message 201012191130.56370.vap...@gentoo.org you wrote: If you don't want to help to clean up (which I can live with), then please at least do not add to the mess. i'm saying that if the list cant be sorted, then there isnt a mess and there isnt anything to clean up The list can be sorted. Within each section it should be sorted by last name of the maintainers. NAK. We do not allow this. i dont see why. these are *default* settings. there is nothing here that prevents people in their own board from overriding at runtime and saving the result into their environment. where as having default settings often makes new builds/tests a lot smoother. It's still NAK. so the logic here is because i said so This has been discussed several times in the past, and somebody who has been around as long as you should either remember these arguments or be able to look them up in the archives. In short: defaults that may be good for you are most probably bad for (m)any other users of the board. Instead of spreading such bad defaults we default to not setting any. You may call it policy, if this helps you to accept that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Memories of you remind me of you. - Karl Lehenbauer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
On Sunday, December 19, 2010 15:05:34 Wolfgang Denk wrote: Mike Frysinger wrote: If you don't want to help to clean up (which I can live with), then please at least do not add to the mess. i'm saying that if the list cant be sorted, then there isnt a mess and there isnt anything to clean up The list can be sorted. Within each section it should be sorted by last name of the maintainers. i cant say ive noticed this policy, but changing to that should be easy. NAK. We do not allow this. i dont see why. these are *default* settings. there is nothing here that prevents people in their own board from overriding at runtime and saving the result into their environment. where as having default settings often makes new builds/tests a lot smoother. It's still NAK. so the logic here is because i said so This has been discussed several times in the past, and somebody who has been around as long as you should either remember these arguments or be able to look them up in the archives. In short: defaults that may be good for you are most probably bad for (m)any other users of the board. Instead of spreading such bad defaults we default to not setting any. just because ive seen you use this same logic before (i said so) doesnt mean i agree with it or even understand it. there is no such thing as bad defaults when it comes to network settings here. having a default IP that doesnt match your local LAN is just as bad as not having any IP at all. in both cases, things need the same amount of effort to change. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
Dear Mike Frysinger, In message 201012191709.20774.vap...@gentoo.org you wrote: The list can be sorted. Within each section it should be sorted by last name of the maintainers. i cant say ive noticed this policy, but changing to that should be easy. It has been mentioned several times before. This has been discussed several times in the past, and somebody who has been around as long as you should either remember these arguments or be able to look them up in the archives. In short: defaults that may be good for you are most probably bad for (m)any other users of the board. Instead of spreading such bad defaults we default to not setting any. just because ive seen you use this same logic before (i said so) doesnt mean Just for the records: I'm not alone with this opinion. i agree with it or even understand it. there is no such thing as bad defaults when it comes to network settings here. having a default IP that doesnt match your local LAN is just as bad as not having any IP at all. in both cases, things need the same amount of effort to change. I disagree. Setting random default values can cause collisions with existing addresses, i. e. cause trouble that may even interrupt operation of other, innocent systems; having no values set will only cause your local system not to work, but will never do any damage to others. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If the facts don't fit the theory, change the facts. -- Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
Dear Mike Frysinger, In message 1291891433-16355-1-git-send-email-vap...@gentoo.org you wrote: From: Andreas Schallenberg andreas.schallenb...@3alitydigital.de Info about the hardware can be found here: http://www.dilnetpc.com/dnp0086.htm Signed-off-by: Andreas Schallenberg andreas.schallenb...@3alitydigital.de Signed-off-by: Mike Frysinger vap...@gentoo.org --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1090,6 +1090,10 @@ Peter Meerwald de...@bct-electronic.com bct-brettl2 BF536 +M.Hasewinkel (MHA) i...@ssv-embedded.de + + dnp5370 BF537 Please keep list sorted. diff --git a/board/dnp5370/config.mk b/board/dnp5370/config.mk new file mode 100644 index 000..8227506 --- /dev/null +++ b/board/dnp5370/config.mk ... +CONFIG_BFIN_CPU = bf537-0.3 Please mode to board config file, and drop the config.mk +#define CONFIG_IPADDR 10.100.100.21 +#define CONFIG_NETMASK 255.255.0.0 +#define CONFIG_GATEWAYIP 10.100.100.1 +#define CONFIG_SERVERIP10.100.100.12 NAK. We do not allow this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Unix is supported by IBM, like a hanging man is supported by rope. - Don Libes Sandy Ressler: _Life With Unix_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
On Saturday, December 18, 2010 18:17:43 Wolfgang Denk wrote: Mike Frysinger wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1090,6 +1090,10 @@ Peter Meerwald de...@bct-electronic.com bct-brettl2 BF536 +M.Hasewinkel (MHA) i...@ssv-embedded.de + + dnp5370 BF537 Please keep list sorted. the list is already not sorted, nor is it really feasible to do so. it's grouped by maintainer which may have multiply named boards. --- /dev/null +++ b/board/dnp5370/config.mk +CONFIG_BFIN_CPU = bf537-0.3 Please mode to board config file, and drop the config.mk as noted in the other patch, this is the only place for it. +#define CONFIG_IPADDR 10.100.100.21 +#define CONFIG_NETMASK 255.255.0.0 +#define CONFIG_GATEWAYIP 10.100.100.1 +#define CONFIG_SERVERIP10.100.100.12 NAK. We do not allow this. i dont see why. these are *default* settings. there is nothing here that prevents people in their own board from overriding at runtime and saving the result into their environment. where as having default settings often makes new builds/tests a lot smoother. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] Blackfin: dnp5370: new board port
From: Andreas Schallenberg andreas.schallenb...@3alitydigital.de Info about the hardware can be found here: http://www.dilnetpc.com/dnp0086.htm Signed-off-by: Andreas Schallenberg andreas.schallenb...@3alitydigital.de Signed-off-by: Mike Frysinger vap...@gentoo.org --- v2 - update to latest mainline - add MAINTAINERS entry MAINTAINERS |4 ++ board/dnp5370/Makefile| 54 ++ board/dnp5370/config.mk | 29 ++ board/dnp5370/dnp5370.c | 104 +++ boards.cfg|1 + doc/README.dnp5370| 67 +++ include/configs/dnp5370.h | 131 + 7 files changed, 390 insertions(+), 0 deletions(-) create mode 100644 board/dnp5370/Makefile create mode 100644 board/dnp5370/config.mk create mode 100644 board/dnp5370/dnp5370.c create mode 100644 doc/README.dnp5370 create mode 100644 include/configs/dnp5370.h diff --git a/MAINTAINERS b/MAINTAINERS index 986e0dc..059155b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1090,6 +1090,10 @@ Peter Meerwald de...@bct-electronic.com bct-brettl2 BF536 +M.Hasewinkel (MHA) i...@ssv-embedded.de + + dnp5370 BF537 + # # End of MAINTAINERS list # # diff --git a/board/dnp5370/Makefile b/board/dnp5370/Makefile new file mode 100644 index 000..6651f3c --- /dev/null +++ b/board/dnp5370/Makefile @@ -0,0 +1,54 @@ +# +# U-boot - Makefile +# +# Copyright (c) 2005-2007 Analog Device Inc. +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).o + +COBJS-y:= $(BOARD).o + +SRCS := $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS := $(addprefix $(obj),$(SOBJS-y)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/dnp5370/config.mk b/board/dnp5370/config.mk new file mode 100644 index 000..8227506 --- /dev/null +++ b/board/dnp5370/config.mk @@ -0,0 +1,29 @@ +# +# Copyright (c) 2005-2008 Analog Device Inc. +# +# (C) Copyright 2001 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +# This is not actually used for Blackfin boards so do not change it +#TEXT_BASE = do-not-use-me + +CONFIG_BFIN_CPU = bf537-0.3 diff --git a/board/dnp5370/dnp5370.c b/board/dnp5370/dnp5370.c new file mode 100644 index 000..da9eb5f --- /dev/null +++ b/board/dnp5370/dnp5370.c @@ -0,0 +1,104 @@ +/* + * U-boot - main board file + * + * (C) Copyright 2010 3ality Digital Systems + * + * Copyright (c) 2005-2008 Analog Devices Inc. + * + * (C) Copyright 2000-2004 + * Wolfgang Denk, DENX Software Engineering, w...@denx.de. + * + * See file CREDITS for list of people who contributed to this + *
