Re: [U-Boot] [PATCH v2] Fix GCC format-security errors and convert sprintfs.

[Tom Rini]

On Wed, Dec 30, 2015 at 01:05:58PM +, ben.whit...@gmail.com wrote:

> From: Ben Whitten 
> 
> With format-security errors turned on, GCC picks up the use of sprintf with
> a format parameter not being a string literal.
> 
> Simple uses of sprintf are also converted to use strcpy.
> 
> Signed-off-by: Ben Whitten 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Fix GCC format-security errors and convert sprintfs.

[Wolfgang Denk]

Dear ben.whit...@gmail.com,

In message <1451480758-8871-1-git-send-email-ben.whit...@gmail.com> you wrote:
> From: Ben Whitten 
> 
> With format-security errors turned on, GCC picks up the use of sprintf with
> a format parameter not being a string literal.
> 
> Simple uses of sprintf are also converted to use strcpy.
> 
> Signed-off-by: Ben Whitten 
> ---
> Changes for v2:
> - Replaced single string uses of sprintf with strcpy
> - Detected more occurrences of potential errors.

Acked-by: Wolfgang Denk 

Thanks!!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Ein weiser Herrscher kann in einem großen Land  mehr  Gutes  bewirken
als  in  einem kleinen - ein dummer Herrscher aber auch viel mehr Un-
fug. Da weise Herrscher seltener sind als dumme, war ich schon  immer
gegen große Reiche skeptisch.   - Herbert Rosendorfer
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] Fix GCC format-security errors and convert sprintfs.

[ben . whitten]

From: Ben Whitten 

With format-security errors turned on, GCC picks up the use of sprintf with
a format parameter not being a string literal.

Simple uses of sprintf are also converted to use strcpy.

Signed-off-by: Ben Whitten 
---
Changes for v2:
- Replaced single string uses of sprintf with strcpy
- Detected more occurrences of potential errors.

 arch/mips/mach-au1x00/au1x00_eth.c  |  2 +-
 arch/powerpc/cpu/mpc8260/ether_scc.c|  2 +-
 arch/powerpc/cpu/mpc8xx/fec.c   |  2 +-
 arch/powerpc/cpu/mpc8xx/scc.c   |  2 +-
 arch/powerpc/cpu/mpc8xx/video.c |  4 ++--
 board/freescale/b4860qds/eth_b4860qds.c |  8 
 board/freescale/corenet_ds/eth_hydra.c  |  2 +-
 board/freescale/corenet_ds/eth_superhydra.c |  2 +-
 board/freescale/ls1021aqds/eth.c|  2 +-
 board/freescale/ls1043aqds/eth.c|  2 +-
 board/freescale/ls2080aqds/eth.c|  2 +-
 board/freescale/t102xqds/eth_t102xqds.c |  2 +-
 board/freescale/t1040qds/eth.c  |  2 +-
 board/freescale/t208xqds/eth_t208xqds.c |  2 +-
 board/freescale/t4qds/eth.c |  2 +-
 board/gdsys/common/ihs_mdio.c   |  2 +-
 board/keymile/common/common.c   |  4 ++--
 board/mpl/common/common_util.c  |  8 
 board/samsung/universal_c210/universal.c|  4 ++--
 board/siemens/rut/board.c   |  2 +-
 board/vscom/baltos/board.c  |  2 +-
 common/cmd_elf.c| 13 -
 common/cmd_mtdparts.c   |  2 +-
 common/cmd_nvedit.c |  2 +-
 disk/part_dos.c |  4 ++--
 disk/part_efi.c |  2 +-
 disk/part_iso.c |  2 +-
 drivers/block/sata_dwc.c|  4 ++--
 drivers/net/altera_tse.c|  2 +-
 drivers/net/at91_emac.c |  2 +-
 drivers/net/ax88180.c   |  2 +-
 drivers/net/cpsw.c  |  2 +-
 drivers/net/davinci_emac.c  |  2 +-
 drivers/net/designware.c|  2 +-
 drivers/net/dm9000x.c   |  2 +-
 drivers/net/fm/memac_phy.c  |  2 +-
 drivers/net/fm/tgec_phy.c   |  2 +-
 drivers/net/fsl_mdio.c  |  2 +-
 drivers/net/ftgmac100.c |  2 +-
 drivers/net/ftmac100.c  |  2 +-
 drivers/net/greth.c |  4 ++--
 drivers/net/keystone_net.c  |  2 +-
 drivers/net/ldpaa_eth/ldpaa_eth.c   |  4 ++--
 drivers/net/lpc32xx_eth.c   |  2 +-
 drivers/net/mpc512x_fec.c   |  2 +-
 drivers/net/mpc5xxx_fec.c   |  2 +-
 drivers/net/mvgbe.c |  2 +-
 drivers/net/ne2000_base.c   |  2 +-
 drivers/net/pch_gbe.c   |  2 +-
 drivers/net/sh_eth.c|  2 +-
 drivers/net/tsec.c  |  2 +-
 drivers/usb/gadget/f_fastboot.c |  6 +++---
 include/configs/tam3517-common.h|  2 +-
 scripts/kconfig/mconf.c |  2 +-
 54 files changed, 76 insertions(+), 73 deletions(-)

diff --git a/arch/mips/mach-au1x00/au1x00_eth.c 
b/arch/mips/mach-au1x00/au1x00_eth.c
index d6ebe07..3f9f91e 100644
--- a/arch/mips/mach-au1x00/au1x00_eth.c
+++ b/arch/mips/mach-au1x00/au1x00_eth.c
@@ -279,7 +279,7 @@ int au1x00_enet_initialize(bd_t *bis){

memset(dev, 0, sizeof *dev);

-   sprintf(dev->name, "Au1X00 ethernet");
+   strcpy(dev->name, "Au1X00 ethernet");
dev->iobase = 0;
dev->priv   = 0;
dev->init   = au1x00_init;
diff --git a/arch/powerpc/cpu/mpc8260/ether_scc.c 
b/arch/powerpc/cpu/mpc8260/ether_scc.c
index 5ba8bed..fff8f2b 100644
--- a/arch/powerpc/cpu/mpc8260/ether_scc.c
+++ b/arch/powerpc/cpu/mpc8260/ether_scc.c
@@ -355,7 +355,7 @@ int mpc82xx_scc_enet_initialize(bd_t *bis)
dev = (struct eth_device *) malloc(sizeof *dev);
memset(dev, 0, sizeof *dev);

-   sprintf(dev->name, "SCC");
+   strcpy(dev->name, "SCC");
dev->init   = sec_init;
dev->halt   = sec_halt;
dev->send   = sec_send;
diff --git a/arch/powerpc/cpu/mpc8xx/fec.c b/arch/powerpc/cpu/mpc8xx/fec.c
index 2e19603..ea4ab3a 100644
--- a/arch/powerpc/cpu/mpc8xx/fec.c
+++ b/arch/powerpc/cpu/mpc8xx/fec.c
@@ -148,7 +148,7 @@ int fec_initialize(bd_t *bis)
/* for FEC1 make sure that the name of the interface is the same
   as the old one for compatibility reasons */
if (i == 0) {
-   sprintf (dev->name, "FEC");
+   strcpy(dev->name, "FEC");
} else {
sprintf (dev->name, "FEC%d",