Re: [U-Boot] [PATCH v2] Fix cache misalignment after network load operations

2016-09-13 Thread Peter.Chubb 
> "Fabio" == Fabio Estevam  writes:

Fabio> On Tue, Sep 13, 2016 at 10:30 PM, 
Fabio> wrote:
>> After any operation that downloads a file (e.g., pxe get, or dhcp),
>> the buffer containing the downloaded data is flushed.  This patch
>> rounds up the flushed size to a cacheline boundary, preventing a
>> cache misalignment message from u-boot.

Fabio> Looks like you missed to update the commit log for v2 as you
Fabio> are no longer flushing the cache :-)

Arrgh.  Thanks for this -- will respin and resubmit.

Fabio> Also, in the Subject line it is always good practice to start
Fabio> with the subsystem name, so something like: net: Remove
Fabio> flush_cache() operation

 Will do.

Peter C
-- 
Dr Peter Chubb Tel: +61 2 9490 5852  http://ts.data61.csiro.au/
Trustworthy Systems Group   Data61 (formerly NICTA)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Fix cache misalignment after network load operations

2016-09-13 Thread Fabio Estevam 
On Tue, Sep 13, 2016 at 10:30 PM,   wrote:
> After any operation that downloads a file (e.g., pxe get, or dhcp), the
> buffer containing the downloaded data is flushed.  This patch rounds
> up the flushed size to a cacheline boundary, preventing a cache
> misalignment message from u-boot.

Looks like you missed to update the commit log for v2 as you are no
longer flushing the cache :-)

Also, in the Subject line it is always good practice to start with the
subsystem name, so something like:
net: Remove flush_cache() operation
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] Fix cache misalignment after network load operations

2016-09-13 Thread Peter.Chubb 
After any operation that downloads a file (e.g., pxe get, or dhcp), the
buffer containing the downloaded data is flushed.  This patch rounds
up the flushed size to a cacheline boundary, preventing a cache
misalignment message from u-boot.

Signed-off-by: Peter Chubb 
---
 cmd/net.c |3 ---
 1 file changed, 3 deletions(-)

Index: u-boot/cmd/net.c
===
--- u-boot.orig/cmd/net.c   2016-09-07 13:50:46.616156851 +1000
+++ u-boot/cmd/net.c2016-09-07 19:18:18.962450874 +1000
@@ -243,9 +243,6 @@ static int netboot_common(enum proto_t p
return CMD_RET_SUCCESS;
}
 
-   /* flush cache */
-   flush_cache(load_addr, size);
-
bootstage_mark(BOOTSTAGE_ID_NET_LOADED);
 
rcode = bootm_maybe_autostart(cmdtp, argv[0]);
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot