Re: [U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-03-28 Thread Joe Hershberger 
On Wed, Mar 28, 2018 at 2:45 AM, Michal Simek  wrote:
> On 28.3.2018 01:28, Joe Hershberger wrote:
>> Hi Heinrich,
>>
>> On Wed, Feb 28, 2018 at 5:05 PM, Heinrich Schuchardt
>>  wrote:
>>> On 02/28/2018 02:09 AM, Tom Rini wrote:

 On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:

> Enable networking command only when NET is enabled.
> And remove selecting NET for CMD_NET
>
> Signed-off-by: Michal Simek 
> ---
>
> Changes in v2:
> - Check several boards by hand.
>
> There is a huge impact on defconfigs because of select NET.
> But this change makes sense to do but it just needs to be syncup
> properly. Do we have a tool for this kind of change?


 So, I've applied this patch, with a good bit of modification.  What I
 wasn't clear about before, sorry, was that we need to make NET default y
 in here too.  However, we also have some decent areas of the code that
 use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
 conceptually.  But in order to make everything work as-is today, and
 leave these fixes to a later point in time (as they are fixes and should
 happen) we change some areas today that reference CONFIG_NET to
 reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
 CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
 100% size-neutral as the topic_miami* boards were playing some games
 that can't quite be done as they were before, but I believe the end
 result is they can now more easily and thoroughly disable the networking
 stuff that intended to be removed.


>>>
>>> Hello Tom,
>>>
>>> in spite of you comments above I do not understand why you changed
>>> cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.
>>>
>>> This was not part of Michal's patch.
>>>
>>> I would prefer if changes would be sent to the list for review *before*
>>> being applied.
>>>
>>> As the patch that you applied is not Michal's patch your authorship should
>>> be documented in the git log.
>>>
>>> I cannot see any reason why network support should be disabled in bootefi if
>>> there are no network commands available.
>>
>> I think there is a fair amount of conflation since some of the basic
>> functions like bootp and dhcp are only accessible through the
>> commands, but you're right that it should be possible to use
>> networking with a static IP and no network commands.
>
> Can you please be more specific how you can use network without network
> commands?

In this case, if EFI is using the network, then U-Boot need not have
any commands that use it. NetConsole is probably another example.

-Joe
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-03-28 Thread Michal Simek 
On 28.3.2018 01:28, Joe Hershberger wrote:
> Hi Heinrich,
> 
> On Wed, Feb 28, 2018 at 5:05 PM, Heinrich Schuchardt
>  wrote:
>> On 02/28/2018 02:09 AM, Tom Rini wrote:
>>>
>>> On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:
>>>
 Enable networking command only when NET is enabled.
 And remove selecting NET for CMD_NET

 Signed-off-by: Michal Simek 
 ---

 Changes in v2:
 - Check several boards by hand.

 There is a huge impact on defconfigs because of select NET.
 But this change makes sense to do but it just needs to be syncup
 properly. Do we have a tool for this kind of change?
>>>
>>>
>>> So, I've applied this patch, with a good bit of modification.  What I
>>> wasn't clear about before, sorry, was that we need to make NET default y
>>> in here too.  However, we also have some decent areas of the code that
>>> use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
>>> conceptually.  But in order to make everything work as-is today, and
>>> leave these fixes to a later point in time (as they are fixes and should
>>> happen) we change some areas today that reference CONFIG_NET to
>>> reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
>>> CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
>>> 100% size-neutral as the topic_miami* boards were playing some games
>>> that can't quite be done as they were before, but I believe the end
>>> result is they can now more easily and thoroughly disable the networking
>>> stuff that intended to be removed.
>>>
>>>
>>
>> Hello Tom,
>>
>> in spite of you comments above I do not understand why you changed
>> cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.
>>
>> This was not part of Michal's patch.
>>
>> I would prefer if changes would be sent to the list for review *before*
>> being applied.
>>
>> As the patch that you applied is not Michal's patch your authorship should
>> be documented in the git log.
>>
>> I cannot see any reason why network support should be disabled in bootefi if
>> there are no network commands available.
> 
> I think there is a fair amount of conflation since some of the basic
> functions like bootp and dhcp are only accessible through the
> commands, but you're right that it should be possible to use
> networking with a static IP and no network commands.

Can you please be more specific how you can use network without network
commands?

Thanks,
Michal


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-03-27 Thread Joe Hershberger 
Hi Heinrich,

On Wed, Feb 28, 2018 at 5:05 PM, Heinrich Schuchardt
 wrote:
> On 02/28/2018 02:09 AM, Tom Rini wrote:
>>
>> On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:
>>
>>> Enable networking command only when NET is enabled.
>>> And remove selecting NET for CMD_NET
>>>
>>> Signed-off-by: Michal Simek 
>>> ---
>>>
>>> Changes in v2:
>>> - Check several boards by hand.
>>>
>>> There is a huge impact on defconfigs because of select NET.
>>> But this change makes sense to do but it just needs to be syncup
>>> properly. Do we have a tool for this kind of change?
>>
>>
>> So, I've applied this patch, with a good bit of modification.  What I
>> wasn't clear about before, sorry, was that we need to make NET default y
>> in here too.  However, we also have some decent areas of the code that
>> use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
>> conceptually.  But in order to make everything work as-is today, and
>> leave these fixes to a later point in time (as they are fixes and should
>> happen) we change some areas today that reference CONFIG_NET to
>> reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
>> CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
>> 100% size-neutral as the topic_miami* boards were playing some games
>> that can't quite be done as they were before, but I believe the end
>> result is they can now more easily and thoroughly disable the networking
>> stuff that intended to be removed.
>>
>>
>
> Hello Tom,
>
> in spite of you comments above I do not understand why you changed
> cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.
>
> This was not part of Michal's patch.
>
> I would prefer if changes would be sent to the list for review *before*
> being applied.
>
> As the patch that you applied is not Michal's patch your authorship should
> be documented in the git log.
>
> I cannot see any reason why network support should be disabled in bootefi if
> there are no network commands available.

I think there is a fair amount of conflation since some of the basic
functions like bootp and dhcp are only accessible through the
commands, but you're right that it should be possible to use
networking with a static IP and no network commands.

> Please, undo this change.
>
> Best regards
>
> Heinrich
>
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-03-01 Thread Heinrich Schuchardt 
On 03/01/2018 12:14 AM, Tom Rini wrote:
> On Thu, Mar 01, 2018 at 12:05:52AM +0100, Heinrich Schuchardt wrote:
>> On 02/28/2018 02:09 AM, Tom Rini wrote:
>>> On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:
>>>
 Enable networking command only when NET is enabled.
 And remove selecting NET for CMD_NET

 Signed-off-by: Michal Simek 
 ---

 Changes in v2:
 - Check several boards by hand.

 There is a huge impact on defconfigs because of select NET.
 But this change makes sense to do but it just needs to be syncup
 properly. Do we have a tool for this kind of change?
>>>
>>> So, I've applied this patch, with a good bit of modification.  What I
>>> wasn't clear about before, sorry, was that we need to make NET default y
>>> in here too.  However, we also have some decent areas of the code that
>>> use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
>>> conceptually.  But in order to make everything work as-is today, and
>>> leave these fixes to a later point in time (as they are fixes and should
>>> happen) we change some areas today that reference CONFIG_NET to
>>> reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
>>> CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
>>> 100% size-neutral as the topic_miami* boards were playing some games
>>> that can't quite be done as they were before, but I believe the end
>>> result is they can now more easily and thoroughly disable the networking
>>> stuff that intended to be removed.
>>>
>>>
>>
>> Hello Tom,
>>
>> in spite of you comments above I do not understand why you changed
>> cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.
> 
> Because the underlying generic network functionality that efi_loader
> uses is actually gated under CONFIG_CMD_NET and not CONFIG_NET.  This
> should be corrected, in the long term.
> 
>> This was not part of Michal's patch.
>>
>> I would prefer if changes would be sent to the list for review *before*
>> being applied.
>>
>> As the patch that you applied is not Michal's patch your authorship should
>> be documented in the git log.
> 
> Ah, I forgot to add my S-o-B?  Oops, that was unintentional.

It is not that your Signed-of-by is missing. But your signature follows
directly Michal's. So it looks as if you applied the patch signed by
Michal unchanged.

Best regards

Heinrich

> 
>> I cannot see any reason why network support should be disabled in bootefi if
>> there are no network commands available.
> 
> In theory and concept, I agree.  In current implementation, that is not
> the case and I would welcome further changes that make the code reflect
> the general intention.
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-02-28 Thread Tom Rini 
On Thu, Mar 01, 2018 at 12:05:52AM +0100, Heinrich Schuchardt wrote:
> On 02/28/2018 02:09 AM, Tom Rini wrote:
> >On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:
> >
> >>Enable networking command only when NET is enabled.
> >>And remove selecting NET for CMD_NET
> >>
> >>Signed-off-by: Michal Simek 
> >>---
> >>
> >>Changes in v2:
> >>- Check several boards by hand.
> >>
> >>There is a huge impact on defconfigs because of select NET.
> >>But this change makes sense to do but it just needs to be syncup
> >>properly. Do we have a tool for this kind of change?
> >
> >So, I've applied this patch, with a good bit of modification.  What I
> >wasn't clear about before, sorry, was that we need to make NET default y
> >in here too.  However, we also have some decent areas of the code that
> >use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
> >conceptually.  But in order to make everything work as-is today, and
> >leave these fixes to a later point in time (as they are fixes and should
> >happen) we change some areas today that reference CONFIG_NET to
> >reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
> >CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
> >100% size-neutral as the topic_miami* boards were playing some games
> >that can't quite be done as they were before, but I believe the end
> >result is they can now more easily and thoroughly disable the networking
> >stuff that intended to be removed.
> >
> >
> 
> Hello Tom,
> 
> in spite of you comments above I do not understand why you changed
> cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.

Because the underlying generic network functionality that efi_loader
uses is actually gated under CONFIG_CMD_NET and not CONFIG_NET.  This
should be corrected, in the long term.

> This was not part of Michal's patch.
> 
> I would prefer if changes would be sent to the list for review *before*
> being applied.
> 
> As the patch that you applied is not Michal's patch your authorship should
> be documented in the git log.

Ah, I forgot to add my S-o-B?  Oops, that was unintentional.

> I cannot see any reason why network support should be disabled in bootefi if
> there are no network commands available.

In theory and concept, I agree.  In current implementation, that is not
the case and I would welcome further changes that make the code reflect
the general intention.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-02-28 Thread Heinrich Schuchardt 

On 02/28/2018 02:09 AM, Tom Rini wrote:

On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:


Enable networking command only when NET is enabled.
And remove selecting NET for CMD_NET

Signed-off-by: Michal Simek 
---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET.
But this change makes sense to do but it just needs to be syncup
properly. Do we have a tool for this kind of change?


So, I've applied this patch, with a good bit of modification.  What I
wasn't clear about before, sorry, was that we need to make NET default y
in here too.  However, we also have some decent areas of the code that
use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
conceptually.  But in order to make everything work as-is today, and
leave these fixes to a later point in time (as they are fixes and should
happen) we change some areas today that reference CONFIG_NET to
reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
100% size-neutral as the topic_miami* boards were playing some games
that can't quite be done as they were before, but I believe the end
result is they can now more easily and thoroughly disable the networking
stuff that intended to be removed.




Hello Tom,

in spite of you comments above I do not understand why you changed 
cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.


This was not part of Michal's patch.

I would prefer if changes would be sent to the list for review *before* 
being applied.


As the patch that you applied is not Michal's patch your authorship 
should be documented in the git log.


I cannot see any reason why network support should be disabled in 
bootefi if there are no network commands available.


Please, undo this change.

Best regards

Heinrich

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-02-27 Thread Tom Rini 
On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:

> Enable networking command only when NET is enabled.
> And remove selecting NET for CMD_NET
> 
> Signed-off-by: Michal Simek 
> ---
> 
> Changes in v2:
> - Check several boards by hand.
> 
> There is a huge impact on defconfigs because of select NET.
> But this change makes sense to do but it just needs to be syncup
> properly. Do we have a tool for this kind of change?

So, I've applied this patch, with a good bit of modification.  What I
wasn't clear about before, sorry, was that we need to make NET default y
in here too.  However, we also have some decent areas of the code that
use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
conceptually.  But in order to make everything work as-is today, and
leave these fixes to a later point in time (as they are fixes and should
happen) we change some areas today that reference CONFIG_NET to
reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
100% size-neutral as the topic_miami* boards were playing some games
that can't quite be done as they were before, but I believe the end
result is they can now more easily and thoroughly disable the networking
stuff that intended to be removed.

-- 
diff --git a/Kconfig b/Kconfig
index efd77f3129f9..43540614ce66 100644
--- a/Kconfig
+++ b/Kconfig
@@ -69,22 +69,22 @@ config DISTRO_DEFAULTS
imply USE_BOOTCOMMAND
select CMD_BOOTZ if ARM && !ARM64
select CMD_BOOTI if ARM64
-   select CMD_DHCP if NET
-   select CMD_PXE if NET
+   select CMD_DHCP if NET && CMD_NET
+   select CMD_PXE if NET && CMD_NET
select CMD_EXT2
select CMD_EXT4
select CMD_FAT
select CMD_FS_GENERIC
-   select CMD_MII if NET
+   imply CMD_MII if NET
select CMD_PING if NET
select CMD_PART if PARTITIONS
select HUSH_PARSER
-   select BOOTP_BOOTPATH if NET
-   select BOOTP_DNS if NET
-   select BOOTP_GATEWAY if NET
-   select BOOTP_HOSTNAME if NET
-   select BOOTP_PXE if NET
-   select BOOTP_SUBNETMASK if NET
+   select BOOTP_BOOTPATH if NET && CMD_NET
+   select BOOTP_DNS if NET && CMD_NET
+   select BOOTP_GATEWAY if NET && CMD_NET
+   select BOOTP_HOSTNAME if NET && CMD_NET
+   select BOOTP_PXE if NET && CMD_NET
+   select BOOTP_SUBNETMASK if NET && CMD_NET
select CMDLINE_EDITING
select AUTO_COMPLETE
select SYS_LONGHELP
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 83a36bc1927e..136836d14657 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1039,11 +1039,13 @@ config CMD_RARP
 
 config CMD_DHCP
bool "dhcp"
+   depends on CMD_NET
help
  Boot image via network using DHCP/TFTP protocol
 
 config CMD_PXE
bool "pxe"
+   depends on CMD_NET
select MENU
help
  Boot image via network using PXE protocol
diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index 2106ed9c8c8b..c17fa2ca2363 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -42,7 +42,7 @@ static void efi_init_obj_list(void)
 #if defined(CONFIG_LCD) || defined(CONFIG_DM_VIDEO)
efi_gop_register();
 #endif
-#ifdef CONFIG_NET
+#ifdef CONFIG_CMD_NET
efi_net_register();
 #endif
 #ifdef CONFIG_GENERATE_SMBIOS_TABLE
@@ -450,7 +450,7 @@ void efi_set_bootdev(const char *dev, const char *devnr, 
const char *path)
 
bootefi_device_path = efi_dp_from_part(desc, part);
} else {
-#ifdef CONFIG_NET
+#ifdef CONFIG_CMD_NET
bootefi_device_path = efi_dp_from_eth();
 #endif
}
diff --git a/configs/M52277EVB_defconfig b/configs/M52277EVB_defconfig
index c5978468d7cb..fc6ee0ec5b82 100644
--- a/configs/M52277EVB_defconfig
+++ b/configs/M52277EVB_defconfig
@@ -12,12 +12,11 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_DATE=y
 CONFIG_CMD_JFFS2=y
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
diff --git a/configs/M52277EVB_stmicro_defconfig 
b/configs/M52277EVB_stmicro_defconfig
index 962a96e46f87..900020826208 100644
--- a/configs/M52277EVB_stmicro_defconfig
+++ b/configs/M52277EVB_stmicro_defconfig
@@ -11,12 +11,11 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_DATE=y
 CONFIG_CMD_JFFS2=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
diff --git a/configs/M5249EVB_defconfig b/configs/M5249EVB_defconfig
index d61422f5b599..8478136c6b22 100644
--- a/configs/M5249EVB_defconfig
+++ b/configs/M5249EVB_defconfig
@@ -8,6 +8,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y

[U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

2018-02-26 Thread Michal Simek 
Enable networking command only when NET is enabled.
And remove selecting NET for CMD_NET

Signed-off-by: Michal Simek 
---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET.
But this change makes sense to do but it just needs to be syncup
properly. Do we have a tool for this kind of change?

---
 cmd/Kconfig  | 5 -
 configs/aspenite_defconfig   | 2 --
 configs/at91sam9rlek_dataflash_defconfig | 2 --
 configs/at91sam9rlek_mmc_defconfig   | 2 --
 configs/at91sam9rlek_nandflash_defconfig | 2 --
 configs/bcm23550_w1d_defconfig   | 2 --
 configs/bcm28155_ap_defconfig| 2 --
 configs/cairo_defconfig  | 5 ++---
 configs/mx23evk_defconfig| 2 --
 configs/omap3_pandora_defconfig  | 2 --
 configs/origen_defconfig | 4 ++--
 configs/s5p_goni_defconfig   | 2 --
 configs/s5pc210_universal_defconfig  | 5 ++---
 configs/thunderx_88xx_defconfig  | 4 +---
 configs/topic_miami_defconfig| 2 --
 configs/topic_miamilite_defconfig| 2 --
 configs/trats2_defconfig | 5 ++---
 configs/trats_defconfig  | 5 ++---
 configs/tricorder_defconfig  | 2 --
 configs/tricorder_flash_defconfig| 2 --
 configs/warp_defconfig   | 2 --
 configs/zynq_zc770_xm011_defconfig   | 2 --
 configs/zynq_zc770_xm011_x16_defconfig   | 2 --
 23 files changed, 15 insertions(+), 50 deletions(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 18aac7f7d4c3..83a36bc1927e 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1012,9 +1012,10 @@ endmenu
 
 menu "Network commands"
 
+if NET
+
 config CMD_NET
bool "bootp, tftpboot"
-select NET
default y
help
  Network commands.
@@ -1091,6 +1092,8 @@ config CMD_ETHSW
  operations such as enabling / disabling a port and
  viewing/maintaining the filtering database (FDB)
 
+endif
+
 endmenu
 
 menu "Misc commands"
diff --git a/configs/aspenite_defconfig b/configs/aspenite_defconfig
index 7503fec2c976..3ecc55cbd620 100644
--- a/configs/aspenite_defconfig
+++ b/configs/aspenite_defconfig
@@ -7,8 +7,6 @@ CONFIG_BOOTDELAY=3
 CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_MMC is not set
 CONFIG_SYS_NS16550=y
 CONFIG_OF_LIBFDT=y
diff --git a/configs/at91sam9rlek_dataflash_defconfig 
b/configs/at91sam9rlek_dataflash_defconfig
index ac929ff3c1a2..4908eceb0d0c 100644
--- a/configs/at91sam9rlek_dataflash_defconfig
+++ b/configs/at91sam9rlek_dataflash_defconfig
@@ -23,8 +23,6 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_SF=y
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
diff --git a/configs/at91sam9rlek_mmc_defconfig 
b/configs/at91sam9rlek_mmc_defconfig
index 1d4928f20c59..200667b1f2bd 100644
--- a/configs/at91sam9rlek_mmc_defconfig
+++ b/configs/at91sam9rlek_mmc_defconfig
@@ -23,8 +23,6 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_SF=y
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_FAT=y
diff --git a/configs/at91sam9rlek_nandflash_defconfig 
b/configs/at91sam9rlek_nandflash_defconfig
index f5f3b9bbfff0..a9874146bf00 100644
--- a/configs/at91sam9rlek_nandflash_defconfig
+++ b/configs/at91sam9rlek_nandflash_defconfig
@@ -23,8 +23,6 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_SF=y
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_NAND=y
diff --git a/configs/bcm23550_w1d_defconfig b/configs/bcm23550_w1d_defconfig
index d8ea336adff9..b5b10aeb93f4 100644
--- a/configs/bcm23550_w1d_defconfig
+++ b/configs/bcm23550_w1d_defconfig
@@ -19,8 +19,6 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
diff --git a/configs/bcm28155_ap_defconfig b/configs/bcm28155_ap_defconfig
index 49605cc85770..eb96771c5c1c 100644
--- a/configs/bcm28155_ap_defconfig
+++ b/configs/bcm28155_ap_defconfig
@@ -20,8 +20,6 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
diff --git a/configs/cairo_defconfig b/configs/cairo_defconfig
index 7369d578e066..edd37cb64a21 100644
--- a/configs/cairo_defconfig
+++ b/configs/cairo_defconfig
@@ -23,16 +23,15 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 CONFIG_CMD_SPI=y
 #