Re: [U-Boot] [PATCH v2] armv8: fsl-lsch2: enable snoopable usb read and write

2016-12-16 Thread Jerry Huang 


> -Original Message-
> From: Changming Huang [mailto:jerry.hu...@nxp.com]
> Sent: Friday, December 16, 2016 10:38 AM
> To: york sun ; Stuart Yoder ;
> u-boot@lists.denx.de
> Cc: Jerry Huang 
> Subject: [PATCH v2] armv8: fsl-lsch2: enable snoopable usb read and write
> 
> By default the USB IP on the ls1012a/ls1043a/ls1046a SoCs does not generat
> coherent/snoopable transactions. Here enable it in the SCFG_SNPCNFGCR
> register.
> In addition, the dma-coherent property must be set in USB DTS nodes.
> 
> Signed-off-by: Changming Huang 
> ---
> Changes in v2:
>   - fix one comment that is not only for SEC
> 
>  arch/arm/cpu/armv8/fsl-layerscape/soc.c|   15 +--
>  .../include/asm/arch-fsl-layerscape/immap_lsch2.h  |6 ++
>  2 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> index 2f54625..c1dbe53 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> @@ -340,6 +340,7 @@ void fsl_lsch2_early_init_f(void)  {
>   struct ccsr_cci400 *cci = (struct ccsr_cci400
> *)CONFIG_SYS_CCI400_ADDR;
>   struct ccsr_scfg *scfg = (struct ccsr_scfg
> *)CONFIG_SYS_FSL_SCFG_ADDR;
> + u32 snp_usb;
> 
>  #ifdef CONFIG_LAYERSCAPE_NS_ACCESS
>   enable_layerscape_ns_access();
> @@ -352,11 +353,21 @@ void fsl_lsch2_early_init_f(void)  #if
> defined(CONFIG_FSL_QSPI) && !defined(CONFIG_QSPI_BOOT)
>   out_be32(>qspi_cfg, SCFG_QSPI_CLKSEL);  #endif
> - /* Make SEC reads and writes snoopable */
> +
> + snp_usb = SCFG_SNPCNFGCR_USB1RDSNP |
> SCFG_SNPCNFGCR_USB1WRSNP; #if
> +defined(CONFIG_ARCH_LS1043A) || defined(CONFIG_ARCH_LS1046A)
> + snp_usb |= SCFG_SNPCNFGCR_USB2WRSNP |
> + SCFG_SNPCNFGCR_USB2RDSNP |
> + SCFG_SNPCNFGCR_USB3WRSNP |
> + SCFG_SNPCNFGCR_USB3RDSNP;
> +#endif
> +
> + /* Enable some IP's reads and writes snoopable */
>   setbits_be32(>snpcnfgcr, SCFG_SNPCNFGCR_SECRDSNP |
>SCFG_SNPCNFGCR_SECWRSNP |
>SCFG_SNPCNFGCR_SATARDSNP |
> -  SCFG_SNPCNFGCR_SATAWRSNP);
> +  SCFG_SNPCNFGCR_SATAWRSNP |
> +  snp_usb);
> 
>   /*
>* Enable snoop requests and DVM message requests for diff --git
> a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> index b3cfd89..b82db03 100644
> --- a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> @@ -340,6 +340,12 @@ struct ccsr_gur {
>  #define SCFG_SNPCNFGCR_SECWRSNP  0x4000
>  #define SCFG_SNPCNFGCR_SATARDSNP 0x0080
>  #define SCFG_SNPCNFGCR_SATAWRSNP 0x0040
> +#define SCFG_SNPCNFGCR_USB1RDSNP 0x0020
> +#define SCFG_SNPCNFGCR_USB1WRSNP 0x0010
> +#define SCFG_SNPCNFGCR_USB2WRSNP 0x0001
> +#define SCFG_SNPCNFGCR_USB2RDSNP 0x8000
> +#define SCFG_SNPCNFGCR_USB3WRSNP 0x4000
> +#define SCFG_SNPCNFGCR_USB3RDSNP 0x2000
> 
>  /* Supplemental Configuration Unit */
>  struct ccsr_scfg {
It seems these bits can't be set, I tested it on ls1043ardb with latest 
u-boot-2017.01-rc1 and  the latest Linux-4.9 with USB3->SATA3.0 adapter.
After setting these bits, the performance is decreased hugely, the write 
performance is just around 25MB/s, but without setting these bits, I can get 
360MB/s.
So please holding this patch, I will study these bits why it impact the 
performance.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] armv8: fsl-lsch2: enable snoopable usb read and write

2016-12-15 Thread Changming Huang 
By default the USB IP on the ls1012a/ls1043a/ls1046a SoCs does not
generat coherent/snoopable transactions. Here enable it in the
SCFG_SNPCNFGCR register.
In addition, the dma-coherent property must be set in USB DTS nodes.

Signed-off-by: Changming Huang 
---
Changes in v2:
  - fix one comment that is not only for SEC

 arch/arm/cpu/armv8/fsl-layerscape/soc.c|   15 +--
 .../include/asm/arch-fsl-layerscape/immap_lsch2.h  |6 ++
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c 
b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
index 2f54625..c1dbe53 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
@@ -340,6 +340,7 @@ void fsl_lsch2_early_init_f(void)
 {
struct ccsr_cci400 *cci = (struct ccsr_cci400 *)CONFIG_SYS_CCI400_ADDR;
struct ccsr_scfg *scfg = (struct ccsr_scfg *)CONFIG_SYS_FSL_SCFG_ADDR;
+   u32 snp_usb;
 
 #ifdef CONFIG_LAYERSCAPE_NS_ACCESS
enable_layerscape_ns_access();
@@ -352,11 +353,21 @@ void fsl_lsch2_early_init_f(void)
 #if defined(CONFIG_FSL_QSPI) && !defined(CONFIG_QSPI_BOOT)
out_be32(>qspi_cfg, SCFG_QSPI_CLKSEL);
 #endif
-   /* Make SEC reads and writes snoopable */
+
+   snp_usb = SCFG_SNPCNFGCR_USB1RDSNP | SCFG_SNPCNFGCR_USB1WRSNP;
+#if defined(CONFIG_ARCH_LS1043A) || defined(CONFIG_ARCH_LS1046A)
+   snp_usb |= SCFG_SNPCNFGCR_USB2WRSNP |
+   SCFG_SNPCNFGCR_USB2RDSNP |
+   SCFG_SNPCNFGCR_USB3WRSNP |
+   SCFG_SNPCNFGCR_USB3RDSNP;
+#endif
+
+   /* Enable some IP's reads and writes snoopable */
setbits_be32(>snpcnfgcr, SCFG_SNPCNFGCR_SECRDSNP |
 SCFG_SNPCNFGCR_SECWRSNP |
 SCFG_SNPCNFGCR_SATARDSNP |
-SCFG_SNPCNFGCR_SATAWRSNP);
+SCFG_SNPCNFGCR_SATAWRSNP |
+snp_usb);
 
/*
 * Enable snoop requests and DVM message requests for
diff --git a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h 
b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
index b3cfd89..b82db03 100644
--- a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
+++ b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
@@ -340,6 +340,12 @@ struct ccsr_gur {
 #define SCFG_SNPCNFGCR_SECWRSNP0x4000
 #define SCFG_SNPCNFGCR_SATARDSNP   0x0080
 #define SCFG_SNPCNFGCR_SATAWRSNP   0x0040
+#define SCFG_SNPCNFGCR_USB1RDSNP   0x0020
+#define SCFG_SNPCNFGCR_USB1WRSNP   0x0010
+#define SCFG_SNPCNFGCR_USB2WRSNP   0x0001
+#define SCFG_SNPCNFGCR_USB2RDSNP   0x8000
+#define SCFG_SNPCNFGCR_USB3WRSNP   0x4000
+#define SCFG_SNPCNFGCR_USB3RDSNP   0x2000
 
 /* Supplemental Configuration Unit */
 struct ccsr_scfg {
-- 
1.7.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot